Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespace from blog to fix precommit #25055

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

damccorm
Copy link
Contributor

This fixes the breakages introduced by #24951 by removing trailing whitespace. It is an alternative to #25048 which removes the rule.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Contributor Author

Run Whitespace PreCommit

@damccorm damccorm marked this pull request as ready for review January 18, 2023 15:02
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, the point is (two space) and (two new line) have the same effect.
would you like taking the chance to fix old release notes where new lines in List of Contributors not rendering (e.g. either add another new line as 2.44.0 release note, or add a comma separator or so)

@lukecwik
Copy link
Member

I'm happy with this as well and I'm going to merge this to get a green signal. We can always revert and remove the whitespace check in the future if people like the alternative more.

@lukecwik
Copy link
Member

The website and whitespace checks passed, just delayed update here.

@lukecwik lukecwik merged commit 95874a7 into master Jan 18, 2023
@damccorm damccorm deleted the users/damccorm/precommit branch January 18, 2023 18:12
@kennknowles
Copy link
Member

This alters <br /> to <p /> does it not?

@kennknowles
Copy link
Member

Just to answer my own question, yes: this PR is not equivalent to what it replaced, but adds a lot of whitespace to the blog post. It reads well anyhow, but wanted to be clear that this is a formatting change, not an alternative formulation of the same formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants