regression: ngHref -

[petebacondarwin]

This commit (f3de5b6) caused an old e2e test to fail (See angular/dgeni#44).

See https://github.com/angular/angular.js/blob/master/src/ng/directive/booleanAttrs.js#L72

<a id="link-4" href="" name="xx" ng-click="value = 4">anchor</a> (link, don't reload)<br />

        it('should execute ng-click but not reload when href empty string and name specified', function() {
          element(by.id('link-4')).click();
          expect(element(by.model('value')).getAttribute('value')).toEqual('4');
          expect(element(by.id('link-4')).getAttribute('href')).toBe('');
        });

Previously, if you had a name but no href it would still prevent the click from propagating. The performance refactor commit, referenced above, changed the a directive so that if there is neither href or name then the click will propagate and so clicking the link would cause the page to reload.

We need to decide if this previous functionality is important and if so modify the a directive accordingly and potentially re-activate the protractor test that was broken. If not, then we should just remove the failing protractor test altogether.

FAO: @IgorMinar and @kseamon

[IgorMinar]

@petebacondarwin would checking !(href in attrs) instead of !attrs.href solve the issue?

[petebacondarwin]

@IgorMinar - I don't believe this would solve the problem. As soon as you have either non-empty href or name attributes on the element then the a directive does not create a click event handler to prevent the default action when clicked. In this case, it is the name attribute that is doing it not the href.

So I think the real issue is that we don't want to reload is if there is an ngClick event on the anchor, right? If there is just a name or href and no ngClick then it should act as a link and reload.

If so then the obvious solution is to call preventDefault() in the ngClick handler. You can see this works here: http://plnkr.co/edit/GVCeQpwUCia38gyzaBMe?p=preview

Now this is a simple workaround (by creating an additional ngClick directive) that people could apply, and so should be documented. But is it good enough that it should be applied to the ngClick directive by default?

Also are there other scenarios that this doesn't fix?

href	name	ngClick	reload?
no	no	no	no
yes	no	no	yes
no	yes	no	no
yes	yes	no	yes
no	no	yes	no
yes	no	yes	no
no	yes	yes	no
yes	yes	yes	no