-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ngHref example acts strange #44
Comments
Also for completeness - in the old docs, it did not reload: http://docs.angularjs.org/api/ng.directive:ngHref |
This doesn't happen for me. |
I think that the functionality has changed with this commit: angular/angular.js@f3de5b6 But that for some reason it is not picked up in the old docs... |
I vote for removing that bit from the example... |
Here is the culprit, I reckon: https://github.com/angular/angular.js/blob/master/docs/components/angular-bootstrap/bootstrap-prettify.js#L235 All clicks inside the embedded app are blocked from propagating - so I reckon this prevents the page from reloading. |
Fixed by xit-ing the spec. Once we agree whether this regression is an issue we can either reinstate with a revert/fix or just remove altogether. |
Created an issue in main angular.js - #6273 |
Running locally - http://localhost:8000/build/docs/examples/example-example4/index.html
Note that clicking on the anchor which says it will not reload does in fact reload.
The text was updated successfully, but these errors were encountered: