Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngHref example acts strange #44

Closed
juliemr opened this issue Feb 12, 2014 · 7 comments
Closed

ngHref example acts strange #44

juliemr opened this issue Feb 12, 2014 · 7 comments
Labels

Comments

@juliemr
Copy link
Member

juliemr commented Feb 12, 2014

Running locally - http://localhost:8000/build/docs/examples/example-example4/index.html

Note that clicking on the anchor which says it will not reload does in fact reload.

@juliemr
Copy link
Member Author

juliemr commented Feb 12, 2014

Also for completeness - in the old docs, it did not reload: http://docs.angularjs.org/api/ng.directive:ngHref

@petebacondarwin
Copy link
Contributor

This doesn't happen for me.

@petebacondarwin
Copy link
Contributor

I think that the functionality has changed with this commit: angular/angular.js@f3de5b6

But that for some reason it is not picked up in the old docs...

@petebacondarwin
Copy link
Contributor

I vote for removing that bit from the example...

@petebacondarwin
Copy link
Contributor

Here is the culprit, I reckon: https://github.com/angular/angular.js/blob/master/docs/components/angular-bootstrap/bootstrap-prettify.js#L235

All clicks inside the embedded app are blocked from propagating - so I reckon this prevents the page from reloading.

@petebacondarwin
Copy link
Contributor

Fixed by xit-ing the spec. Once we agree whether this regression is an issue we can either reinstate with a revert/fix or just remove altogether.

@petebacondarwin
Copy link
Contributor

Created an issue in main angular.js - #6273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants