[htmlAnchorDirective] name on achor tag reloads the UI

[rajeshsegu]

Anchor tag with non empty name, reloads the page:

<a name='http://yahoo.com' value="value=4">link</a> 

As per angular source code, does not comply with the ngClick unit test case behaviour. ( Might have leaked trough since we don't assert if the reload happened )

it('should execute ng-click but not reload when href empty string and name specified', function() {
          element(by.id('link-4')).click();
          expect(element(by.model('value')).getAttribute('value')).toEqual('4');
          expect(element(by.id('link-4')).getAttribute('href')).toBe('');
        });

Looks like it leaked trough the source code via commit @ f3de5b6

As per W3Schools http://www.w3schools.com/tags/att_a_name.asp

The <a> name attribute is not supported in HTML5. Use the id attribute instead.

Why does angular have to bother about handling "name" when its not supported by HTML5 ? Personally, it seems like a specific case quick fix, rather than a generic fix.

I would happy to submit code if this has not been addressed as of today.

[lord2800]

Because the a tag does support name in HTML4.

[rajeshsegu]

@lord2800 Then I suppose we might need to change the unit case to reflect the behavior.

[lord2800]

I believe that is the case--based on the commit @ f3de5b6. From what I read of the commit and the message, this test is now wrong.

[caitp]

I think the test passes simply because $location is not injected --- so the test isn't really accurate anyways.

I don't think we're going to end up "fixing" the page-reload thing, because @kseamon thinks we need it, but we can make the test more accurate.

In any case, you should be able to prevent the page-reload by calling preventDefault() on the $event object in your ng-click handler

[caitp]

hmm, from karls commit message, event delegation might work better for this (but I can't remember if we decided to go with event delegation for ngClick or not)

[petebacondarwin]

Closing as this is a dupe of #6273