Support Foreign objects as ABI arguments and address ARC-4 changes #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o it can pass these tests
barnjamin
reviewed
Nov 19, 2021
barnjamin
reviewed
Nov 19, 2021
barnjamin
suggested changes
Nov 21, 2021
ahangsu
reviewed
Dec 27, 2021
ahangsu
reviewed
Dec 27, 2021
ahangsu
reviewed
Dec 27, 2021
ahangsu
reviewed
Dec 27, 2021
ahangsu
reviewed
Dec 27, 2021
ahangsu
reviewed
Dec 27, 2021
barnjamin
approved these changes
Dec 27, 2021
ahangsu
reviewed
Dec 27, 2021
jasonpaulos
reviewed
Dec 28, 2021
jasonpaulos
reviewed
Dec 28, 2021
ahangsu
reviewed
Dec 28, 2021
ahangsu
reviewed
Dec 28, 2021
jasonpaulos
reviewed
Dec 28, 2021
jasonpaulos
reviewed
Dec 28, 2021
jasonpaulos
approved these changes
Dec 28, 2021
ahangsu
approved these changes
Dec 28, 2021
aldur
pushed a commit
that referenced
this pull request
Feb 8, 2022
) * Start ABI JSON interaction * Add static annoation * Fix Method argument parsing * Add ABI Typing to Method arguments * [WIP] Add AtomicTransactionComposer build functions * [WIP] Sign and send atomic transaction groups * Add unit tests for object parsing * Clean up method calls * Address PR comments on JSON objects * Refactor ABI Type to ABIType so it can be exposed to outside world * Add cucumber steps for ABI tests and update existing implementation so it can pass these tests * Refactor TransactionSigner to Abstract class and merge signatures when signing * Update testing to reflect json unit tests and composer tests * Formatting and docstring fixes * Add foreign types for method arguments * Clean up imports * Fix unit test for appId * Add unit test for foreign array * Refactor some names and add txn as an arg type * Partially address PR comments * Fix encoding args for foreign types * Add some additional checks for safety * Fix a step so we check for empty string instead of None * Correct foreign app and account indices accounting for the implicit argument * Resolve formatting * Fix unit tests * Fix foreign objects to compact duplicates and special values * Refactor foreign objects, transactions, and address some new ABI changes * ABI composer modifications and test updates * Change Interface and Contract to newest ABI changes * Fix some integration tests for composer * Fix remaining composer tests * Formatting changes * Fix method json tests * Address PR Comments, clean up and refactor composer and contract * Create helper function for populating foreign objects * Change type hints on reference and transaction checks * Add generics and fix dictifying network info * Fix step for cucumber test contract parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Foreign accounts, apps, and assets as ABI arguments. In addition, it includes some
addMethodCallInterfaceandContractfrom: ARC-0004: Misc changes algorandfoundation/ARCs#55Closes #250