Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support foreign objects as ABI arguments #250

Closed
jasonpaulos opened this issue Nov 10, 2021 · 0 comments · Fixed by #251
Closed

Support foreign objects as ABI arguments #250

jasonpaulos opened this issue Nov 10, 2021 · 0 comments · Fixed by #251

Comments

@jasonpaulos
Copy link
Contributor

Summary

This is a follow up to #247, which added support for invoking ABI methods.

In addition to standard ABI type arguments, the SDK should support the special foreign object argument types account, asset, and application, as described in ARC-4.

Scope

Extend the AtomicTransactionComposer.add_method_call function to support these new method argument types. At a high level it should:

  1. Recognize when an argument is a special type or a standard ABI type. The special argument types are only valid as top-level arguments, so direct string comparison should be sufficient.
  2. If a special type is present, insert the argument value into the appropriate foreign array, and use the array index of the value as the app call argument, treated as an ABI uint8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants