Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ABI changes #264

Closed
jasonpaulos opened this issue Dec 9, 2021 · 2 comments · Fixed by #251
Closed

Implement ABI changes #264

jasonpaulos opened this issue Dec 9, 2021 · 2 comments · Fixed by #251
Assignees

Comments

@jasonpaulos
Copy link
Contributor

Implement the changes described in algorandfoundation/ARCs#53

Additionally, the following implementation details should change:

  • The atomic transaction composer should not add a group ID if there's only 1 transaction in the group, since it's unnecessary
  • The atomic transaction composer should check that the type of a transaction argument (e.g. pay, axfer, etc.) matches the ABI transaction argument type.
@jasonpaulos
Copy link
Contributor Author

jasonpaulos commented Dec 18, 2021

Additionally, based on algorandfoundation/ARCs#57 and algorandfoundation/ARCs#55:

  • The atomic transaction composer should allow app creation & update transactions to be made using the add_method_call method
  • The composer should only check the last log for the return value
  • Contract and Interface objects should have a description field

@algochoi
Copy link
Contributor

Linked to #251

@algochoi algochoi linked a pull request Dec 22, 2021 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants