-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop into conduit. #1303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: algobarb <[email protected]>
This reverts commit 0a8af61.
* Start on round 1 since round 0 is now computed from the genesis file. * Wait for indexer processor to exit. * Better logging for metric collection errors. * Proper support for data directory. * New test script for future release automation.
This reverts commit 7915890.
* Update go-algorand submodule * Fix test failure due to duplicate txns * Add new ledger interface method
…evaluator (algorand#1146) removing a bunch of code and make the random test pass with the new ledger for evaluator
* Update README header
…le that uses submodule instead of channel (algorand#1151) * Eric's Dockerfile improvements * Update misc/e2elive.py
Adds API support to the Indexer for State Proof Transactions and header fields. Co-authored-by: Will Winder <[email protected]> Co-authored-by: Will Winder <[email protected]>
Give a default config if not supplied to stop panics.
* adding ParticipationUpdates to block reponse
…if there are too many transactions. (algorand#1241) * update block lookup handler
…pointCatchupAccessor (algorand#1257) * MakeCatchpointCatchupAccessor * update test job's CI_E2E_FILENAME to latest rel-nightly s3 key
Resolves algorand#1246 Fixes order of configuration so that logger can be set properly
Validator improvements. Report the canonical address name even if the b64 address is used. Avoid reporting skipped accounts unless using new '--print-skipped' flag. Fix REST API error encoding. Detect algod result limit reached errors.
Codecov Report
@@ Coverage Diff @@
## conduit #1303 +/- ##
===========================================
+ Coverage 58.89% 60.19% +1.29%
===========================================
Files 78 78
Lines 10513 10880 +367
===========================================
+ Hits 6192 6549 +357
+ Misses 3768 3735 -33
- Partials 553 596 +43
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
commented
Nov 2, 2022
winder
requested review from
Eric-Warehime,
AlgoStephenAkiki,
shiqizng and
tzaffi
November 2, 2022 12:58
shiqizng
approved these changes
Nov 2, 2022
tzaffi
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The portions related to boxes look good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.