Disable deadlock detection

[winder]

Summary

Make sure deadlock detection is turned off when running fast catchup.

[cce]

I don't think this will have any impact.. you need to disable in your indexer main.go or daemon.go at startup time.

[winder]

Startup of what? This the config passed into the service, it doesn't exist until this function.

[cce]

Like this

diff --git a/cmd/algorand-indexer/main.go b/cmd/algorand-indexer/main.go
index c1540fc..dff7626 100644
--- a/cmd/algorand-indexer/main.go
+++ b/cmd/algorand-indexer/main.go
@@ -11,6 +11,7 @@ import (
    "github.com/spf13/cobra/doc"
    "github.com/spf13/viper"

+   "github.com/algorand/go-deadlock"
    bg "github.com/algorand/indexer/cmd/block-generator/core"
    v "github.com/algorand/indexer/cmd/validator/core"
    "github.com/algorand/indexer/config"
@@ -94,6 +95,9 @@ func indexerDbFromFlags(opts idb.IndexerDbOptions) (idb.IndexerDb, chan struct{}
 }

 func init() {
+   // disable go-deadlock detection
+   deadlock.Opts.Disable = true
+
    // Utilities subcommand for more convenient access to useful testing utilities.
    utilsCmd := &cobra.Command{
        Use:   "util",

[cce]

The go-algorand objects you are passing cfg to don't do anything with cfg.DeadlockDetection — this config value (and/or build flag) is checked and set at service start / init time.

[winder]

Fixed

[cce]

seems fine, I would prefer explicit vs implicit, but LGTM

[codecov]

Codecov Report

Merging #1186 (9e33e3b) into release/2.14.0 (777a34d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           release/2.14.0    #1186      +/-   ##
==================================================
+ Coverage           60.80%   60.81%   +0.01%     
==================================================
  Files                  51       52       +1     
  Lines                8472     8475       +3     
==================================================
+ Hits                 5151     5154       +3     
  Misses               2862     2862              
  Partials              459      459              

Impacted Files	Coverage Δ
util/disabledeadlock/disable_deadlock.go	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more