fix: use CI_E2E_FILENAME in s3 prefix #1255
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1255 +/- ##
===========================================
+ Coverage 61.11% 61.14% +0.03%
===========================================
Files 52 52
Lines 8512 8512
===========================================
+ Hits 5202 5205 +3
+ Misses 2848 2846 -2
+ Partials 462 461 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
misc/e2elive.py
Outdated
| tarname = tarname.split("/")[1] | ||
| cmhash_tarnme = tarname.split("/") | ||
| cmhash = cmhash_tarnme[0] | ||
| tarname =cmhash_tarnme[1] | ||
| prefix+="/"+cmhash | ||
| tarpath = os.path.join(tempdir, tarname) |
There was a problem hiding this comment.
Could you elaborate on whats happening here?
If I'm reading right it looks like this supports tarname with one slash in it. Should we support multiple slashes?
There was a problem hiding this comment.
this is for parsing string like fafa8862/rel-nightly and creating the correct prefix. boto3 client isn't able to find a file named fafa8862/rel-nightly.tar.bz2 ats3://algorand-testdata/indexer/e2e4/${RSTAMP}. So, we need to provide it the exact s3 folder path, s3://algorand-testdata/indexer/e2e4/${RSTAMP}/fafa8862, and the tarname rel-nightly
There was a problem hiding this comment.
I don't think it's possible to support filenames with / without having to update the prefix.
Summary
This PR fixes a string parsing error in e2e test script. commit hash wasn't included in the s3 file prefix and so e2e test was only using the latest artifact from nightly build.
Test Plan
check CI build to make sure test artifact is downloaded from the correct file path.