feat(api): use generated code by version from akash-api #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygrishajev
force-pushed
the
feature/api-proto
branch
3 times, most recently
from
13938f2 to
7cf4757
Compare
Also remove relevant local barrel index files. refs akash-network/support#184
ygrishajev
force-pushed
the
feature/api-proto
branch
from
7cf4757 to
6234224
Compare
baktun14
approved these changes
May 6, 2024
deploy-web/src/utils/proto/index.ts
Outdated
|
|
||
| const mainnetTypes = { ...v1beta3, ...v1beta4 }; | ||
| const sandboxTypes = { ...v1beta3, ...v1beta4 }; | ||
| const commonTypes = { ...omit(v1beta3, "GPU"), ...v1beta4 }; |
There was a problem hiding this comment.
Why are we omitting GPU again?
There was a problem hiding this comment.
Yeah we are not using it in the deploy-web project. We can keep it ommited, but I don't think it's that bad if it gets included here anyway.
There was a problem hiding this comment.
@Redm4x I can add it back, should I?
Redm4x
approved these changes
May 7, 2024
deploy-web/src/utils/proto/index.ts
Outdated
|
|
||
| const mainnetTypes = { ...v1beta3, ...v1beta4 }; | ||
| const sandboxTypes = { ...v1beta3, ...v1beta4 }; | ||
| const commonTypes = { ...omit(v1beta3, "GPU"), ...v1beta4 }; |
There was a problem hiding this comment.
Yeah we are not using it in the deploy-web project. We can keep it ommited, but I don't think it's that bad if it gets included here anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove relevant local barrel index files.
refs akash-network/support#184