Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript protobuf generation #184

Closed
2 tasks done
baktun14 opened this issue Feb 19, 2024 · 9 comments
Closed
2 tasks done

Typescript protobuf generation #184

baktun14 opened this issue Feb 19, 2024 · 9 comments
Assignees
@ygrishajev @chainzero
Labels
P2

Comments

@baktun14
Copy link

Is your feature request related to a problem? Please describe.

The typescript protobuf generation are currently done in akashjs, while the go ones are done in akash-api. We need to centralize the logic of generating the protobuf types for multiple languages in the same repo (akash-api).

Describe the solution you'd like

  • Move from akashjs and write a script/procedure to generate the typescript types
  • Build a npm package from the generated protobuf types
  • Import that npm package in akashjs

Describe alternatives you've considered

This is the best we got!

Search

  • I did search for other open and closed issues before opening this

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response
@baktun14
Copy link
Author

For rust: #176

@github-project-automation github-project-automation bot moved this to Backlog (not prioritized) in Core Product and Engineering Roadmap Feb 20, 2024
@brewsterdrinkwater brewsterdrinkwater moved this from Backlog (not prioritized) to Up Next (prioritized) in Core Product and Engineering Roadmap Feb 20, 2024
@chainzero chainzero self-assigned this Feb 21, 2024
@chainzero chainzero added the P2 label Feb 21, 2024
@baktun14 baktun14 removed their assignment Mar 13, 2024
@baktun14 baktun14 moved this from Up Next (prioritized) to In Progress (prioritized) in Core Product and Engineering Roadmap Mar 14, 2024
@baktun14
Copy link
Author

baktun14 commented Mar 14, 2024 •
edited
Loading

@ygrishajev
Copy link

atm some discussions are done, overall vision is being formed and some initial code has been pushed. Overall it's just started taking into account that I'm getting familiar with akash-api code.

@baktun14
Copy link
Author

baktun14 commented Apr 2, 2024

Also this commit not sure. cc @Redm4x

@brewsterdrinkwater
Copy link
Collaborator

April 30th, 2024:

  • Some issues came up last week. New PR is pending to solve issues.

@ygrishajev
Copy link

Appeared cloudmos indexer is using code generation for connectrpc. Had to adjust akash-api code generation to later use common implementation in the indexer akash-network/akash-api#158

@ygrishajev
Copy link

Another issue: akashjs still needs some deprecated generated code for cloudmos. So I'm going to move it to akash-api too to keep separation of concerns proper.
After all this is a common thing that some archived types might be needed. Akash-api makes it a logical location for those

troian pushed a commit to akash-network/akash-api that referenced this issue May 3, 2024
@ygrishajev
feat(ts): implement grpc-js client services (#158)
c0913e0 
refs akash-network/support#184

ensure non-conflicting dirs for patch preservation
improve formatting to make sure it works from the root dir
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 6, 2024
@ygrishajev
feat(api): use deprecated generated code from akash-api
7b14639 
Also remove relevant local files.

refs akash-network/support#184
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 6, 2024
@ygrishajev
feat(api): use deprecated generated code from akash-api
11a7d35 
Also remove relevant local files.

refs akash-network/support#184
@ygrishajev ygrishajev mentioned this issue May 6, 2024
Merged
ygrishajev added a commit to akash-network/console that referenced this issue May 6, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
80cd451 
Also remove relevant local barrel index files.

refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 6, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
49bd4d0 
Also remove relevant local barrel index files.

refs akash-network/support#184
@ygrishajev ygrishajev mentioned this issue May 6, 2024
Merged
ygrishajev added a commit to akash-network/console that referenced this issue May 6, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
e774f40 
Also remove relevant local barrel index files.

refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 6, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
13938f2 
Also remove relevant local barrel index files.

refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 6, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
7cf4757 
Also remove relevant local barrel index files.

refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 6, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
6234224 
Also remove relevant local barrel index files.

refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 6, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
78dbf35 
Also remove relevant local barrel index files.

refs akash-network/support#184
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 7, 2024
@ygrishajev
feat(api): use deprecated generated code from akash-api
b95352f 
Also remove relevant local files.

refs akash-network/support#184
github-actions bot pushed a commit to akash-network/akashjs that referenced this issue May 7, 2024
@semantic-release-bot
chore(release): 0.7.0 [skip ci]
cfbb507 
## [0.7.0](v0.6.3...v0.7.0) (2024-05-07)

### Features

* **api:** use deprecated generated code from akash-api ([b95352f](b95352f)), closes [akash-network/support#184](akash-network/support#184)
ygrishajev added a commit to akash-network/console that referenced this issue May 7, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
805c52d 
Also remove relevant local barrel index files.

refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 7, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
781459b 
Also remove relevant local barrel index files.

refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 7, 2024
@ygrishajev
feat(api): use all the types in indexer
fa71533 
refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 7, 2024
@ygrishajev
chore(deps): remove unused packages
70c7c5e 
refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 8, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
eadc869 
Also remove relevant local barrel index files.

refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 8, 2024
@ygrishajev
feat(api): use all the types in indexer
9103462 
refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 8, 2024
@ygrishajev
chore(deps): remove unused packages
d1ca19a 
refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 10, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
876c736 
Also remove relevant local barrel index files.

refs akash-network/support#184
ygrishajev added a commit to akash-network/console that referenced this issue May 13, 2024
@ygrishajev
feat(api): use generated code by version from akash-api
ca2b33a 
Also remove relevant local barrel index files.

refs akash-network/support#184
@ygrishajev ygrishajev moved this from In Progress (prioritized) to In Test (or staging) in Core Product and Engineering Roadmap May 13, 2024
@ygrishajev ygrishajev moved this from In Test (or staging) to In Progress (prioritized) in Core Product and Engineering Roadmap May 13, 2024
@ygrishajev
Copy link

All the tech implementation is done. It's uncovered though that there are examples that should also be updated as some community members struggle with the implementation.

ygrishajev added a commit to akash-network/akash-api that referenced this issue May 14, 2024
@ygrishajev
feat(ts): add required market exports
13fdff1 
refs akash-network/support#184
@ygrishajev ygrishajev mentioned this issue May 14, 2024
Merged
ygrishajev added a commit to akash-network/akash-api that referenced this issue May 14, 2024
@ygrishajev
feat(ts): add required exports
e2be77b 
refs akash-network/support#184
troian pushed a commit to akash-network/akash-api that referenced this issue May 14, 2024
@ygrishajev
feat(ts): add required market exports (#175)
dd6f4d4 
refs akash-network/support#184
@ygrishajev ygrishajev moved this from In Progress (prioritized) to In Test (or staging) in Core Product and Engineering Roadmap May 15, 2024
@ygrishajev ygrishajev moved this from In Test (or staging) to Released (in Prod) in Core Product and Engineering Roadmap May 15, 2024
@ygrishajev ygrishajev moved this from Released (in Prod) to In Test (or staging) in Core Product and Engineering Roadmap May 17, 2024
@ygrishajev ygrishajev moved this from In Test (or staging) to In Progress (prioritized) in Core Product and Engineering Roadmap May 17, 2024
@ygrishajev ygrishajev moved this from In Progress (prioritized) to In Test (or staging) in Core Product and Engineering Roadmap May 17, 2024
@ygrishajev ygrishajev moved this from In Test (or staging) to Released (in Prod) in Core Product and Engineering Roadmap May 17, 2024
@ygrishajev
Copy link

this issue can be closed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ygrishajev ygrishajev

@chainzero chainzero

Labels
P2
Projects
Core Product and Engineering Roadmap
Status: Released (in Prod)
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brewsterdrinkwater @ygrishajev @baktun14 @chainzero