Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Akashjs validation #133

Closed
baktun14 opened this issue Mar 19, 2024 · 4 comments
Closed

Improve Akashjs validation #133

baktun14 opened this issue Mar 19, 2024 · 4 comments
Assignees
@ygrishajev
Labels
enhancement New feature or request P2 priority 2 feature/ enhancement

Comments

@baktun14
Copy link
Contributor

baktun14 commented Mar 19, 2024 •
edited
Loading

  • Move custom validation done in Cloudmos for the SDL parsing to Akashjs
  • Properly show the error message in Cloudmos when the validation throws in akashjs
  • Improve the logic between between Cloudmos and the SDL parsing from Akashjs
@github-project-automation github-project-automation bot moved this to Backlog (not prioritized) in Core Product and Engineering Roadmap Mar 19, 2024
@ygrishajev
Copy link
Contributor

@baktun14 why moving it to akashjs? is it needed anywhere else besides cloudmos?

@baktun14
Copy link
Contributor Author

Initially the sdl parsing was done in Cloudmos for Cloudmos and akashjs implemented the same logic so we migrated to use akashjs's implementation. However, there's some validation done to make sure the SDL is valid that we implemented in Cloudmos that was partially implemented in akashjs.

So now it's just a matter of moving all the validation logic to the same place, in AkashJS.

For context, we implemented the validation based on the validation done on the nodes in go code. So we can validate the SDL dynamically in the client without getting an error along the way when creating the transactions to create a deployment or to send a manifest.

@baktun14
Copy link
Contributor Author

cc @troian I know you mentionned about moving the SDL parsing logic to akash-api. Let us know if you have something to add about the validation of the SDLs.

@ygrishajev ygrishajev self-assigned this Apr 19, 2024
@ygrishajev ygrishajev moved this from Backlog (not prioritized) to In Progress (prioritized) in Core Product and Engineering Roadmap Apr 19, 2024
@baktun14 baktun14 added enhancement New feature or request P2 priority 2 feature/ enhancement labels Apr 30, 2024
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 6, 2024
@ygrishajev
feat(api): move deployment relations and ip lease validation from clo…
8a500e3 
…udmos

refs akash-network/console#133
ygrishajev added a commit that referenced this issue May 6, 2024
@ygrishajev
feat(sdl): move validation to akashjs
700049a 
refs #133
ygrishajev added a commit that referenced this issue May 6, 2024
@ygrishajev
feat(sdl): move validation to akashjs
f6faa1f 
refs #133
ygrishajev added a commit that referenced this issue May 6, 2024
@ygrishajev
feat(sdl): move validation to akashjs
b1acb58 
refs #133
ygrishajev added a commit that referenced this issue May 6, 2024
@ygrishajev
feat(sdl): move validation to akashjs
3ea323b 
refs #133
ygrishajev added a commit that referenced this issue May 7, 2024
@ygrishajev
feat(sdl): move validation to akashjs
4803bca 
refs #133
ygrishajev added a commit that referenced this issue May 7, 2024
@ygrishajev
chore(deps): upgrade akashjs and akash-api to the latest versions
4b3cd67 
refs #133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 7, 2024
@ygrishajev
feat(api): move deployment relations and ip lease validation from clo…
f51dfc1 
…udmos

refs akash-network/console#133
ygrishajev added a commit that referenced this issue May 7, 2024
@ygrishajev
feat(api): use all the types in api and web
71c0a43 
refs #133
ygrishajev added a commit that referenced this issue May 7, 2024
@ygrishajev
chore(deps): upgrade akashjs and akash-api to the latest versions
5d49780 
refs #133
ygrishajev added a commit that referenced this issue May 7, 2024
@ygrishajev
feat(api): use all the types in api and web
dfd1947 
refs #133
ygrishajev added a commit that referenced this issue May 7, 2024
@ygrishajev
feat(api): use all the types in indexer
7d43b97 
refs #133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
@ygrishajev
feat(api): move deployment relations and ip lease validation from clo…
4192bf9 
…udmos

refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
@ygrishajev
feat(api): move deployment relations and ip lease validation from clo…
5486eab 
…udmos

refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 8, 2024
@ygrishajev
feat(api): move deployment relations and ip lease validation from clo…
33f70e3 
…udmos

refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 9, 2024
@ygrishajev
test(sdl): cover denom validation
04f0158 
also improve basic yml templating with default values

refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 9, 2024
@ygrishajev
test(sdl): cover denom validation
e1b055a 
also improve basic yml templating with default values

refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 9, 2024
@ygrishajev
test(sdl): cover endpoints validation
1d80ec1 
refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
@ygrishajev
test(sdl): cover endpoints validation
5ff4fee 
refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
@ygrishajev
test(sdl): cover denom validation
ad11eae 
also improve basic yml templating with default values

refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 10, 2024
@ygrishajev
test(sdl): cover endpoints validation
e794887 
refs akash-network/console#133
github-actions bot pushed a commit to akash-network/akashjs that referenced this issue May 10, 2024
@semantic-release-bot
chore(release): 0.8.0 [skip ci]
c8bb80f 
## [0.8.0](v0.7.1...v0.8.0) (2024-05-10)

### Features

* **api:** move deployment relations and ip lease validation from cloudmos ([a7eb767](a7eb767)), closes [akash-network/console#133](akash-network/console#133)
* **sdl:** implement service image credentials ([06a73e8](06a73e8)), closes [akash-network/console#168](akash-network/console#168)
* **sdl:** move denom validation from cloudmos to sdl ([#133](https://github.com/akash-network/akashjs/issues/133)) ([1b5362f](1b5362f))
* **sdl:** move endpoint validation from cloudmos ([#133](https://github.com/akash-network/akashjs/issues/133)) ([0b770ec](0b770ec))
ygrishajev added a commit that referenced this issue May 10, 2024
@ygrishajev
feat(sdl): move validation to akashjs
0e183d5 
refs #133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 13, 2024
@ygrishajev
fix(sdl): fallback credentials email to an empty string
d536c7f 
refs akash-network/console#133
@ygrishajev ygrishajev mentioned this issue May 13, 2024
Merged
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 13, 2024
@ygrishajev
fix(sdl): fallback credentials email to an empty string
4cf0afd 
refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 13, 2024
@ygrishajev
fix(sdl): fallback credentials email to an empty string
4657dc5 
refs akash-network/console#133
github-actions bot pushed a commit to akash-network/akashjs that referenced this issue May 13, 2024
@semantic-release-bot
chore(release): 0.8.1 [skip ci]
d6d4fb3 
## [0.8.1](v0.8.0...v0.8.1) (2024-05-13)

### Bug Fixes

* **sdl:** fallback credentials email to an empty string ([4657dc5](4657dc5)), closes [akash-network/console#133](akash-network/console#133)
ygrishajev added a commit that referenced this issue May 13, 2024
@ygrishajev
chore(deps): upgrade akashjs to the latest
138bb54 
to acquire credentials email default value assignment

refs #133
ygrishajev added a commit that referenced this issue May 13, 2024
@ygrishajev
feat(sdl): move validation to akashjs
07bdd55 
refs #133
ygrishajev added a commit that referenced this issue May 13, 2024
@ygrishajev
chore(deps): upgrade akashjs to the latest
c4c9318 
to acquire credentials email default value assignment

refs #133
@ygrishajev
Copy link
Contributor

This is half done and merged. Had to switch to some more prior issues. Currently in progress

ygrishajev added a commit to akash-network/akashjs that referenced this issue May 14, 2024
@ygrishajev
test(sdl): improve fixture generation to address any further case
27330ac 
refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 14, 2024
@ygrishajev
test(sdl): improve fixture generation to address any further case
0f4c8ca 
refs akash-network/console#133
@ygrishajev ygrishajev mentioned this issue May 14, 2024
Merged
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 14, 2024
@ygrishajev
test(sdl): improve fixture generation to address any further case
97fe303 
refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 16, 2024
@ygrishajev
feat(sdl): add deployment and gpu validation
eb88ca4 
refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 16, 2024
@ygrishajev
feat(sdl): add storage and gpu validation
d138d81 
refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 16, 2024
@ygrishajev
feat(sdl): add storage and gpu validation
7bc4046 
refs akash-network/console#133
@ygrishajev ygrishajev mentioned this issue May 16, 2024
Merged
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 16, 2024
@ygrishajev
feat(sdl): add storage and gpu validation
d0744f5 
refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 17, 2024
@ygrishajev
feat(sdl): add storage and gpu validation
6f48178 
refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 17, 2024
@ygrishajev
feat(sdl): add storage and gpu validation
f70551b 
refs akash-network/console#133
ygrishajev added a commit to akash-network/akashjs that referenced this issue May 17, 2024
@ygrishajev
feat(sdl): add storage and gpu validation
b125da7 
refs akash-network/console#133
github-actions bot pushed a commit to akash-network/akashjs that referenced this issue May 17, 2024
@semantic-release-bot
chore(release): 0.10.0 [skip ci]
4934a5a 
## [0.10.0](v0.9.2...v0.10.0) (2024-05-17)

### Features

* **sdl:** add storage and gpu validation ([b125da7](b125da7)), closes [akash-network/console#133](akash-network/console#133)
ygrishajev added a commit that referenced this issue May 17, 2024
@ygrishajev
feat(sdl): move storage and gpu validation to akashjs
e86e437 
refs #133
ygrishajev added a commit that referenced this issue May 17, 2024
@ygrishajev
feat(sdl): move storage and gpu validation to akashjs
3a90ecd 
refs #133
@ygrishajev ygrishajev moved this from In Progress (prioritized) to In Test (or staging) in Core Product and Engineering Roadmap May 17, 2024
ygrishajev added a commit that referenced this issue May 17, 2024
@ygrishajev
feat(sdl): move storage and gpu validation to akashjs
e5bd128 
refs #133
@ygrishajev ygrishajev moved this from In Test (or staging) to Released (in Prod) in Core Product and Engineering Roadmap May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ygrishajev ygrishajev

Labels
enhancement New feature or request P2 priority 2 feature/ enhancement
Projects
Core Product and Engineering Roadmap
Status: Released (in Prod)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ygrishajev @baktun14