change signature of orphanedThreadFilter #45469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
This was referenced Sep 13, 2024
This was referenced Sep 13, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
2 tasks
stephane-airbyte
force-pushed
the
stephane/09-10-destination-snowflake_bump_cdk
branch
from
0e70ed1 to
6330d30
Compare
stephane-airbyte
force-pushed
the
stephane/09-13-change_signature_of_orphanedthreadfilter
branch
from
06e8d2c to
2e5fdf1
Compare
stephane-airbyte
force-pushed
the
stephane/09-10-destination-snowflake_bump_cdk
branch
from
6330d30 to
3e0f516
Compare
stephane-airbyte
force-pushed
the
stephane/09-13-change_signature_of_orphanedthreadfilter
branch
from
2e5fdf1 to
dd77b79
Compare
stephane-airbyte
force-pushed
the
stephane/09-10-destination-snowflake_bump_cdk
branch
from
3e0f516 to
1ded4bf
Compare
stephane-airbyte
force-pushed
the
stephane/09-13-change_signature_of_orphanedthreadfilter
branch
2 times, most recently
from
9ea7da7 to
b9fbff4
Compare
stephane-airbyte
force-pushed
the
stephane/09-13-change_signature_of_orphanedthreadfilter
branch
2 times, most recently
from
7af5625 to
b5ed686
Compare
stephane-airbyte
force-pushed
the
stephane/09-10-destination-snowflake_bump_cdk
branch
from
9d78f10 to
daab75f
Compare
stephane-airbyte
force-pushed
the
stephane/09-13-change_signature_of_orphanedthreadfilter
branch
from
b5ed686 to
72151ff
Compare
stephane-airbyte
force-pushed
the
stephane/09-10-destination-snowflake_bump_cdk
branch
from
daab75f to
708b5b8
Compare
stephane-airbyte
force-pushed
the
stephane/09-13-change_signature_of_orphanedthreadfilter
branch
from
72151ff to
162f055
Compare
stephane-airbyte
force-pushed
the
stephane/09-10-destination-snowflake_bump_cdk
branch
from
708b5b8 to
fee0563
Compare
stephane-airbyte
force-pushed
the
stephane/09-13-change_signature_of_orphanedthreadfilter
branch
2 times, most recently
from
48fb5f0 to
59b16fb
Compare
stephane-airbyte
changed the base branch from
stephane/09-10-destination-snowflake_bump_cdk
to
master
stephane-airbyte
force-pushed
the
stephane/09-13-change_signature_of_orphanedthreadfilter
branch
3 times, most recently
from
fffb246 to
90e3ffd
Compare
stephane-airbyte
force-pushed
the
stephane/09-13-change_signature_of_orphanedthreadfilter
branch
2 times, most recently
from
f49e6a6 to
90c1a66
Compare
stephane-airbyte
requested review from
edgao and
johnny-schmidt
and removed request for
a team
edgao
approved these changes
Sep 16, 2024
| @@ -493,6 +517,7 @@ internal constructor( | |||
| } | |||
|
|
|||
| private fun dumpThread(thread: Thread): String { | |||
| OrphanedThreadInfo.getForThread(thread) | |||
There was a problem hiding this comment.
this doesn't seem to do anything?
| // stdout while we run this test, in which case we'd see their messages. | ||
| // we filter through the messages to find an error (hopefully hours) | ||
| for (line in outCt.split('\n')) { | ||
| if (line.contains("\"error\"")) { |
There was a problem hiding this comment.
😢
it looks like we're expecting a json blob - can we filter for something like "type":"trace"? or maybe filter for lines that are valid json
(otherwise wouldn't this trigger for any logger.warn("error while blah blah") message?)
stephane-airbyte
force-pushed
the
stephane/09-13-change_signature_of_orphanedthreadfilter
branch
from
90c1a66 to
c35540c
Compare
johnny-schmidt
approved these changes
Sep 17, 2024
stephane-airbyte
deleted the
stephane/09-13-change_signature_of_orphanedthreadfilter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrphanedThreadInfodata class to encapsulate thread information to avoid data races when getting thread-specific information (like stacktrace, or threadLocal values)OrphanedThreadInfoLoggingInvocationInterceptorAirbyteTraceMessageUtilityTestTestContextto use a default value forCURRENT_TEST_NAME