Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

destination-snowflake: fix destination state table collation #38585

Merged
merged 1 commit into from
Sep 18, 2024
Merged

destination-snowflake: fix destination state table collation #38585

merged 1 commit into from
Sep 18, 2024

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented May 22, 2024 •
edited
Loading

when creating a table in snowflake, we use the DEFAULT_COLLATION set at the database or schema level. We should always use the utf-8 collation (which is the snowflake default), so our queries are simpler and faster (and accept more than 50 constants in an IN clause)

@vercel Vercel
Copy link

vercel bot commented May 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 6:39pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit labels May 22, 2024
@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented May 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte stephane-airbyte marked this pull request as ready for review May 22, 2024 22:30
@stephane-airbyte stephane-airbyte requested a review from a team as a code owner May 22, 2024 22:30
@stephane-airbyte stephane-airbyte requested review from edgao and gisripa May 22, 2024 22:30
@stephane-airbyte stephane-airbyte force-pushed the stephane/05-22-fix_destination_state_table_collation_for_snowflake branch 3 times, most recently from 614d2b2 to 6eefaac Compare May 22, 2024 22:58
edgao
edgao approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's... maybe worth adding a test case for this? (i.e. try and commit 50 streams' states)

similar to https://github.com/airbytehq/airbyte/blob/master/airbyte-cdk/java/airbyte-cdk/typing-deduping/src/testFixtures/kotlin/io/airbyte/integrations/base/destination/typing_deduping/BaseSqlGeneratorIntegrationTest.kt#L1721

@evantahler evantahler mentioned this pull request Jun 4, 2024
Closed
1 task
@evantahler
Copy link
Contributor

Bump @stephane-airbyte!

@stephane-airbyte stephane-airbyte changed the title fix destination state table collation for snowflake destination-snowflake: fix destination state table collation Sep 3, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/05-22-fix_destination_state_table_collation_for_snowflake branch 4 times, most recently from 995fdce to 450f659 Compare September 3, 2024 20:41
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Sep 3, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/05-22-fix_destination_state_table_collation_for_snowflake branch from 450f659 to 98467d3 Compare September 12, 2024 16:51
@stephane-airbyte stephane-airbyte changed the base branch from master to stephane/09-10-destination-snowflake_bump_cdk September 12, 2024 16:51
This was referenced Sep 12, 2024
Merged
Merged
@octavia-squidington-iv octavia-squidington-iv requested a review from a team September 12, 2024 16:52
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-10-destination-snowflake_bump_cdk branch from 22ae7e0 to 4e1a3e6 Compare September 12, 2024 17:28
@stephane-airbyte stephane-airbyte force-pushed the stephane/05-22-fix_destination_state_table_collation_for_snowflake branch from 98467d3 to dbe2fb1 Compare September 12, 2024 17:28
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-10-destination-snowflake_bump_cdk branch from 4e1a3e6 to 7cc25ed Compare September 12, 2024 21:38
@stephane-airbyte stephane-airbyte force-pushed the stephane/05-22-fix_destination_state_table_collation_for_snowflake branch from dbe2fb1 to 108ff38 Compare September 12, 2024 21:38
@stephane-airbyte stephane-airbyte force-pushed the stephane/05-22-fix_destination_state_table_collation_for_snowflake branch from a9d0815 to 1d9d5c6 Compare September 18, 2024 18:20
@stephane-airbyte stephane-airbyte merged commit 7c8d612 into master Sep 18, 2024
34 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/05-22-fix_destination_state_table_collation_for_snowflake branch September 18, 2024 18:46
@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

17 similar comments
@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

7 similar comments
@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

@gisripa gisripa Awaiting requested review from gisripa

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephane-airbyte @evantahler @edgao @octavia-squidington-iii