destination-s3: fix issue with columnless streams #45402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
force-pushed
the
stephane/09-11-destination-s3_fix_issue_with_columnless_streams
branch
2 times, most recently
from
18c54a7 to
8830187
Compare
johnny-schmidt
approved these changes
Sep 11, 2024
stephane-airbyte
force-pushed
the
stephane/09-11-destination-s3_fix_issue_with_columnless_streams
branch
from
8830187 to
a9e57a6
Compare
stephane-airbyte
changed the base branch from
master
to
stephane/09-12-destination-s3_update_all_dependencies
stephane-airbyte
force-pushed
the
stephane/09-12-destination-s3_update_all_dependencies
branch
from
9869516 to
175e9a9
Compare
stephane-airbyte
force-pushed
the
stephane/09-12-destination-s3_update_all_dependencies
branch
from
175e9a9 to
9869516
Compare
stephane-airbyte
force-pushed
the
stephane/09-11-destination-s3_fix_issue_with_columnless_streams
branch
from
a9e57a6 to
9634452
Compare
octavia-squidington-iii
added
the
area/documentation
stephane-airbyte
force-pushed
the
stephane/09-12-destination-s3_update_all_dependencies
branch
from
9869516 to
608f9c3
Compare
stephane-airbyte
force-pushed
the
stephane/09-11-destination-s3_fix_issue_with_columnless_streams
branch
from
9634452 to
146625c
Compare
stephane-airbyte
changed the base branch from
stephane/09-12-destination-s3_update_all_dependencies
to
graphite-base/45402
stephane-airbyte
force-pushed
the
stephane/09-11-destination-s3_fix_issue_with_columnless_streams
branch
from
146625c to
84132dd
Compare
stephane-airbyte
force-pushed
the
graphite-base/45402
branch
from
608f9c3 to
0c9805e
Compare
stephane-airbyte
changed the base branch from
graphite-base/45402
to
master
stephane-airbyte
force-pushed
the
stephane/09-11-destination-s3_fix_issue_with_columnless_streams
branch
from
84132dd to
4e0350e
Compare
stephane-airbyte
force-pushed
the
stephane/09-11-destination-s3_fix_issue_with_columnless_streams
branch
from
4e0350e to
1e92493
Compare
stephane-airbyte
deleted the
stephane/09-11-destination-s3_fix_issue_with_columnless_streams
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for handling empty data fields in Avro records and introduced a new test case for streams with no columns.
We've agreed there's a bug in a source (uscensus) that returns a single columnless stream. There's also a bug in the platform that allows a customer to create a connection using that columnless empty stream.
While it would be ideal for the destination connector to send an (yet non existent)
UpstreamErrorback to the platform, we have some configurations of S3 (CSV, Json) that just allow teh columnless records to be persisted. We're just bringing the parquet/avro to the same permissiveness