feat(platform): Simplify Credentials UX #8524

kcze · 2024-11-01T16:30:09Z

Resolves Simplify Credentials UX #8516

Current credentials system always forces users to choose correct credentials, even when they are provided by the cloud platform and should be chosen automatically (e.g. there's only one possible choice).

Changes 🏗️

Change provider of default credentials to actual provider names (e.g. anthropic), remove llm provider
Add discriminator and discriminator_mapping to CredentialsField that allows to filter credentials input to only allow providers for matching models in useCredentials hook (thanks @ntindle for the idea!); e.g. user chooses GPT4_TURBO so then only OpenAI credentials are allowed
Choose credentials automatically and hide credentials input on the node completely if there's only one possible option
Move getValue and parseKeys to utils
Add ANTHROPIC, GROQ and OLLAMA to providers in frontend types.ts
Add hidden field to credentials that is used for default system keys to hide them in user profile
Now provider field in CredentialsField can accept multiple providers as a list

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

Create from scratch and execute an agent with at least 3 blocks
Import an agent from file upload, and confirm it executes correctly
Upload agent to marketplace
Import an agent from marketplace and confirm it executes correctly
Edit an agent from monitor, and confirm it executes correctly

…improvements

autogpt_platform/frontend/src/lib/utils.ts

ntindle · 2024-11-04T22:15:25Z

This is exactly what I was thinking! great job!

autogpt_platform/frontend/src/lib/autogpt-server-api/types.ts

…improvements

ntindle · 2024-11-05T03:05:03Z

I think the devx and ux of this leaves something to be desired still. I think the dev specifying the valid providers as a list would be useful and then it returns one of the credentials depending on the selected API key added.

Screen.Recording.2024-11-04.at.9.04.20.PM.mov

Also not sure how they are added to the db and filtered but I'm not seeing them after creation, and crashing anytime they're rendered. I think there's an issue somewhere. lmk if you can't replicate

ntindle

Tested, needs addtional work

…improvements

kcze · 2024-11-05T14:21:40Z

I think the dev specifying the valid providers as a list would be useful and then it returns one of the credentials depending on the selected API key added.

Constraining providers already happens in the backend by specifying discriminator_mapping. You cannot add non-matching provider and even if you manage they won't be displayed in the dropdown.

edit: it's changed so all possible providers need to be set

Regarding bugs and video: everything should now work, including system keys being hidden in the profile.

…improvements

ntindle

This still isn't wokring for me

There's nowhere to select credentials, and we're still creating llm providers which we shouldn't need

autogpt_platform/backend/backend/blocks/llm.py

autogpt_platform/frontend/src/app/profile/page.tsx

autogpt_platform/frontend/src/components/integrations/credentials-input.tsx

ntindle · 2024-11-05T18:13:05Z

autogpt_platform/frontend/src/components/integrations/credentials-input.tsx

+    // Only one saved credential
+  } else if (
+    savedApiKeys.length === 0 &&
+    savedOAuthCredentials.length === 1 &&
+    selectedCredentials === undefined
+  ) {
+    if (selectedCredentials === undefined) {
+      onSelectCredentials({
+        id: savedOAuthCredentials[0].id,
+        type: "oauth2",
+        provider,
+        title: savedOAuthCredentials[0].title,
+      });
+    }
+    return null;
+  } else if (savedApiKeys.length === 1 && savedOAuthCredentials.length === 0) {
+    if (selectedCredentials === undefined) {
+      onSelectCredentials({
+        id: savedApiKeys[0].id,
+        type: "api_key",
+        provider,
+        title: savedApiKeys[0].title,
+      });
+    }
+    return null;


What's the purpose of this? This whole chain of logic seems questionably necessary.

Reading through this PR, I don't really see why this shortcut is being taken. What's the big hurdle preventing the regular credentials input from working on a multi-provider block?

I'm not sure I understand @Pwuts. The purpose of this code is to choose the only one existing credentials and then not show dropdown at all. I simplified this code.

My question is: would it break anything to allow users the choice of adding their own API key? I understand this will be resolved in a follow-up PR, but I don't immediately see what would break right now if you still showed the credentials picker in all cases.

ntindle · 2024-11-05T18:15:24Z

app-index.tsx:25 
 Warning: Cannot update a component (`BatchProvider`) while rendering a different component (`CredentialsInput`). To locate the bad setState() call inside `CredentialsInput`, follow the stack trace as described in https://reactjs.org/link/setstate-in-render Error Component Stack
    at CredentialsInput (credentials-input.tsx:87:9)
    at div (<anonymous>)
    at NodeCredentialsInput (node-input-components.tsx:309:9)
    at NodeGenericInputField (

maybe this error helps

autogpt_platform/frontend/src/components/integrations/credentials-input.tsx

autogpt_platform/autogpt_libs/autogpt_libs/supabase_integration_credentials_store/types.py

…improvements

netlify · 2024-11-11T07:17:15Z

✅ Deploy Preview for auto-gpt-docs canceled.

Name	Link
🔨 Latest commit	`9f0e386`
🔍 Latest deploy log	https://app.netlify.com/sites/auto-gpt-docs/deploys/67337246ebbef30008fb3529

github-actions · 2024-11-12T06:05:32Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Pwuts · 2024-11-12T12:43:17Z

autogpt_platform/backend/backend/data/model.py

Just a note: this really has to be considered a tempfix. Scopes are provider-specific. So is supported_credential_types. The CredentialsField was made to handle credentials from a specific provider. If a block supports multiple providers, the discrimination logic should be handled outside the CredentialsField.

See also #8524 (comment)

(I'd like to leave this discussion here for reference in the follow-up PR)

Okay, I'm happy for us to merge this as a much needed temp hotfix and we can adjust that in a follow up.

autogpt_platform/frontend/src/app/profile/page.tsx

…improvements

github-actions · 2024-11-12T13:22:56Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

…improvements

- Patch for breakage from #8524 - Resolves #8635

…rovider "llm"(#8674) In #8524, the "llm" credentials provider was replaced. There are still entries with "provider": "llm" in the system though, and those break if not migrated. - SQL migration to fix the obvious ones where we know the provider from `credentials.id` - Non-SQL migration to fix the rest

…rovider "llm" (#8674) In #8524, the "llm" credentials provider was replaced. There are still entries with `"provider": "llm"` in the system though, and those break if not migrated. - SQL migration to fix the obvious ones where we know the provider from `credentials.id` - Non-SQL migration to fix the rest

Update Credentials UX

0842f20

kcze requested review from ntindle, Pwuts, aarushik93 and majdyz November 1, 2024 16:30

kcze requested a review from a team as a code owner November 1, 2024 16:30

github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end platform/blocks size/l labels Nov 1, 2024

kcze and others added 3 commits November 2, 2024 01:39

Format backend

30fbba3

Fix discriminatorValue

800b8e3

Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…

8fb652d

…improvements

ntindle reviewed Nov 4, 2024

View reviewed changes

autogpt_platform/frontend/src/lib/utils.ts Show resolved Hide resolved

ntindle reviewed Nov 4, 2024

View reviewed changes

autogpt_platform/frontend/src/lib/autogpt-server-api/types.ts Show resolved Hide resolved

Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…

33ba822

…improvements

ntindle requested changes Nov 5, 2024

View reviewed changes

kcze added 4 commits November 5, 2024 21:44

Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…

3f54524

…improvements

Hide system credentials in Profile

4d09e53

Deselect non existing credentials

f64a0b4

Lint

f9a3993

kcze requested a review from ntindle November 5, 2024 14:21

Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…

e143754

…improvements

ntindle requested changes Nov 5, 2024

View reviewed changes

Fixes

7f4eedd

kcze requested a review from ntindle November 7, 2024 14:30

Pwuts reviewed Nov 8, 2024

View reviewed changes

autogpt_platform/frontend/src/components/integrations/credentials-input.tsx Outdated Show resolved Hide resolved

Pwuts reviewed Nov 8, 2024

View reviewed changes

autogpt_platform/autogpt_libs/autogpt_libs/supabase_integration_credentials_store/types.py Outdated Show resolved Hide resolved

ntindle and others added 2 commits November 8, 2024 12:17

Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…

1cb3cec

…improvements

Updates

c2a9ef7

kcze dismissed ntindle’s stale review via c2a9ef7 November 11, 2024 07:15

Fix credentials input

32bc04b

kcze requested review from Pwuts and ntindle November 11, 2024 10:29

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 12, 2024

Pwuts reviewed Nov 12, 2024

View reviewed changes

autogpt_platform/frontend/src/app/profile/page.tsx Show resolved Hide resolved

Torantulino enabled auto-merge (squash) November 12, 2024 12:52

Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…

58d01e1

…improvements

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 12, 2024

Pwuts approved these changes Nov 12, 2024

View reviewed changes

Merge branch 'dev' into kpczerwinski/open-1999-credentials-system-ux-…

9f0e386

…improvements

Pwuts disabled auto-merge November 12, 2024 15:23

Pwuts merged commit e907ffd into dev Nov 12, 2024
17 checks passed

Pwuts deleted the kpczerwinski/open-1999-credentials-system-ux-improvements branch November 12, 2024 15:55

Pwuts mentioned this pull request Nov 13, 2024

Fix broken credentials input on single-provider blocks #8635

Closed

Pwuts added a commit that referenced this pull request Nov 13, 2024

fix(frontend): Unbreak undiscriminated credentials input

d2579a6

- Patch for breakage from #8524 - Resolves #8635

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(platform): Simplify Credentials UX #8524

feat(platform): Simplify Credentials UX #8524

kcze commented Nov 1, 2024 •

edited by Pwuts

Loading

ntindle commented Nov 4, 2024

ntindle commented Nov 5, 2024

ntindle left a comment

kcze commented Nov 5, 2024 •

edited

Loading

ntindle left a comment

ntindle Nov 5, 2024

Pwuts Nov 8, 2024

kcze Nov 10, 2024

Pwuts Nov 12, 2024 •

edited

Loading

ntindle commented Nov 5, 2024

netlify bot commented Nov 11, 2024 •

edited

Loading

github-actions bot commented Nov 12, 2024

Pwuts Nov 12, 2024

Pwuts Nov 12, 2024

Pwuts Nov 12, 2024

Torantulino Nov 12, 2024

github-actions bot commented Nov 12, 2024

feat(platform): Simplify Credentials UX #8524

feat(platform): Simplify Credentials UX #8524

Conversation

kcze commented Nov 1, 2024 • edited by Pwuts Loading

Changes 🏗️

Testing 🔍

ntindle commented Nov 4, 2024

ntindle commented Nov 5, 2024

ntindle left a comment

Choose a reason for hiding this comment

kcze commented Nov 5, 2024 • edited Loading

ntindle left a comment

Choose a reason for hiding this comment

ntindle Nov 5, 2024

Choose a reason for hiding this comment

Pwuts Nov 8, 2024

Choose a reason for hiding this comment

kcze Nov 10, 2024

Choose a reason for hiding this comment

Pwuts Nov 12, 2024 • edited Loading

Choose a reason for hiding this comment

ntindle commented Nov 5, 2024

netlify bot commented Nov 11, 2024 • edited Loading

✅ Deploy Preview for auto-gpt-docs canceled.

github-actions bot commented Nov 12, 2024

Pwuts Nov 12, 2024

Choose a reason for hiding this comment

Pwuts Nov 12, 2024

Choose a reason for hiding this comment

Pwuts Nov 12, 2024

Choose a reason for hiding this comment

Torantulino Nov 12, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 12, 2024

kcze commented Nov 1, 2024 •

edited by Pwuts

Loading

kcze commented Nov 5, 2024 •

edited

Loading

Pwuts Nov 12, 2024 •

edited

Loading

netlify bot commented Nov 11, 2024 •

edited

Loading