Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): Add migrations to fix credentials inputs #8674

Merged
merged 4 commits into from
Nov 15, 2024
Merged

fix(backend): Add migrations to fix credentials inputs #8674

merged 4 commits into from
Nov 15, 2024
+97 −0

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Nov 15, 2024 •
edited
Loading

In #8524, the "llm" credentials provider was replaced. There are still entries with "provider": "llm" in the system though, and those break if not migrated.

Warning

This patch needed further iteration after merging. The final, working patch can be found in commit 9185381.

Changes 🏗️

  • SQL migration to fix the obvious ones where we know the provider from credentials.id
  • Non-SQL migration to fix the rest

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@Pwuts
fix(backend): Add migrations to fix credentials inputs
3b728dc 
- SQL migration to fix the obvious ones where we know the provider from `credentials.id`
- Non-SQL migration to fix the rest
@Pwuts Pwuts requested a review from a team as a code owner November 15, 2024 17:36
@Pwuts Pwuts requested review from Swiftyos and Torantulino and removed request for a team November 15, 2024 17:36
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/m labels Nov 15, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 58e1d91
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67378a1b75ef9700080dbddf

@Pwuts Pwuts marked this pull request as draft November 15, 2024 17:39
@Pwuts Pwuts marked this pull request as ready for review November 15, 2024 17:51
@Pwuts Pwuts merged commit 4db8e74 into dev Nov 15, 2024
15 checks passed
@Pwuts Pwuts deleted the reinier/fix-llm-credential-inputs branch November 15, 2024 19:18
Pwuts added a commit that referenced this pull request Nov 18, 2024
@Pwuts
fix(backend): Add migrations to fix credentials inputs with invalid p…
9185381 
…rovider "llm" (#8674)

In #8524, the "llm" credentials provider was replaced. There are still entries with `"provider": "llm"` in the system though, and those break if not migrated.

- SQL migration to fix the obvious ones where we know the provider from `credentials.id`
- Non-SQL migration to fix the rest
@Pwuts
Copy link
Member Author

Pwuts commented Nov 18, 2024

This needed further iteration before it worked. The final, working patch can be found in commit 9185381.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarushik93 aarushik93 aarushik93 approved these changes

@Swiftyos Swiftyos Awaiting requested review from Swiftyos Swiftyos is a code owner automatically assigned from Significant-Gravitas/maintainers

@Torantulino Torantulino Awaiting requested review from Torantulino Torantulino is a code owner automatically assigned from Significant-Gravitas/maintainers

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pwuts @aarushik93