Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Unbreak credentials input on single-provider blocks #8636

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Nov 13, 2024

Changes 🏗️

  • fix(frontend): Fix type mismatch of CredentialsField schema between frontend and backend

    • Fix usages of credentialsSchema.credentials_provider
  • refactor(backend): Create CredentialsFieldSchemaExtra model in backend so it can be mirrored directly in frontend

    • Add check to enforce multi-provider CredentialsField always has discriminator
  • dx: Add type checking shortcut yarn type-check / npm run type-check for frontend

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Save and run a graph with a single-provider block
    • Save and run a graph with a multi-provider block
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@Pwuts Pwuts requested a review from a team as a code owner November 13, 2024 13:16
@Pwuts Pwuts requested review from Swiftyos and majdyz and removed request for a team November 13, 2024 13:16
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/m labels Nov 13, 2024
aarushik93
aarushik93 previously approved these changes Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit d2579a6
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6734a6a550bd9b00081fe093
😎 Deploy Preview https://deploy-preview-8636--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pwuts Pwuts changed the title fix(frontend): Unbreak undiscriminated credentials input fix(frontend): Unbreak credentials input on single-provider blocks Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 249a6db
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6734ab80935f380008a9c1bd

@aarushik93 aarushik93 enabled auto-merge (squash) November 13, 2024 13:38
@Pwuts Pwuts disabled auto-merge November 13, 2024 13:39
@Pwuts Pwuts enabled auto-merge (squash) November 13, 2024 13:39
@Pwuts Pwuts merged commit aaa0b79 into dev Nov 13, 2024
17 checks passed
@Pwuts Pwuts deleted the reinier/open-2034-fix-broken-credentials-input-on-single-provider-blocks branch November 13, 2024 13:48
Pwuts added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants