-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): Unbreak credentials input on single-provider blocks #8636
Merged
Pwuts
merged 5 commits into
dev
from
reinier/open-2034-fix-broken-credentials-input-on-single-provider-blocks
Nov 13, 2024
Merged
fix(frontend): Unbreak credentials input on single-provider blocks #8636
Pwuts
merged 5 commits into
dev
from
reinier/open-2034-fix-broken-credentials-input-on-single-provider-blocks
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pwuts
requested review from
Swiftyos and
majdyz
and removed request for
a team
November 13, 2024 13:16
github-actions
bot
added
platform/frontend
AutoGPT Platform - Front end
platform/backend
AutoGPT Platform - Back end
size/m
labels
Nov 13, 2024
aarushik93
previously approved these changes
Nov 13, 2024
✅ Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pwuts
changed the title
fix(frontend): Unbreak undiscriminated credentials input
fix(frontend): Unbreak credentials input on single-provider blocks
Nov 13, 2024
✅ Deploy Preview for auto-gpt-docs canceled.
|
aarushik93
approved these changes
Nov 13, 2024
Pwuts
deleted the
reinier/open-2034-fix-broken-credentials-input-on-single-provider-blocks
branch
November 13, 2024 13:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes 🏗️
fix(frontend): Fix type mismatch of
CredentialsField
schema between frontend and backendcredentialsSchema.credentials_provider
refactor(backend): Create
CredentialsFieldSchemaExtra
model in backend so it can be mirrored directly in frontendCredentialsField
always hasdiscriminator
dx: Add type checking shortcut
yarn type-check
/npm run type-check
for frontendChecklist 📋
For code changes:
Example test plan