Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filepath fixes and docs updates to specify when relative paths are expected #5042

Merged
merged 7 commits into from
Jul 24, 2023

Conversation

lc0rp
Copy link
Contributor

@lc0rp lc0rp commented Jul 23, 2023

Background

  1. Move all application code to an application subpackage #5026 moved cli.py down one level into the app directory causing the workdir fix from Fix path processing #5032 to break.
  2. In cli.py, the AIConfig.load() method is called workdir / ai_settings_file but AIConfig.save() was called with 'ai_settings_file' which causes ai_settings.yaml to be skipped on start, and then overwritten by the AI generated goals.

Changes

This PR fixes those two issues and updates the documentation in docs/configuration/options.md and env.template.yaml to specify when relative paths are expected.

The changes affecting the following config and settings files, which are now loaded using workdir / <file>

  • ai_settings_file
  • azure_settingS_FILE
  • plugins_config_file
  • prompt_settings_file

Documentation

This PR updates the docs as well

Test Plan

Run automated test suite.

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not noticed any "extra" small tweaks changes.
  • [S] I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@lc0rp lc0rp requested a review from Pwuts July 23, 2023 07:51
@lc0rp lc0rp added this to the v0.4.6 Release milestone Jul 23, 2023
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.01 🎉

Comparison is base (e0bcde1) 51.00% compared to head (a4556ac) 51.02%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-v0.4.6    #5042      +/-   ##
==================================================
+ Coverage           51.00%   51.02%   +0.01%     
==================================================
  Files                 119      119              
  Lines                4968     4970       +2     
  Branches              662      662              
==================================================
+ Hits                 2534     2536       +2     
  Misses               2239     2239              
  Partials              195      195              
Impacted Files Coverage Δ
autogpt/app/cli.py 0.00% <ø> (ø)
autogpt/app/configurator.py 37.64% <0.00%> (ø)
autogpt/app/main.py 39.74% <0.00%> (ø)
autogpt/config/config.py 80.58% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pwuts Pwuts changed the title (Release v0.4.6) - Filepath fixes and docs updates to specify when relative paths are expected Filepath fixes and docs updates to specify when relative paths are expected Jul 24, 2023
@Pwuts Pwuts merged commit 71e7424 into Significant-Gravitas:release-v0.4.6 Jul 24, 2023
@lc0rp lc0rp deleted the filepath_fixes branch August 1, 2023 06:01
@lc0rp lc0rp restored the filepath_fixes branch August 1, 2023 06:01
@lc0rp lc0rp deleted the filepath_fixes branch August 1, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants