-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filepath fixes and docs updates to specify when relative paths are expected #5042
Merged
Pwuts
merged 7 commits into
Significant-Gravitas:release-v0.4.6
from
lc0rp:filepath_fixes
Jul 24, 2023
Merged
Filepath fixes and docs updates to specify when relative paths are expected #5042
Pwuts
merged 7 commits into
Significant-Gravitas:release-v0.4.6
from
lc0rp:filepath_fixes
Jul 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-GPT into local/upstream/master
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-v0.4.6 #5042 +/- ##
==================================================
+ Coverage 51.00% 51.02% +0.01%
==================================================
Files 119 119
Lines 4968 4970 +2
Branches 662 662
==================================================
+ Hits 2534 2536 +2
Misses 2239 2239
Partials 195 195
☔ View full report in Codecov by Sentry. |
5 tasks
Pwuts
changed the title
(Release v0.4.6) - Filepath fixes and docs updates to specify when relative paths are expected
Filepath fixes and docs updates to specify when relative paths are expected
Jul 24, 2023
Pwuts
approved these changes
Jul 24, 2023
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
workdir / ai_settings_file
but AIConfig.save() was called with 'ai_settings_file' which causes ai_settings.yaml to be skipped on start, and then overwritten by the AI generated goals.Changes
This PR fixes those two issues and updates the documentation in docs/configuration/options.md and env.template.yaml to specify when relative paths are expected.
The changes affecting the following config and settings files, which are now loaded using
workdir / <file>
Documentation
This PR updates the docs as well
Test Plan
Run automated test suite.
PR Quality Checklist