Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path processing #5032

Merged
merged 8 commits into from
Jul 21, 2023
Merged

Fix path processing #5032

merged 8 commits into from
Jul 21, 2023

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jul 21, 2023

Background

We continue to have issues where a piece of code containing a relative path reference is moved and suddenly the logs folder or the workspace folder isn't in the right place anymore.

Changes

Documentation

  • amend docs to reflect these changes

Test Plan

Auto-GPT runs fine, tests pass

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit ef8e6bd
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/64bace912afe3c0008a07832

@Pwuts Pwuts marked this pull request as draft July 21, 2023 15:56
@Pwuts Pwuts mentioned this pull request Jul 21, 2023
@Pwuts Pwuts marked this pull request as ready for review July 21, 2023 16:25
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 62.37% and project coverage change: +0.13 🎉

Comparison is base (08a1e22) 50.93% compared to head (0d0245a) 51.07%.

❗ Current head 0d0245a differs from pull request most recent head ef8e6bd. Consider uploading reports for the commit ef8e6bd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5032      +/-   ##
==========================================
+ Coverage   50.93%   51.07%   +0.13%     
==========================================
  Files         119      119              
  Lines        4900     4973      +73     
  Branches      650      664      +14     
==========================================
+ Hits         2496     2540      +44     
- Misses       2219     2236      +17     
- Partials      185      197      +12     
Impacted Files Coverage Δ
autogpt/cli.py 0.00% <0.00%> (ø)
autogpt/commands/execute_code.py 71.96% <ø> (ø)
autogpt/llm/__init__.py 100.00% <ø> (ø)
autogpt/llm/providers/openai.py 89.07% <ø> (ø)
autogpt/memory/vector/utils.py 75.60% <ø> (+3.51%) ⬆️
autogpt/plugins/__init__.py 72.95% <ø> (-0.17%) ⬇️
autogpt/prompts/prompt.py 41.50% <0.00%> (ø)
autogpt/agents/agent.py 50.00% <47.12%> (-4.12%) ⬇️
autogpt/main.py 39.88% <50.00%> (+16.19%) ⬆️
autogpt/agents/base.py 69.23% <69.23%> (ø)
... and 15 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pwuts Pwuts added this to the v0.4.6 Release milestone Jul 21, 2023
@collijk collijk merged commit 2c53530 into master Jul 21, 2023
@collijk collijk deleted the fix/path-handling branch July 21, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants