-
Notifications
You must be signed in to change notification settings - Fork 44.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure logs.py into a module; include log_cycle #4921
Restructure logs.py into a module; include log_cycle #4921
Conversation
✅ Deploy Preview for auto-gpt-docs canceled.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4921 +/- ##
==========================================
- Coverage 50.55% 50.53% -0.02%
==========================================
Files 116 118 +2
Lines 4860 4820 -40
Branches 657 642 -15
==========================================
- Hits 2457 2436 -21
+ Misses 2219 2204 -15
+ Partials 184 180 -4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some optional suggestions here. I'm presuming the only changes here is code motion + typing (nice job on that!). If you've added any logic changes, please flag them with a comment and re-request a review. Otherwise looks good!
9c55600
to
269140e
Compare
You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged. |
…vitas#4921) * Consolidate all logging stuff into one module * Merge import statement for `logs` and `logs.log_cycle` --------- Co-authored-by: James Collins <[email protected]>
…vitas#4921) * Consolidate all logging stuff into one module * Merge import statement for `logs` and `logs.log_cycle` --------- Co-authored-by: James Collins <[email protected]>
Part of #4799
Title speaks for itself :)
PR Quality Checklist