Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ChromeHeadless #319

Merged
merged 14 commits into from
Apr 21, 2018
Merged

Switch to ChromeHeadless #319

merged 14 commits into from
Apr 21, 2018

Conversation

cgravill
Copy link
Contributor

No description provided.

@forki
Copy link
Member

forki commented Mar 22, 2018

https://twitter.com/sforkmann/status/976758077751005184

will be hard right now

@cgravill
Copy link
Contributor Author

Ah, thanks for the warning :-)

Potentially completely remove later
The build installed by chrome: stable or chrome: beta seems to be way too old.

https://500tech.com/blog/all/running-travis-ci-unit-tests-using-google-chrome/
The display may not be needed with recent versions of Chrome running in headless mode.
@forki
Copy link
Member

forki commented Apr 18, 2018

can you please also upgrade it to use canopy 2?

@cgravill
Copy link
Contributor Author

cgravill commented Apr 18, 2018

Sure, I've switched Canopy 2 on internal projects already so should be able to upgrade this too later.

@cgravill cgravill changed the title Work-in-progress Switch to ChromeHeadless Switch to ChromeHeadless Apr 21, 2018
@cgravill
Copy link
Contributor Author

OK, I've moved it over to Canopy 2 and everything seems to works. @lefthandedgoat the browser automation is running much faster than previously which is great. It also simplified the runner setup nicely.

I took some changes from lefthandedgoat/canopy#428 it make this work, once that's merged we can switch back to canopy.classic.waitForElement as well

@forki forki merged commit 91b0652 into SAFE-Stack:master Apr 21, 2018
@forki
Copy link
Member

forki commented Apr 21, 2018

Awesome! thanks

@lefthandedgoat
Copy link

@cgravill I accepted that PR and did a build: https://www.nuget.org/packages/canopy/2.0.1

@cgravill
Copy link
Contributor Author

@lefthandedgoat thanks! I've updated and added #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants