-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to ChromeHeadless #319
Conversation
#317 Start in ChromeHeadless rather than PhantonJS Use NuGet rather than binaries (no need for manual copies)
https://www.appveyor.com/docs/build-environment/ is currently Chrome 63.0
https://www.appveyor.com/docs/build-environment/ is currently Chrome 63.0
https://twitter.com/sforkmann/status/976758077751005184 will be hard right now |
Ah, thanks for the warning :-) |
Potentially completely remove later
The build installed by chrome: stable or chrome: beta seems to be way too old. https://500tech.com/blog/all/running-travis-ci-unit-tests-using-google-chrome/
The display may not be needed with recent versions of Chrome running in headless mode.
can you please also upgrade it to use canopy 2? |
Sure, I've switched Canopy 2 on internal projects already so should be able to upgrade this too later. |
Canopy now sets the working directory to be local so no need to do that. Dropped Geckodriver, can switch to NuGet in future.
OK, I've moved it over to Canopy 2 and everything seems to works. @lefthandedgoat the browser automation is running much faster than previously which is great. It also simplified the runner setup nicely. I took some changes from lefthandedgoat/canopy#428 it make this work, once that's merged we can switch back to |
Awesome! thanks |
@cgravill I accepted that PR and did a build: https://www.nuget.org/packages/canopy/2.0.1 |
@lefthandedgoat thanks! I've updated and added #327 |
No description provided.