-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade canopy tests to use chrome headless #317
Comments
ChromeHeadless should work, if it does not let me know and I will try getting the source of this repo and figuring it out. https://github.com/lefthandedgoat/canopy/blob/master/src/canopy/canopy.fs#L871 |
yeah the question is: how would our buld change? I'd really appreciate a PR which shows best pratice ;-) |
I have headless Chrome working with Canopy and Expecto on another project. I could draft a PR if that would help? Rather than check in the drivers I used https://www.nuget.org/packages/Selenium.WebDriver.ChromeDriver/ (and the Gecko and Edge variants) which works well for us. That should avoid the need for the RenameDrivers target as well. |
yes that is exactly what I hoped. getting drivers from nuget or npm. |
Looks possible to switch:
(Windows output, worked on MacOS as well) The main issue I see is that it expects Chrome to be present. That's true by default on AppVeyor and can be configured on TravisCI (https://docs.travis-ci.com/user/chrome) but a given user may not have it. Think that's an issue? |
PR here: #318 Hope this helps, please let me know if it you have any problems and I will do what I can to help. |
AFAIk the phantom is no longer in active development. We should move over to chrome headless.
I'd lvoe to get help for that.
/cc @lefthandedgoat
The text was updated successfully, but these errors were encountered: