canopy.classic.waitForElement function fix #428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canopy.classic.waitForElement
is a proxy forcanopy.parallell.functions.waitForElement
but wasn't passing cssSelector parameter so signature wasinstead of
so I applied unused parameter since it was obvious fix.
More over in the old version of canopy we used to have this function signature
and now we have
so I passed
browser
as well to align it with old API and existingskip
function from the same modulecanopy.classic
.My VSCode removed some empty spaces from line ends so PR looks pretty noisy instead of containing L330 only. I noticed too late :)