Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canopy.classic.waitForElement function fix #428

Merged
merged 2 commits into from
Apr 21, 2018

Conversation

draganjovanovic1
Copy link
Contributor

canopy.classic.waitForElement is a proxy for canopy.parallell.functions.waitForElement but wasn't passing cssSelector parameter so signature was

val waitForElement: cssSelector: 'a -> string -> OpenQA.Selenium.IWebDriver -> unit

instead of

val waitForElement: cssSelector: string -> OpenQA.Selenium.IWebDriver -> unit

so I applied unused parameter since it was obvious fix.

More over in the old version of canopy we used to have this function signature

val waitForElement: cssSelector: string -> unit

and now we have

val waitForElement: cssSelector: string -> OpenQA.Selenium.IWebDriver -> unit

so I passed browser as well to align it with old API and existing skip function from the same module canopy.classic.

My VSCode removed some empty spaces from line ends so PR looks pretty noisy instead of containing L330 only. I noticed too late :)

@lefthandedgoat
Copy link
Owner

Good find! Thanks, I will get a new build at as soon as I can.

@lefthandedgoat lefthandedgoat merged commit 7b6c2bc into lefthandedgoat:master Apr 21, 2018
@lefthandedgoat
Copy link
Owner

Sorry it took forever to get a build out. I was trying to fix other bugs first but was unable to.

https://www.nuget.org/packages/canopy/2.0.1

Thanks for the PR!!!!

@draganjovanovic1
Copy link
Contributor Author

No worries. Thanks for the new package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants