fix(Storybook): Firefox Storybook docs obscures components #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m7kvqbe1
added
Type: Bug
jpveooys
reviewed
Nov 17, 2021
jpveooys
reviewed
Nov 17, 2021
jpveooys
reviewed
Nov 17, 2021
packages/react-component-library/cypress/specs/ContextMenu/index.spec.ts
Outdated
Show resolved
Hide resolved
|
Nice spot! That has also been sorted now. |
jpveooys
reviewed
Nov 17, 2021
Added slightly different assertion to account for Firefox behaviour with `DatePicker`. Issue created pending further investigation: Royal-Navy/design-system-docs#417
Storybook obscures components that have hidden elements (think ContextMenu or DatePicker) when viewed with the Firefox browser. This made the docs section almost unusable in Firefox. The only solution at this time appears to be overiding some Storybook styles. storybookjs/storybook#16714 storybookjs/storybook#8928 Included a `ContextMenu` cypress test to help catch the issue with Storybook version bumps.
m7kvqbe1
force-pushed
the
fix/firefox-storybook-docs-obscured-components
branch
from
6918764 to
6699b5a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2810
storybookjs/storybook#16714
storybookjs/storybook#8928
Overview
Overiding some Storybook styles to fix presentation when viewed using the Firefox browser.
Reason
Work carried out
ContextMenutest to catch issueScreenshot
Developer notes
Added slightly different assertion to account for Firefox behaviour with
DatePicker.Issue created pending further investigation: #2809