-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview component hidden content obscured (Firefox) #16714
Comments
Storybook obscures components that have hidden elements (think ContextMenu or DatePicker) when viewed with the Firefox browser. This made the docs section almost unusable in Firefox. The only solution at this time appears to be overiding some Storybook styles. storybookjs/storybook#16714 storybookjs/storybook#8928 Included a `ContextMenu` cypress test to help catch the issue with Storybook version bumps.
Storybook obscures components that have hidden elements (think ContextMenu or DatePicker) when viewed with the Firefox browser. This made the docs section almost unusable in Firefox. The only solution at this time appears to be overiding some Storybook styles. storybookjs/storybook#16714 storybookjs/storybook#8928 Included a `ContextMenu` cypress test to help catch the issue with Storybook version bumps.
@yannbf didn't you mention a workaround for this that's only a configuration change? |
If the user wants to force any height of the container, they could do so by opting out of inline rendering with: parameters: {
docs: { iframeHeight: 500 } // or any amount
} I think this is a tricky situation, because.. in this scenario, what would be the ideal solution? 1 - The story container changes in height once hidden component is shown |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
We’re cleaning house! Storybook has changed a lot since this issue was created and we don’t know if it’s still valid. Please open a new issue referencing this one if:
|
Describe the bug
Storybook Docs Stories in Firefox obscures hidden content (such as a Context Menu or Date Picker component sheet).
Appears to be working as expected in Chrome.
To Reproduce
Check any component story that has a floating sheet:
System
Additional context
#8928
We are currently hacking around this with style overides within
preview-head.html
:The text was updated successfully, but these errors were encountered: