Refactor notification panel to custom hook #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thyhjwb6
force-pushed
the
refactor/notification-panel
branch
2 times, most recently
from
28fb89d to
e52a286
Compare
thyhjwb6
changed the title
m7kvqbe1
approved these changes
Nov 13, 2019
| @@ -0,0 +1,27 @@ | |||
| import React, { useEffect } from 'react' | |||
|
|
|||
| // workaround for undefined error in typescript, node.current might not be defined | |||
There was a problem hiding this comment.
Did you manage to figure out what this was about?
There was a problem hiding this comment.
There is a TypeScript error when there is not an alternative for node.current being set. Whether this is the only option, I don't know.
thyhjwb6
force-pushed
the
refactor/notification-panel
branch
from
e52a286 to
1c7fbd3
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#223
Overview
Refactor of
NotificationPanelReason
Having done the recent notifications work, this was a good opportunity to refactor the
NotificationPanel.Work carried out
Screenshot
There should be no visual difference.
Developer notes
Note that the
fixupcommit was to address issues with Code Climate. This will be squashed once approved.