Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] sale_payment_sheet #2554

Closed
wants to merge 20 commits into from
Closed

[16.0] [MIG] sale_payment_sheet #2554

wants to merge 20 commits into from

Conversation

angelmoya
Copy link
Member

No description provided.

sergio-teruel and others added 19 commits June 6, 2023 09:12
@sergio-teruel @angelmoya
[ADD] sale_payment_sheet: New module
236a70a
@sergio-teruel @angelmoya
[ADD] sale_payment_sheet: Allow add refund invoices to payment sheets
03113ad
@sergio-teruel @angelmoya
[ADD] sale_payment_sheet: Add total amount in tree view
3a8aec0 
TT29429
@sergio-teruel @angelmoya
[IMP] sale_payment_sheet: Allow to group statement lines by reference
143716b 
TT29569
@sergio-teruel @angelmoya
[ADD] sale_payment_sheet: Avoid take an invoice that it already is on…
db27286 
… other payment_sheet and fully payed

TT30929
@cesar-tecnativa @angelmoya
[IMP] sale_payment_sheet: black, isort, prettier
677df20
@cesar-tecnativa @angelmoya
[MIG] sale_payment_sheet: Migration to 15.0
5f08fbf
@cesar-tecnativa @angelmoya
[IMP] sale_payment_sheet: Show invoices in wizard payments and improv…
46f9417 
…e inheritance
@sergio-teruel @angelmoya
[FIX] sale_payment_sheet: Fix to v15
1f5de3b
@angelmoya
[UPD] Update sale_payment_sheet.pot
7c461d4
@OCA-git-bot @angelmoya
[UPD] README.rst
02445c4
@sergio-teruel @angelmoya
[IMP] sale_payment_sheet: Display partner shipping as optional in inv…
3119307 
…oices tree view

TT38893
@OCA-git-bot @angelmoya
sale_payment_sheet 15.0.1.1.0
a70f6ea
@angelmoya
[FIX] Update deprecated unit tests
820b3da
@OCA-git-bot @angelmoya
sale_payment_sheet 15.0.1.1.1
b837452
@victoralmau @angelmoya
[IMP] sale_payment_sheet: Remove redundant default on related field.
9b6358c
@OCA-git-bot @angelmoya
sale_payment_sheet 15.0.1.1.2
3421915
@angelmoya
[IMP] sale_payment_sheet: pre-commit stuff
8a83526
@angelmoya
[MIG] sale_payment_sheet: Migration to 16.0
6fb6989
@angelmoya angelmoya force-pushed the 16.0-mig-sale_payment_sheet branch from bc00b9e to f749eb3 Compare June 6, 2023 14:00
FrancoMaxime
FrancoMaxime suggested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, code LGTM, minors comment

sale_payment_sheet/__manifest__.py Outdated Show resolved Hide resolved
sale_payment_sheet/tests/test_sale_payment_sheet.py Outdated Show resolved Hide resolved
@angelmoya angelmoya force-pushed the 16.0-mig-sale_payment_sheet branch from f749eb3 to 0d2fb7f Compare June 7, 2023 07:38
@angelmoya angelmoya mentioned this pull request Jun 7, 2023
Closed
@angelmoya angelmoya force-pushed the 16.0-mig-sale_payment_sheet branch from 0d2fb7f to 8b79c7a Compare June 7, 2023 11:41
FrancoMaxime
FrancoMaxime approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

pedrobaeza
pedrobaeza reviewed Jun 11, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your last commit with the migration one, indicating that it also improves tests, or put the version change in the migration commit if you want to preserve both commits.

sale_payment_sheet/tests/test_sale_payment_sheet.py
@@ -60,18 +61,30 @@ def _create_invoice(self):
line_form.price_unit = 100.00
return invoice_form.save()

def _create_refund(self):
with Form(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do with here, as you are saving 2 times with it (one exiting the context and the other on the explicit call).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelmoya

@rousseldenis
Copy link
Contributor

/ocabot migration sale_payment_sheet

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 14, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 14, 2023
Open
100 tasks
@carolinafernandez-tecnativa carolinafernandez-tecnativa mentioned this pull request Sep 13, 2023
Merged
@pedrobaeza
Copy link
Member

@carolinafernandez-tecnativa please supersede this PR fixing my last commit to proceed with the merge.

@carolinafernandez-tecnativa carolinafernandez-tecnativa mentioned this pull request Sep 26, 2023
Merged
@pedrobaeza
Copy link
Member

Superseded by #2699

@pedrobaeza pedrobaeza closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@pedrobaeza pedrobaeza pedrobaeza left review comments

@aliciagaarzo aliciagaarzo aliciagaarzo approved these changes

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

Assignees
No one assigned
Labels
approved migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@angelmoya @rousseldenis @pedrobaeza @FrancoMaxime @aliciagaarzo @OCA-git-bot @sergio-teruel @cesar-tecnativa @victoralmau