Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_payment_sheet_financial_risk: Migration to version 16.0 #315

Merged
merged 7 commits into from
Jan 27, 2024
Merged

[16.0][MIG] sale_payment_sheet_financial_risk: Migration to version 16.0 #315

merged 7 commits into from
Jan 27, 2024

Conversation

carolinafernandez-tecnativa
Copy link

Standard migration to v16
Depends on #2554

@Tecnativa

TT44358

@pedrobaeza @carlosdauden

@pedrobaeza
Copy link
Member

/ocabot migration sale_payment_sheet_financial_risk

For adding temporary dependencies, see https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 13, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 13, 2023
Open
12 tasks
@carolinafernandez-tecnativa
Copy link
Author

ping @pedrobaeza

pedrobaeza
pedrobaeza approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash administrative commits

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_payment_sheet_financial_risk branch from 12507e1 to d2e7c5f Compare September 22, 2023 15:20
@carolinafernandez-tecnativa
Copy link
Author

Please squash administrative commits

done

@pedrobaeza
Copy link
Member

I still see some of them, but wait for squashing them until the dependency is merged, and then you remove also the temporary commit.

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_payment_sheet_financial_risk branch from d2e7c5f to ce51c4e Compare October 19, 2023 13:58
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_payment_sheet_financial_risk branch from ce51c4e to 0fc21c5 Compare October 19, 2023 14:03
@carolinafernandez-tecnativa
Copy link
Author

I still see some of them, but wait for squashing them until the dependency is merged, and then you remove also the temporary commit.

Dependency has merged and squashed administrative commits

@carolinafernandez-tecnativa
Copy link
Author

ping @carlosdauden

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-315-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c539ce0 into OCA:16.0 Jan 27, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2249293. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-sale_payment_sheet_financial_risk branch January 27, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosdauden carlosdauden carlosdauden approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@carolinafernandez-tecnativa @pedrobaeza @OCA-git-bot @carlosdauden @rafaelbn