Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_payment_sheet: Migration to version 16.0 #2699

Merged
merged 15 commits into from
Oct 19, 2023

Conversation

carolinafernandez-tecnativa
Copy link
Contributor

@carolinafernandez-tecnativa carolinafernandez-tecnativa commented Sep 26, 2023

-Fixes PR Standard migration to v16
-Improve Tests
-Supersedes #2554 due to changes requested not attended.

@Tecnativa

TT44357

@pedrobaeza

@carolinafernandez-tecnativa
Copy link
Contributor Author

ping @pedrobaeza

@pedrobaeza
Copy link
Member

/ocabot migration sale_payment_sheet

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 3, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 3, 2023
100 tasks
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-sale_payment_sheet branch 4 times, most recently from 4314b93 to 15092d0 Compare October 3, 2023 14:53
@sergio-teruel
Copy link
Contributor

@carolinafernandez-tecnativa Can you review the commits history?
for example this one is missing..
87e9283

Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing commits from older version

@carolinafernandez-tecnativa
Copy link
Contributor Author

@carolinafernandez-tecnativa Can you review the commits history? for example this one is missing.. 87e9283

@sergio-teruel done, can you please check it now? Thanks!

@sergio-teruel
Copy link
Contributor

Can you review please...
image

@carolinafernandez-tecnativa
Copy link
Contributor Author

Can you review please... image

Done!
image

@carolinafernandez-tecnativa
Copy link
Contributor Author

ping @pedrobaeza @sergio-teruel

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2699-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d546e47 into OCA:16.0 Oct 19, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 37ac9ba. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-sale_payment_sheet branch October 19, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants