Bug/fix seq linter #1485
Merged
Bug/fix seq linter #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
requested changes
Sep 30, 2024
cohansen
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
approved these changes
Oct 1, 2024
goetzrrGit
approved these changes
Oct 1, 2024
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 1, 2024
* Revered linter back to the original state * Added Chet's block linting back in * Refactored the sequence-linter again * Fixed some problems with null checking workspace ids * Moved numFormat to its own function, cleaned up workspaceId URL handling
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Revered linter back to the original state * Added Chet's block linting back in * Refactored the sequence-linter again * Fixed some problems with null checking workspace ids * Moved numFormat to its own function, cleaned up workspaceId URL handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a big change to
sequence-linterin #1446 and accidentally removed some of the code added in Chet's PR here: #1465This just adds that back in and fixes another issue I found with null checking on the workspace ids.