Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint range of hex args #1465

Merged
merged 2 commits into from
Sep 18, 2024
Merged

lint range of hex args #1465

merged 2 commits into from
Sep 18, 2024

Conversation

joswig
Copy link
Collaborator

@joswig joswig commented Sep 17, 2024

Fixes #1454

@joswig joswig marked this pull request as ready for review September 17, 2024 23:53
@joswig joswig requested a review from a team as a code owner September 17, 2024 23:53
@joswig
Copy link
Collaborator Author

joswig commented Sep 17, 2024

#1466 is follow up

goetzrrGit
goetzrrGit requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@goetzrrGit goetzrrGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Could you also add a unit test to codemirror-utils.test.ts

src/utilities/sequence-editor/sequence-linter.ts Outdated Show resolved Hide resolved
goetzrrGit
goetzrrGit approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@goetzrrGit goetzrrGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @dandelany

@dandelany
Copy link
Collaborator

Thanks - merging for release 🚢

@dandelany dandelany merged commit 7a3b964 into develop Sep 18, 2024
5 checks passed
@dandelany dandelany deleted the fix/lint_hex_args branch September 18, 2024 23:22
This was referenced Sep 30, 2024
Closed
Merged
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@joswig @dandelany
lint range of hex args (#1465)
ee01f38 
* lint range of hex args

* move sequence editor number parsing utils to codemirror-utils.ts and write unit tests

---------

Co-authored-by: dandelany <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetzrrGit goetzrrGit goetzrrGit approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@AaronPlave AaronPlave Awaiting requested review from AaronPlave AaronPlave is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@duranb duranb Awaiting requested review from duranb duranb is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phoenix UINT range checking breaks on hex values
3 participants
@joswig @dandelany @goetzrrGit