Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoenix UINT range checking breaks on hex values #1454

Closed
cartermak opened this issue Sep 8, 2024 · 0 comments · Fixed by #1465
Closed

Phoenix UINT range checking breaks on hex values #1454

cartermak opened this issue Sep 8, 2024 · 0 comments · Fixed by #1465
Assignees
Labels
bug Something isn't working clipper Requests from the Europa Clipper project sequencing Anything related to the sequencing domain

Comments

@cartermak
Copy link
Member

Checked for duplicates

No - I haven't checked

Is this a regression?

No - This is a new bug

Version

2.11.2

Describe the bug

When writing hex values for UINT command arguments in SeqN, the Phoenix editor's range checking seems to misbehave.

I don't have a clear characterization of the issue, but this is what I've seen:

  1. On one UINT argument (second of five arguments) with a large max value (4294967292), users receive a range error even for hex values that are within the valid range.
  2. On another UINT argument (the last of the five arguments) with a small max value (100), users receive no error even if the specified hex value is outside the allowed range.

On their own, 1. would suggest that Phoenix doesn't know to parse the value as hex when assessing whether it's in range, but 2. would suggest Phoenix doesn't range check hex values at all. I haven't dug in to characterize whether either of the variables I identified (position of the argument and magnitude of the max range) actually affect this behavior.

It doesn't seem like the range checking issue affects the generated SeqJSON.

Reproduction

See my repro on Clipper-internal ticket: https://github.jpl.nasa.gov/Europa-PESS/clipper-phoenix-adaptation/issues/60

Logs

No response

System Info

Cloud deployment of Aerie 2.11.2 for Clipper.

Severity

Moderate

@cartermak cartermak added bug Something isn't working sequencing Anything related to the sequencing domain clipper Requests from the Europa Clipper project labels Sep 8, 2024
@mattdailis mattdailis added this to Aerie Sep 9, 2024
@github-project-automation github-project-automation bot moved this to Todo in Aerie Sep 9, 2024
@mattdailis mattdailis added this to the FY24 Q4 - UI Bug Fixes milestone Sep 9, 2024
@joswig joswig self-assigned this Sep 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Aerie Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clipper Requests from the Europa Clipper project sequencing Anything related to the sequencing domain
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants