Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove seqjson and seqn lang specifics #1446

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

cohansen
Copy link
Contributor

@cohansen cohansen commented Sep 3, 2024

Closes #1430.

Adds autoIndent and autoComplete to the sequence adaptation. I also cleaned up the linting calls so they go through extension-points again that way we're using more agnostic calls at the editor level.

@cohansen cohansen self-assigned this Sep 3, 2024
@cohansen cohansen requested a review from a team as a code owner September 3, 2024 18:22
@cohansen cohansen force-pushed the feature/remove-seqjson-and-seqn-lang-specifics branch from c9909a0 to a324860 Compare September 10, 2024 22:36
Copy link
Contributor

@goetzrrGit goetzrrGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify that the autocomplete works? I am testing locally on my end and I am not seeing commands appear in the autocomplete box.

@cohansen
Copy link
Contributor Author

Can you verify that the autocomplete works? I am testing locally on my end and I am not seeing commands appear in the autocomplete box.

Are you using an adaptation or using a parcel without one?
I just tested without and it was auto-completing commands for me!

@goetzrrGit
Copy link
Contributor

goetzrrGit commented Sep 13, 2024

Are you using an adaptation or using a parcel without one?
I just tested without and it was auto-completing commands for me!

I am using a parcel with no adaptation.

I see the command dictionary when the editor is being reconfigured but is is null when the autocomplete code is fired.

editorSequenceView.dispatch({
          effects: [
            compartmentSeqLanguage.reconfigure(
              setupLanguageSupport(
                $sequenceAdaptation.autoComplete(
                  parsedChannelDictionary,
                  parsedCommandDictionary,
                  nonNullParsedParameterDictionaries,
                ),
              ),
            ),

@cohansen
Copy link
Contributor Author

Are you using an adaptation or using a parcel without one?
I just tested without and it was auto-completing commands for me!

I am using a parcel with no adaptation.

I see the command dictionary when the editor is being reconfigured but is is null when the autocomplete code is fired.

editorSequenceView.dispatch({
          effects: [
            compartmentSeqLanguage.reconfigure(
              setupLanguageSupport(
                $sequenceAdaptation.autoComplete(
                  parsedChannelDictionary,
                  parsedCommandDictionary,
                  nonNullParsedParameterDictionaries,
                ),
              ),
            ),

I just retested this and I'm seeing the command dictionary being defined, maybe we can work through this on Monday?

@cohansen cohansen force-pushed the feature/remove-seqjson-and-seqn-lang-specifics branch from a324860 to 3eb39d7 Compare September 20, 2024 00:32
@goetzrrGit
Copy link
Contributor

@cohansen it seems to be working now. Maybe when you forced pushed it fixed the problem.

Copy link
Contributor

@goetzrrGit goetzrrGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now working on my end :) Just resolve @duranb request.

@cohansen
Copy link
Contributor Author

I just pushed up another commit @duranb and @duranb. This adds the autocomplete to a compartment and reconfigures it when the adaptation changes.

Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you!

@cohansen cohansen merged commit 78d20f3 into develop Sep 23, 2024
5 checks passed
@cohansen cohansen deleted the feature/remove-seqjson-and-seqn-lang-specifics branch September 23, 2024 21:28
JosephVolosin pushed a commit that referenced this pull request Sep 25, 2024
* Moved the lint calls outside of lang specific files

* Added a default adaptation and hooks for auto indent and auto complete

* Fixed filterText not having a type and reconfiguring the sequence editor

* Removed a lint problem

* Fixed an issue where reconfiguring the seqn editor was throwing away all extensions

* Moved auto complete to a comparment
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* Moved the lint calls outside of lang specific files

* Added a default adaptation and hooks for auto indent and auto complete

* Fixed filterText not having a type and reconfiguring the sequence editor

* Removed a lint problem

* Fixed an issue where reconfiguring the seqn editor was throwing away all extensions

* Moved auto complete to a comparment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route Phoenix editor auto indent and completion through adaptation logic
3 participants