Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for Julia-1.6.2 #40702

Merged
merged 58 commits into from
Jul 1, 2021
Merged

Backports for Julia-1.6.2 #40702

merged 58 commits into from
Jul 1, 2021

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented May 4, 2021

Non-merged PRs with backport label:

Liozou and others added 9 commits May 4, 2021 08:54
(cherry picked from commit 17ede14)
(cherry picked from commit a20e547)
(cherry picked from commit ca6df85)
* Fix rational division by zero
* Replace `BigFloat` by `BigInt`

Co-authored-by: Sebastian Stock <[email protected]>
(cherry picked from commit 2307f80)
On ELF platforms, `ld` can print out warnings that certain symbols do
not have a type or size annotation.  This adds the annotations to the
`DEBUGINFO` and `EXPORT` helper macros, which are where this information
was put for the windows assembler.  With this patch, we should eliminate
`ld` warnings such as:

```
warning: type and size of dynamic symbol `jl_symbol' are not defined
```

(cherry picked from commit ac7974a)
This PR fixes #40563 .
This is essentially a mirror of #39975 . Please refer to it for more information.

(cherry picked from commit 1a12495)
@KristofferC KristofferC added the release Release management and versioning. label May 4, 2021
@carlocab
Copy link
Contributor

carlocab commented May 4, 2021

Is there any chance of backporting ba653ec from #37723? It seems all the other commits from that PR were backported in #38949 except for that one.

@StefanKarpinski StefanKarpinski force-pushed the backports-release-1.6 branch from c54254d to 41ba8fb Compare May 4, 2021 21:40
@StefanKarpinski
Copy link
Member

Is there any chance of backporting ba653ec from #37723? It seems all the other commits from that PR were backported in #38949 except for that one.

Seems ok to me since it's only a build system change and arguably a bug fix.

@carlocab
Copy link
Contributor

carlocab commented May 5, 2021

Thank you!

wsmoses and others added 13 commits May 11, 2021 17:06
This allows linking the resulting code against another bitcode library (such as libopencilk-abi.bc) that was built with a different version of llvm debug info.

(cherry picked from commit 0f2ad74)
* fix consistency of trimtrailingzeros (Ryu)

(cherry picked from commit ff213c1)
This future-proofs us from someone trying lookup a symbol from
`libjulia.dll`, even though that should be quite rare, it may happen.

(cherry picked from commit 0af737c)
…#40487)

(which is pretty much all locks)

(cherry picked from commit 399ec04)
…different versions of loaded modules (#40345)

* allow Pkg precomp to not skip loaded modules

* rename to ignore_loaded_modules

* arg alignment

(cherry picked from commit 0da808d)
(cherry picked from commit 53dfc4b)
@KristofferC
Copy link
Member Author

@nanosoldier runtests(["AprilTags", "CodeTransformation", "GenericSVD", "HomotopyContinuation", "LazyArrays", "Publish", "SymbolServer"], vs = ":release-1.6")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@KristofferC
Copy link
Member Author

KristofferC commented Jun 11, 2021

AprilTags looks like it needs some attention.

Update:

Bisected it to #40487.

Somewhat of an MWE is:

using FileIO
using AprilTags
image = load("data/tagtest.jpg")
detector = AprilTagDetector()
image8 = convert(AprilTags.image_u8_t, image)
td = detector.td
im_orig = image8
@threadcall((:apriltag_detector_detect, AprilTags.libapriltag), Ptr{AprilTags.zarray_t}, (Ptr{AprilTags.apriltag_detector_t}, Ptr{AprilTags.image_u8_t}), td, Ref(im_orig))

cc @vtjnash

@vtjnash
Copy link
Member

vtjnash commented Jun 14, 2021

That is trying to eval a lookup of AprilTags.libapriltag at runtime, which is forbidden. The value must be constant value (e.g. libapriltag), not a function call (e.g. getproperty)

@KristofferC
Copy link
Member Author

@vtjnash, That is my bad with the MWE then, the original example is as:

https://github.com/JuliaRobotics/AprilTags.jl/blob/6fc29b4c796cdcb4aaf30a8d4119faba8cfb85bb/src/wrapper.jl#L414-L416

and no getproperty

KristofferC and others added 9 commits June 29, 2021 08:49
This adds a proof-of-concept demonstration of two new buildkite plugins:

* `cryptic` adds secrets management to privileged pipelines.  These
pipelines cannot be freely modified; their integrity is verified against
a signature maintained by committers with a secret key.  This allows
certain portions of the CI configuration (which are privileged and can
decrypt encrypted files/environment variables) to remain public, but
read-only to the general populace.

*  `sandbox` adds a generic sandboxing mechanism that allows CI steps to
be run within user-provided rootfs images.  We're using these here to
provide compiler toolchains for the `llvm-passes` CI steps, and the plan
is to eventually provide _all_ compiler toolchains through such rootfs
images.

(cherry picked from commit 61ae86d)
(cherry picked from commit 7553ca1)
* fix equality of QRCompactWY (#41363)

Equality for `QRCompactWY` did not ignore the subdiagonal entries of
`T` leading to nondeterministic behavior.

This is pulled out from #41228, since this change should be less
controversial than the other changes there and this particular bug just
came up in ChainRules again.
@KristofferC
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":release-1.6")

@KristofferC
Copy link
Member Author

@nanosoldier runbenchmarks(ALL, vs = ":release-1.6")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @christopher-dG

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@KristofferC
Copy link
Member Author

@nanosoldier runtests(["BLASBenchmarksCPU", "BioStructures", "CopEnt", "ImarisWriter", "IncrementalInference", "KernelDensityEstimatePlotting", "KrylovMethods", "LazyArrays", "PkgCite", "Publish", "RoMEPlotting", "SDDP", "SalesForceBulkApi", "SymbolServer", "Symbolics", "YAActL"], vs = ":release-1.6")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@KristofferC
Copy link
Member Author

@nanosoldier runtests(["BLASBenchmarksCPU", "ImarisWriter", "KernelDensityEstimatePlotting", "LazyArrays", "PkgCite", "Publish", "RoMEPlotting", "SymbolServer", "Symbolics"], vs = ":release-1.6")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@KristofferC KristofferC changed the title WIP: Backports for Julia-1.6.2 Backports for Julia-1.6.2 Jul 1, 2021
@KristofferC KristofferC merged commit 134c343 into release-1.6 Jul 1, 2021
@KristofferC KristofferC deleted the backports-release-1.6 branch July 1, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.