Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strcmp() to compare f_lib and JL_LIBJULIA_DL_LIBNAME #39005

Merged
merged 1 commit into from
Dec 26, 2020
Merged

Use strcmp() to compare f_lib and JL_LIBJULIA_DL_LIBNAME #39005

merged 1 commit into from
Dec 26, 2020

Conversation

staticfloat
Copy link
Member

This future-proofs us from someone trying lookup a symbol from
libjulia.dll, even though that should be quite rare, it may happen.

@staticfloat
Use strcmp() to compare f_lib and JL_LIBJULIA_DL_LIBNAME
dcdb925 
This future-proofs us from someone trying lookup a symbol from
`libjulia.dll`, even though that should be quite rare, it may happen.
@staticfloat staticfloat requested a review from vtjnash December 26, 2020 18:31
@staticfloat staticfloat merged commit 0af737c into master Dec 26, 2020
@staticfloat staticfloat deleted the sf/f_lib_strcmp branch December 26, 2020 23:49
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@staticfloat @ElOceanografo
Use strcmp() to compare f_lib and JL_LIBJULIA_DL_LIBNAME (Julia…
e7b4219 
…Lang#39005)

This future-proofs us from someone trying lookup a symbol from
`libjulia.dll`, even though that should be quite rare, it may happen.
@KristofferC KristofferC added the backport 1.6 Change should be backported to release-1.6 label May 11, 2021
KristofferC pushed a commit that referenced this pull request May 11, 2021
@staticfloat @KristofferC
Use strcmp() to compare f_lib and JL_LIBJULIA_DL_LIBNAME (#39005)
738de97 
This future-proofs us from someone trying lookup a symbol from
`libjulia.dll`, even though that should be quite rare, it may happen.

(cherry picked from commit 0af737c)
@KristofferC KristofferC mentioned this pull request Jun 4, 2021
Merged
45 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat added a commit that referenced this pull request Dec 23, 2022
@staticfloat
Use strcmp() to compare f_lib and JL_LIBJULIA_DL_LIBNAME (#39005)
8539548 
This future-proofs us from someone trying lookup a symbol from
`libjulia.dll`, even though that should be quite rare, it may happen.

(cherry picked from commit 0af737c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staticfloat @vtjnash @KristofferC