Fix wrong := REPL documentation #39975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, that might make sense, but that can be another PR. The current behavior is definitely wrong, so let's go with this for now. |
simeonschaub
approved these changes
Mar 10, 2021
|
Linux32 failure is likely because your branch is not based on top of latest master |
simeonschaub
pushed a commit
that referenced
this pull request
Apr 26, 2021
KristofferC
pushed a commit
that referenced
this pull request
May 4, 2021
(cherry picked from commit abde2f1)
KristofferC
pushed a commit
that referenced
this pull request
May 4, 2021
45 tasks
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
This PR fixes JuliaLang#40563 . This is essentially a mirror of JuliaLang#39975 . Please refer to it for more information.
jarlebring
pushed a commit
to jarlebring/julia
that referenced
this pull request
May 4, 2021
This PR fixes JuliaLang#40563 . This is essentially a mirror of JuliaLang#39975 . Please refer to it for more information.
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
This PR fixes JuliaLang#40563 . This is essentially a mirror of JuliaLang#39975 . Please refer to it for more information.
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
This PR fixes JuliaLang#40563 . This is essentially a mirror of JuliaLang#39975 . Please refer to it for more information.
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit abde2f1)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39427
It seems
:=deserved special casing among the operators finishing with=since it is one of four unsupported assignment operators (≔,⩴≕and:=), as written here:julia/src/julia-syntax.scm
Lines 4431 to 4433 in b2d66c9
Should they have special REPL documentation stating that they cannot be defined? With this PR, the default behavior is reinstated:
and the same for the other three, which I think should be enough since using any of these four operators yields: