Fix issue 1051

[m4gr3d]

This PR fixes issue #1051 by providing a better interface to input entry using a CardWheelHorizontalView widget.
The CardWheelHorizontalView widget behaves like a NumberPicker or a TimePicker but horizontally instead of vertically.
For example, you can swipe right/left to quickly change values, tap on the center value to edit with a keyboard.

[m4gr3d]

@arthurbenemann can you do some quick testing on the new widget. This should greatly improve the interface for input entry.

[m4gr3d]

@jason4short any thougths/feedback on the look & feel of the widget?

I think this is a better interface than the SeekBarWithText, and the Plus/Minus widgets that are currently in use throughout the app.

Right now it's only used in the waypoint detail windows, but if satisfied with its look & feel, the plan is to use it to replace the other currently used widgets.

[m4gr3d]

@arthurbenemann what's the status with Loiter and Loiter Indefinitely waypoint type? They're currently not working in the editor screen.

[arthurbenemann]

I'll merge this after I make our net public release.

@ne0fhyk I'm thinking about discontinuing both Loiter and LoiterInf, since thy are not all that useful, and we have circle.

[arthurbenemann]

Some debugging comments by @keyoss

thanks again.
some strange behavior if you rotate the 'wheel'.. have a look at the video :)
in lower altitude i would like to have decimal inputs.. like 2.5m 15.5m everything 50m and up may be scaleable by 1m.
i dont know if its enough height... ;)
i just think about flying in the alps. there you hit 600m fast.
overall: a big and easy improvement!
video: https://www.dropbox.com/s/sqif8gi0mcweblx/CONV.mp4?dl=0

[jason4short]

Looks great.

[keyoss]

checked if its because of the developer settings from my tablet: nope

it still persits on casual unrooted devices.. htc too

[m4gr3d]

@arthurbenemann by public release, do you mean the next beta release, or the next production release?

@keyoss can you specify the strange behavior. To me it seems to behave as designed.

[arthurbenemann]

@ne0fhyk Production release, I hope to get it done by the end of the day.

[keyoss]

@ne0fhyk just have a look at the video... 2-3 comments above.

if you created some waypoints, select one and 'spin the alt wheel' each waypoint starts to flicker (waypoint icon/red marker).
..
reproduction: everytime ...
i used to create 4 simple waypoints, adjust alt, spin the wheel (rotate and let it gooooooo), waypoints flicker as long as the wheel spins.

[m4gr3d]

@keyoss thanks for the update! I was looking at the widget, and not paying attention to items on the map.

[keyoss]

your welcome

[m4gr3d]

@keyoss I fixed the issue causing the waypoints to flicker. I'm updating the debug release so you can give it another try.
Regarding the other suggestions, the main goal for this widget is to replicate, and improve on the look & feel of the current widget (SeekbarWithText). Adding additional features, like the ones you suggested, can be done once this PR is considered stable, and merged into master.

[m4gr3d]

@keyoss and here's the debug apk fresh off the oven: https://github.com/ne0fhyk/droidplanner/releases/tag/v.2.7.6.1

[keyoss]

thanks, works... smooth as silk and cotton :)
top!

[m4gr3d]

@arthurbenemann the PR is ready for merging.
I'm holding off since you're near ready to push a production release, but I think this should be included as part of the production release, since it's mostly a UI update with no changes on the back end code.

[arthurbenemann]

@ne0fhyk I'm not making any changes now unless they have minor impact, or a needed. This PR might change the layout in places we don't expect, so I'm holding it for the moment.

[m4gr3d]

@arthurbenemann I'm merging this since the production release was updated. Feel free to revert the merge if you have other plans in mind.

[arthurbenemann]

@ne0fhyk thanks.