Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off by one error #1087

Closed
arthurbenemann opened this issue Sep 24, 2014 · 3 comments
Closed

Off by one error #1087

arthurbenemann opened this issue Sep 24, 2014 · 3 comments
Assignees
@m4gr3d
Labels
bug

Comments

@arthurbenemann
Copy link
Member

The new number entering system added at #1062 has some problems.

For example the sliders on mission planner for circle mode have an off-by-one error, on the advance menu.
@arthurbenemann
Copy link
Member Author

Here is a better description of how to reproduce the bug:

  • Go to Editor
  • Add a Circle waypoint
  • Go to the circle proprieties, and check the advanced checkbox
  • Set both "Number of Steps" and "Altitude Step" to 5
  • Exit the properties fragment
  • Open the Circle proprieties again
  • "Number of Steps" and "Altitude Step" are now 4

@m4gr3d
Copy link
Member

m4gr3d commented Sep 25, 2014

@arthurbenemann thanks for the update. I was able to replicate it, and it'll be fixed right away.

m4gr3d added a commit to m4gr3d/droidplanner that referenced this issue Sep 25, 2014
@m4gr3d
Fixes issue DroidPlanner#1087.
2c853be
m4gr3d added a commit that referenced this issue Sep 25, 2014
@m4gr3d
Merge pull request #1091 from ne0fhyk/fix_issue_1087
9887caf 
Fixes issue #1087.
@m4gr3d
Copy link
Member

m4gr3d commented Sep 25, 2014

fixed by #1091

@m4gr3d m4gr3d closed this as completed Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m4gr3d m4gr3d

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m4gr3d @arthurbenemann