Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK upgrade to v0.50 (branch) #1611

Merged
merged 22 commits into from
Sep 25, 2023
Merged

SDK upgrade to v0.50 (branch) #1611

merged 22 commits into from
Sep 25, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Sep 7, 2023 •
edited
Loading

Big thanks to notional for their help upgrading here and on ibc-go. Also to the ibc-go team for the quick help 💐

This is still an early version which is not fully up to date with our main.
Next step is the upgrade to ibc-go v8 for proper sdk 50 support

Notable changes:

  • No support for v1beta1 chain upgrade gov proposals ( removed from sdk)
  • No support for v1beta1 ibc gov proposals (removed from module)

@alpe alpe force-pushed the sdk-upgrade050_rebased3 branch from dcc0b0c to e5f2096 Compare September 8, 2023 07:36
@alpe alpe force-pushed the sdk-upgrade050_rebased3 branch from e5f2096 to 017b82e Compare September 8, 2023 07:37
@faddat @alpe
rebuild protos with newer proto builder
fca8cee 
(cherry picked from commit fd8f4c1)
@faddat @alpe
update ibc-go
b11ce83 
(cherry picked from commit fb86679)
@faddat
bump cosmos-sdk and ibc in the v50 branch (#1616)
5fa4442 
* tidy

* upgade ibc

* remove the toolchain command
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 11, 2023
View reviewed changes
x/wasm/keeper/test_common.go Dismissed Show dismissed Hide dismissed
app/app.go Fixed Show fixed Hide fixed
app/app.go Fixed Show fixed Hide fixed
@alpe alpe mentioned this pull request Sep 12, 2023
Closed
3 tasks
alpe and others added 8 commits September 15, 2023 09:47
@alpe
Bump sdk version
f402376
@alpe
Use correct bech32 prefix
b17cec2
@alpe
Merge branch 'main' into sdk-upgrade050_rebased3
dbc9460 
* main:
  Add store code authz (#1591)
  Handle query for non ibc contracts
  Test channels query
  Start rework channel query
  Restrict pagination on all state query
@alpe
Bump SDK
17c4ddc
@alpe
Enable fraud system test again
7ce4b85
@alpe
Fix genesis param name
22ee1a9
@alpe
Fix import/export simulations
5345249
@faddat @alpe
set log level for benchmarks
53b6b3e 
(cherry picked from commit 1cfb930)
This was referenced Sep 19, 2023
Closed
Closed
Closed
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #1611 (fe59702) into main (afa85da) will decrease coverage by 0.73%.
Report is 1 commits behind head on main.
The diff coverage is 61.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
- Coverage   56.73%   56.01%   -0.73%     
==========================================
  Files          64       64              
  Lines        8945     8996      +51     
==========================================
- Hits         5075     5039      -36     
- Misses       3479     3515      +36     
- Partials      391      442      +51
Files Changed Coverage Δ
app/encoding.go 0.00% <0.00%> (-100.00%) ⬇️
app/genesis.go 0.00% <0.00%> (-100.00%) ⬇️
app/test_support.go 0.00% <ø> (ø)
app/upgrades.go 33.33% <0.00%> (-40.67%) ⬇️
x/wasm/client/cli/new_tx.go 0.00% <0.00%> (ø)
x/wasm/client/cli/utils.go 0.00% <0.00%> (ø)
x/wasm/ibc.go 68.36% <ø> (ø)
x/wasm/keeper/contract_keeper.go 85.00% <ø> (ø)
x/wasm/keeper/ibc.go 77.77% <ø> (ø)
x/wasm/keeper/relay.go 96.80% <ø> (ø)
... and 34 more

... and 1 file with indirect coverage changes

@alpe
Merge branch 'main' into sdk-upgrade050_rebased3
902b901 
* main:
  Set default query limit and ensure constraints (#1632)
  Fix genesis import with predictable addresses
  Add grant system tests (#1626)
  Ensure some contraints and limits on pin/unpin code ids
@alpe alpe requested a review from pinosu September 19, 2023 11:03
pinosu
pinosu reviewed Sep 19, 2023
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
pinosu
pinosu reviewed Sep 19, 2023
View reviewed changes
app/export.go Outdated Show resolved Hide resolved
pinosu
pinosu reviewed Sep 19, 2023
View reviewed changes
x/wasm/ibctesting/chain.go Outdated Show resolved Hide resolved
pinosu
pinosu reviewed Sep 19, 2023
View reviewed changes
x/wasm/ibctesting/chain.go Outdated Show resolved Hide resolved
pinosu
pinosu reviewed Sep 19, 2023
View reviewed changes
x/wasm/ibctesting/chain.go Outdated Show resolved Hide resolved
pinosu
pinosu reviewed Sep 19, 2023
View reviewed changes
x/wasm/keeper/genesis_test.go Outdated
abci "github.com/cometbft/cometbft/abci/types"
"github.com/cometbft/cometbft/libs/log"
tmproto "github.com/cometbft/cometbft/proto/tendermint/types"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tmproto "github.com/cometbft/cometbft/proto/tendermint/types"
cmtproto "github.com/cometbft/cometbft/proto/tendermint/types"

pinosu
pinosu reviewed Sep 19, 2023
View reviewed changes
x/wasm/keeper/keeper.go Outdated Show resolved Hide resolved
pinosu
pinosu reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good job! 🥇 I added few comments.
Also I checked and there are still dependencies for gov v1beta1 in many files (mostly test files). Can we remove them? Probably good to have it in another pr, so we can backport it to 43 release.

@alpe alpe changed the title [WIP] SDK upgrade to v0.50 SDK upgrade to v0.50 (branch) Sep 21, 2023
pinosu
pinosu approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@alpe alpe marked this pull request as ready for review September 21, 2023 12:27
@pinosu pinosu merged commit cd66f78 into main Sep 25, 2023
9 checks passed
@pinosu pinosu deleted the sdk-upgrade050_rebased3 branch September 25, 2023 08:42
da1suk8 added a commit to da1suk8/wasmd that referenced this pull request Mar 28, 2024
@da1suk8
feat: apply PRs CosmWasm#1410 and CosmWasm#1611 to cmd/wasmplud
851fded
da1suk8 added a commit to da1suk8/wasmd that referenced this pull request Mar 28, 2024
@da1suk8
build: add cosmos.msg.v1.service annotation to lbm.wasm.v1.Msg
dc9ae90 
This commit is based on CosmWasm#1611
@bap2pecs bap2pecs mentioned this pull request Jul 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alpe @pinosu @faddat