SDK upgrade to v0.50.0 - part 1 #1528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use a more stable ibc-go * fix some small errors in accordance with what's working in ibc-go and wasmd * temporarily disable rosetta * add a few error checks and update some deprecated tendermint calls * error checks in export.go
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1033
to
+1040
| for _, m := range app.ModuleManager.Modules { | ||
| if moduleWithName, ok := m.(module.HasName); ok { | ||
| moduleName := moduleWithName.Name() | ||
| if appModule, ok := moduleWithName.(appmodule.AppModule); ok { | ||
| modules[moduleName] = appModule | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Comment on lines
+171
to
+173
| for eventName, hasEvent := range hasEvents { | ||
| suite.Require().True(hasEvent, "event: %s was not found in events", eventName) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
| maccPerms, | ||
| authcodec.NewBech32Codec(sdk.Bech32MainPrefix), |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants
| maccPerms, | ||
| authcodec.NewBech32Codec(sdk.Bech32MainPrefix), | ||
| authcodec.NewBech32Codec(sdk.Bech32PrefixValAddr), |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants
alpe
force-pushed
the
sdk-upgrade050_rebased2
branch
from
d8620bd to
ac225c6
Compare
Comment on lines
+1064
to
+1066
| for _, key := range app.keys { | ||
| keys = append(keys, key) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
alpe
changed the title
9 tasks
alpe
force-pushed
the
sdk-upgrade050_rebased2
branch
from
8f78db2 to
1411dac
Compare
alpe
changed the title
|
@alpe -- this is looking good now: |
|
Closing this in favour of #1611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1438
The export/import simulations fail currently with:
See upgrade doc in the SDK
I have started with just the go.mod dependencies and some related changes to imports.
New modules
Removed: legacy proposals for x/upgrade
[(cosmos_proto.scalar) = "cosmos.AddressString"]for addresses in protocosmos.msg.v1.serviceproto annotationNot started