Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recipe requirement inheritance #78572

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix recipe requirement inheritance #78572

wants to merge 1 commit into from
+2 −69

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Dec 14, 2024 •
edited
Loading

Summary

None

Purpose of change

(Will) Fix #60257

Describe the solution

Starting as a reversion of #78536 for convenience, will squash away the actual reversion so history isn't borked

Describe alternatives you've considered

Testing

Additional context

After getting a list of every recipe that uses copy from and getting rid of xl/xs ones there's 200 recipes that want manual review for this so it'll probably be on the backburner for some time

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Items: Armor / Clothing Armor and clothing <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

copy-from do not inherit the tools in recipes
1 participant
@Procyonae