Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy-from do not inherit the tools in recipes #60257

Open
GuardianDll opened this issue Aug 17, 2022 · 4 comments · Fixed by #66679 · May be fixed by #78572
Open

copy-from do not inherit the tools in recipes #60257

GuardianDll opened this issue Aug 17, 2022 · 4 comments · Fixed by #66679 · May be fixed by #78572
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Crafting / Construction / Recipes Includes: Uncrafting / Disassembling (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@GuardianDll
Copy link
Member

GuardianDll commented Aug 17, 2022

Is your feature request related to a problem? Please describe.

copy-from ignore the existence of tools inside the parent node. thats not okay

Steps

here is the lard recipe:

{
"type": "recipe",
"activity_level": "LIGHT_EXERCISE",
"result": "lard",
"byproducts": [ [ "cracklins" ] ],
"category": "CC_FOOD",
"subcategory": "CSC_FOOD_MEAT",
"skill_used": "cooking",
"difficulty": 3,
"time": "2 h",
"charges": 6,
"autolearn": true,
"batch_time_factors": [ 75, 2 ],
"qualities": [ { "id": "CUT", "level": 2 }, { "id": "COOK", "level": 2 } ],
"tools": [ [ [ "surface_heat", 60, "LIST" ] ] ],
"//": "this recipe is weird. 440g of fat and nothing else, presumably cut into cubes and cooked. the recipe should have water, but then it's not clear why this is different from tallow.",
"//1": "for now I'm going to treat it as dry rendering fat and the leftovers being turned into cracklins. Power cost goes up as a result, compared to 30u for cracklins (which use same amt of fat).",
"proficiencies": [ { "proficiency": "prof_food_prep" }, { "proficiency": "prof_knife_skills" } ],
"components": [ [ [ "fat", 2 ] ] ]
},

mutant_lard recipe copies it:
{
"type": "recipe",
"activity_level": "LIGHT_EXERCISE",
"result": "mutant_lard",
"copy-from": "lard",
"byproducts": [ [ "mutant_cracklins" ] ],
"qualities": [ { "id": "CUT", "level": 2 }, { "id": "COOK", "level": 2 } ],
"proficiencies": [ { "proficiency": "prof_food_prep" }, { "proficiency": "prof_knife_skills" } ],
"components": [ [ [ "mutant_fat", 2 ] ] ]
},

So tools exist in first, but doesn't exist in second, relying on inheritance

But in game it looks like this:

lard mutant_lard
image image

Solution you would like.

being able to inherit the tools

Describe alternatives you have considered.

no alternatives

@GuardianDll GuardianDll added the <Suggestion / Discussion> Talk it out before implementing label Aug 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 6, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2023
@Maleclypse Maleclypse reopened this Jul 5, 2023
@Maleclypse Maleclypse added (S2 - Confirmed) Bug that's been confirmed to exist Crafting / Construction / Recipes Includes: Uncrafting / Disassembling and removed <Suggestion / Discussion> Talk it out before implementing stale Closed for lack of activity, but still valid. labels Jul 5, 2023
@Maleclypse Maleclypse reopened this Jul 5, 2023
@RenechCDDA RenechCDDA added <Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Jul 5, 2023
@RenechCDDA
Copy link
Member

Seems that it's not copying any of: qualities or tools. Bizarrely enough it does copy using.

@RenechCDDA
Copy link
Member

See also: #53334

@Procyonae
Copy link
Contributor

Procyonae commented Jul 26, 2023

Also weirdly requirements can inherit extend and delete components, qualities and tools
Edit: Requirements don't support copy-from despite supporting the above???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Crafting / Construction / Recipes Includes: Uncrafting / Disassembling (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
4 participants