Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plant_stalk can be cooked without heat/fire #69057

Closed
jackledead opened this issue Nov 1, 2023 · 3 comments · Fixed by #71266
Closed

plant_stalk can be cooked without heat/fire #69057

jackledead opened this issue Nov 1, 2023 · 3 comments · Fixed by #71266
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.

Comments

@jackledead
Copy link
Contributor

Describe the bug

I picked some wild shrub, got a plant stalk (which i believe recently was replaced from the burdock stalk) and I could cook it without having any tools or heat/flame.

If you look at the code I believe it's from some copy_from shenanigans.

{
"type": "recipe",
"activity_level": "LIGHT_EXERCISE",
"result": "cooked_burdock_stalk",
"copy-from": "cooked_cattail_stalk",
"components": [ [ [ "plant_stalk", 1 ] ] ]
},

Attach save file

Mizpah_copy-trimmed.tar.gz

Steps to reproduce

debug spawn plant stalk. get recipe. get skills required. press & and make the cooked plant stalk with no fire.

Expected behavior

I expect to use heat/flame to cook the item like all the other veggie recipes.

Screenshots

plant stalk no fire

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.3570 (22H2)
  • Game Version: d1060e6 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Jackledead Infected [jackledead_infected],
    Jackledead Armory [jackledead_armory],
    Grow More Drugs (CDF+) [grow_more_drugs],
    Deadly Zombie Virus [deadly_bites],
    Disable Mutagens [no_mutagen],
    Tamable Wildlife [Tamable_Wildlife],
    Stats Through Skills [StatsThroughSkills],
    Stats Through Kills [stats_through_kills],
    SpeedyDex [speedydex]
    ]

Additional context

No response

@jackledead jackledead added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Nov 1, 2023
@Karol1223
Copy link
Contributor

It is indeed a problem with copy-from. It's been reported on Discord a bunch of times but I believe this is the first GitHub report. It could be trivially fixed in JSON but from what I heard the perfect solution would be to correct C++ copy-from behavior to fix the issue at the core.

@GuardianDll
Copy link
Member

#60257, both qualities and tools are not inherited

Copy link
Contributor

github-actions bot commented Dec 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Dec 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 1, 2024
7erracotta added a commit to 7erracotta/Cataclysm-DDA that referenced this issue Jan 25, 2024
Maleclypse pushed a commit that referenced this issue Jan 27, 2024
…71266)

* Plank stalks now cook properly.

Fixes #69057 ?

* Plant stalks now cook properly

 plant stalks require a heat source to cook.

* Fixes "qualities"

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants