fix: unexpose get note nonces on pxe #7889

sklppy88 · 2024-08-09T15:39:05Z

This PR unexposes getNoteNonces on the PXE by making notes returned from getIncomingNotes and getOutgoingNotes include a nonce.

This is done by extending ExtendedNote to create ExtendedNoteWithNonce, a new type that adds a required property, nonce, to the extended note.

I chose this approach instead of another e.g. adding an optional property on ExtendedNote because these data structures are fundamentally different—used in different places, for different reasons. It didn't make sense to me to try and shoehorn both uses to one struct, for the gain of slight de-duplication.

Because ExtendedNote is only used for notes added to or retrieved from the PXE, there were not that many required changes.

Note: I'm definitely not a fan with the naming but cannot currently think of anything better. Open to suggestions from the reviewer.

sklppy88 · 2024-08-09T15:39:23Z

fix: unexpose get note nonces on pxe #7889 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

AztecBot · 2024-08-09T16:22:17Z

Benchmark results

Metrics with a significant change:

proof_construction_time_sha256_100_ms (16): 5,715 (-18%)
proof_construction_time_sha256_30_ms (16): 1,424 (-22%)
protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 2,941 (+32%)
avm_simulation_time_ms (Token:transfer_public): 41.6 (+75%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,782 (-1%)	1,557 (-2%)	701	754 (+2%)	773 (+1%)
proof_construction_time_sha256_30_ms	11,883 (-3%)	3,184 (-2%)	⚠️ 1,424 (-22%)	1,452 (-11%)	1,470 (-6%)
proof_construction_time_sha256_100_ms	44,268 (-1%)	12,652 (+1%)	⚠️ 5,715 (-18%)	5,618 (-9%)	5,513 (-6%)
proof_construction_time_poseidon_hash_ms	79.0	34.0	34.0	58.0 (-3%)	88.0 (-2%)
proof_construction_time_poseidon_hash_30_ms	1,533 (-2%)	422 (-1%)	200	226 (-5%)	265 (-4%)
proof_construction_time_poseidon_hash_100_ms	5,685	1,535 (-1%)	677	713 (-3%)	749 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,576	92,486	177,572
l1_rollup_execution_gas	1,294,239	2,042,117	3,869,242
l2_block_processing_time_in_ms	253	449 (-2%)	824 (-2%)
l2_block_building_time_in_ms	9,627 (-3%)	18,851 (-1%)	37,511 (-1%)
l2_block_rollup_simulation_time_in_ms	9,626 (-3%)	18,851 (-1%)	37,511 (-1%)
l2_block_public_tx_process_time_in_ms	8,007 (-3%)	16,986 (-1%)	35,601

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,033 (-1%)	3,865 (-5%)
node_database_size_in_bytes	12,714,064	16,928,848
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	95.9	389 (+1%)	21,846	44,858	N/A	N/A	N/A	N/A
private-kernel-inner	173	688	72,545	45,005	N/A	N/A	N/A	N/A
private-kernel-tail	668	741 (-1%)	52,710	52,256	N/A	N/A	N/A	N/A
base-parity	5.99	623 (+2%)	160	96.0	1,124	13,188	19.0	65,536
root-parity	108 (-1%)	125	69,084	96.0	30,306	13,188	19.0	4,194,304
base-rollup	2,988 (-1%)	5,602 (-1%)	187,824	664	100,416 (+7%)	14,020	45.0	16,777,216
root-rollup	96.1 (-1%)	114 (-3%)	54,525	716	28,370 (-2%)	13,988	44.0	4,194,304
public-kernel-setup	90.6 (-1%)	2,830	103,782	71,222	17,412 (-2%)	129,220	3,645	2,097,152
public-kernel-app-logic	105 (-1%)	4,105 (+1%)	103,598	71,222	9,943 (-1%)	129,220	3,645	1,048,576
public-kernel-tail	567 (-1%)	31,495 (+3%)	409,190	16,414	101,864 (-1%)	34,308	679	16,777,216
private-kernel-reset-tiny	189 (-3%)	822	68,621	44,750	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	⚠️ 2,941 (+32%)	1,508 (-1%)	931,564	1,697	N/A	N/A	N/A	N/A
public-kernel-teardown	86.2	4,209 (+2%)	104,005	71,222	18,999 (+5%)	129,220	3,645	2,097,152
merge-rollup	59.3 (-1%)	N/A	35,742	664	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	69,885 (+3%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,344	11,731	346 (+1%)	N/A	N/A
ContractInstanceDeployer:deploy	1,408	11,731	18.0 (-1%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	11,731	480 (-1%)	N/A	N/A
FeeJuice:deploy	1,376	11,731	392 (+3%)	N/A	N/A
SchnorrAccount:constructor	1,312	11,731	176 (-1%)	N/A	N/A
SchnorrAccount:entrypoint	2,304	11,731	533	N/A	N/A
Token:privately_mint_private_note	1,280	11,731	213 (-5%)	N/A	N/A
FPC:fee_entrypoint_public	1,344	11,731	26.0 (+11%)	N/A	N/A
Token:transfer	1,312	11,731	404	N/A	N/A
AuthRegistry:set_authorized (avm)	18,491	N/A	N/A	146,400	2,152 (-2%)
FPC:prepare_fee (avm)	22,958	N/A	N/A	146,464	2,504 (-3%)
Token:transfer_public (avm)	61,614	N/A	N/A	146,464	10,545 (-1%)
AuthRegistry:consume (avm)	41,719	N/A	N/A	146,432	5,052 (-1%)
FPC:pay_refund (avm)	26,227	N/A	N/A	146,432	4,843 (-3%)
Benchmarking:create_note	1,344	11,731	170	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	11,731	27.4 (-1%)	N/A	N/A
Token:unshield	1,376	11,731	632 (-2%)	N/A	N/A
FPC:fee_entrypoint_private	1,376	11,731	831	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	93.2	8,139
FeeJuice:set_portal	11.8 (-4%)	2,362
Token:constructor	119 (-4%)	31,107
FPC:constructor	93.6 (-7%)	22,380
FeeJuice:mint_public	77.8 (-3%)	6,150
Token:mint_public	93.2 (+14%)	11,720
Token:assert_minter_and_mint	79.6 (-13%)	8,028
AuthRegistry:set_authorized	6.86 (-5%)	4,537
FPC:prepare_fee	269 (-8%)	8,812
Token:transfer_public	⚠️ 41.6 (+75%)	47,374
FPC:pay_refund	61.7 (+4%)	12,114
Benchmarking:increment_balance	1,022 (-1%)	7,450
Token:_increase_public_balance	11.3 (+9%)	8,960
FPC:pay_refund_with_shielded_rebate	137	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.166 (+4%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.22 (+1%)	3.94 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.115 (+1%)	0.111 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.7	18.1 (-4%)	32.7 (+2%)	59.3 (-3%)	118 (+4%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.113	0.105 (-4%)	0.106 (+3%)	0.102 (-2%)	0.106 (+4%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.5 (+3%)	26.3 (+1%)	45.9 (+2%)	83.4 (-4%)	167 (+4%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.110 (+3%)	0.105	0.111 (+3%)	0.103 (-4%)	0.107 (+4%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,756	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

benesjan

Feel free to merge once you rename ExtendedNoteWithNonce to UniqueNote.

benesjan · 2024-08-13T13:58:27Z

yarn-project/aztec.js/src/index.ts

@@ -102,6 +102,7 @@ export {
  EncryptedLogOutgoingBody,
  EventType,
  ExtendedNote,
+  ExtendedNoteWithNonce,


UniqueNote?

That's great, thank you !

yarn-project/pxe/src/pxe_service/pxe_service.ts

Co-authored-by: Jan Beneš <[email protected]>

github-actions · 2024-08-13T15:20:07Z

Changes to circuit sizes

Generated at commit: 4f90492c8820b6634784f45b0111a14aa10e0d7a, compared to commit: a96a5ad2b153cbe995de753cb7db1da0d0072e0c

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_tail	+9,756 ❌	+198.70%	+33,890 ❌	+276.59%
private_kernel_tail_to_public	+35,857 ❌	+95.46%	+62,520 ❌	+109.45%
public_kernel_tail	0 ➖	0.00%	-261,618 ✅	-2.79%
rollup_base	0 ➖	0.00%	-261,618 ✅	-2.88%
private_kernel_reset	-8,112 ✅	-6.93%	-31,234 ✅	-6.00%
private_kernel_reset_big	-5,941 ✅	-6.78%	-18,990 ✅	-6.34%
private_kernel_reset_medium	-4,669 ✅	-6.43%	-12,349 ✅	-6.55%
private_kernel_reset_small	-4,031 ✅	-6.18%	-9,027 ✅	-6.78%
private_kernel_reset_tiny	-3,712 ✅	-6.04%	-7,366 ✅	-6.98%
public_kernel_teardown	0 ➖	0.00%	-261,619 ✅	-13.63%
public_kernel_setup	0 ➖	0.00%	-261,618 ✅	-14.23%
rollup_root	0 ➖	0.00%	-784,853 ✅	-19.80%
rollup_merge	0 ➖	0.00%	-523,237 ✅	-19.98%
parity_root	0 ➖	0.00%	-1,046,472 ✅	-20.03%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_tail	14,666 (+9,756)	+198.70%	46,143 (+33,890)	+276.59%
private_kernel_tail_to_public	73,419 (+35,857)	+95.46%	119,640 (+62,520)	+109.45%
public_kernel_tail	1,006,333 (0)	0.00%	9,127,983 (-261,618)	-2.79%
rollup_base	349,423 (0)	0.00%	8,819,294 (-261,618)	-2.88%
private_kernel_reset	108,942 (-8,112)	-6.93%	489,428 (-31,234)	-6.00%
private_kernel_reset_big	81,638 (-5,941)	-6.78%	280,636 (-18,990)	-6.34%
private_kernel_reset_medium	67,985 (-4,669)	-6.43%	176,239 (-12,349)	-6.55%
private_kernel_reset_small	61,158 (-4,031)	-6.18%	124,144 (-9,027)	-6.78%
private_kernel_reset_tiny	57,746 (-3,712)	-6.04%	98,186 (-7,366)	-6.98%
public_kernel_teardown	296,142 (0)	0.00%	1,657,335 (-261,619)	-13.63%
public_kernel_setup	217,039 (0)	0.00%	1,576,592 (-261,618)	-14.23%
rollup_root	4,337 (0)	0.00%	3,179,742 (-784,853)	-19.80%
rollup_merge	2,852 (0)	0.00%	2,095,035 (-523,237)	-19.98%
parity_root	5,030 (0)	0.00%	4,179,166 (-1,046,472)	-20.03%

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.49.0</summary> ## [0.49.0](aztec-package-v0.48.0...aztec-package-v0.49.0) (2024-08-15) ### ⚠ BREAKING CHANGES * Sequencer no longer proves ([#7860](#7860)) ### Miscellaneous * Enable execute command on aws ecs services ([#7975](#7975)) ([4331bc6](4331bc6)) * Sequencer no longer proves ([#7860](#7860)) ([7168290](7168290)) * Terraform template for prover-node ([#7846](#7846)) ([546f946](546f946)) </details> <details><summary>barretenberg.js: 0.49.0</summary> ## [0.49.0](barretenberg.js-v0.48.0...barretenberg.js-v0.49.0) (2024-08-15) ### Miscellaneous * Pin yarn versions in noir-projects and bb/ts ([#7988](#7988)) ([83f33a1](83f33a1)) </details> <details><summary>aztec-packages: 0.49.0</summary> ## [0.49.0](aztec-packages-v0.48.0...aztec-packages-v0.49.0) (2024-08-15) ### ⚠ BREAKING CHANGES * alternative key registry contract ([#7523](#7523)) * Sequencer no longer proves ([#7860](#7860)) ### Features * Add `FunctionDefinition::parameters`, `FunctionDefinition::return_type` and `impl Eq for Quoted` (noir-lang/noir#5681) ([b1c7374](b1c7374)) * Add `Quoted::as_expr` and `Expr::as_function_call` (noir-lang/noir#5708) ([91042c7](91042c7)) * Add `Type::as_struct` (noir-lang/noir#5680) ([b1c7374](b1c7374)) * Add `Type::get_trait_impl` (noir-lang/noir#5716) ([ccbef55](ccbef55)) * Add `Type::implements` (noir-lang/noir#5701) ([91042c7](91042c7)) * Add `Type::is_field` and `Type::as_integer` (noir-lang/noir#5670) ([b1c7374](b1c7374)) * Add `Type` methods: `as_tuple`, `as_slice`, `as_array`, `as_constant`, `is_bool` (noir-lang/noir#5678) ([b1c7374](b1c7374)) * Add a limited form of arithmetic on generics (noir-lang/noir#5625) ([b1c7374](b1c7374)) * Add array_to_str_lossy (noir-lang/noir#5613) ([b1c7374](b1c7374)) * Add generate-secret-and-hash to cli ([#7977](#7977)) ([cdf62a0](cdf62a0)) * Add mutating FunctionDefinition functions (noir-lang/noir#5685) ([b1c7374](b1c7374)) * Add proven flag to sent tx wait opts ([#7950](#7950)) ([e80e7d2](e80e7d2)) * Add some `Module` comptime functions (noir-lang/noir#5684) ([b1c7374](b1c7374)) * Alternative key registry contract ([#7523](#7523)) ([3e6a20f](3e6a20f)) * **avm:** More no fake rows + virtual dyn gas (part 1) ([#7942](#7942)) ([9e8ba96](9e8ba96)) * Derive `Ord` and `Hash` in the stdlib; add `std::meta::make_impl` helper (noir-lang/noir#5683) ([b1c7374](b1c7374)) * Destroy_note_unsafe ([#7891](#7891)) ([5cda7ba](5cda7ba)) * **docs:** Nits ([#7838](#7838)) ([a76c999](a76c999)) * Enable UltraHonk verifier ([#7923](#7923)) ([5e8b4a8](5e8b4a8)), closes [#7373](#7373) * Implement closures in the comptime interpreter (noir-lang/noir#5682) ([b1c7374](b1c7374)) * IVC integration tests using new accumulate model ([#7946](#7946)) ([c527ae9](c527ae9)) * LSP autocompletion for use statement (noir-lang/noir#5704) ([91042c7](91042c7)) * LSP closing brace hints (noir-lang/noir#5686) ([b1c7374](b1c7374)) * LSP fields, functions and methods completion after "." and "::" (noir-lang/noir#5714) ([ccbef55](ccbef55)) * LSP hover now includes "Go to" links (noir-lang/noir#5677) ([b1c7374](b1c7374)) * LSP path completion (noir-lang/noir#5712) ([91042c7](91042c7)) * **noir_js:** Expose UltraHonk and integration tests (noir-lang/noir#5656) ([b1c7374](b1c7374)) * Optimizing PrivateFPC ([#7980](#7980)) ([d018335](d018335)) * Private refunds optimizations ([#7968](#7968)) ([cea8295](cea8295)) * Resolve arguments to attributes (noir-lang/noir#5649) ([b1c7374](b1c7374)) * **ssa:** Simple serialization of unoptimized SSA to file (noir-lang/noir#5679) ([b1c7374](b1c7374)) * Sync from aztec-packages (noir-lang/noir#5718) ([ccbef55](ccbef55)) * Update honk ultra_recursive_verifier to do aggregation ([#7582](#7582)) ([a96a5ad](a96a5ad)) ### Bug Fixes * Add locations to most SSA instructions (noir-lang/noir#5697) ([b1c7374](b1c7374)) * Allow txs on block zero ([#7928](#7928)) ([5e25cd6](5e25cd6)) * Build error in e2e_block_building ([0d0646d](0d0646d)) * **debugger:** Update the debugger to handle the new Brillig debug metadata format (noir-lang/noir#5706) ([91042c7](91042c7)) * Delete forks after proving job has finished ([#7972](#7972)) ([2b4a842](2b4a842)) * Deploy verifier cmd ([#7983](#7983)) ([f4fa797](f4fa797)) * Derive generic types (noir-lang/noir#5674) ([b1c7374](b1c7374)) * Do not duplicate redundant Brillig debug metadata (noir-lang/noir#5696) ([b1c7374](b1c7374)) * Do not mount ssh agent on OSX ([#7991](#7991)) ([950db8e](950db8e)) * **docs:** Add redirects for website links ([#7979](#7979)) ([e890814](e890814)) * Elaborate struct & trait annotations in the correct module (noir-lang/noir#5643) ([b1c7374](b1c7374)) * Fix where clause issue in items generated from attributes (noir-lang/noir#5673) ([b1c7374](b1c7374)) * Lay plumbing for having simulations throw an error if they cannot be added in a block ([#7839](#7839)) ([eedbc11](eedbc11)) * Let a trait impl that relies on another trait work (noir-lang/noir#5646) ([b1c7374](b1c7374)) * Only record bytecode if >0 ([#7932](#7932)) ([3f145b3](3f145b3)) * Remove missing file ([#7941](#7941)) ([4d9290f](4d9290f)) * Replace unused ArrayGet/Set with constrain if possibly out of bounds (noir-lang/noir#5691) ([ccbef55](ccbef55)) * Switch verify proof to arrays (noir-lang/noir#5664) ([b1c7374](b1c7374)) * Track L1 block for last L2 block body retrieved ([#7927](#7927)) ([cd36be4](cd36be4)), closes [#7918](#7918) * Unexpose get note nonces on pxe ([#7889](#7889)) ([163c3a6](163c3a6)) * Use data dir for lmdb forks ([#7973](#7973)) ([5b53d43](5b53d43)) * Workaround from_slice with nested slices (noir-lang/noir#5648) ([b1c7374](b1c7374)) ### Miscellaneous * Add docs tip about filenames between commands (noir-lang/noir#5695) ([b1c7374](b1c7374)) * Add env var to disable bb cleanup ([#7936](#7936)) ([806a370](806a370)) * Add parser support for `<MyType as Trait>::ident` (noir-lang/noir#5688) ([b1c7374](b1c7374)) * Add tests for noir<>ivc integration testing ([#7931](#7931)) ([7cc47a6](7cc47a6)) * Allow passing custom executors to fuzzer (noir-lang/noir#5710) ([91042c7](91042c7)) * **avm:** Fewer errors unless testing ([#7943](#7943)) ([33b65a9](33b65a9)) * **bb:** Constexpr simplifications ([#7906](#7906)) ([65d3b7f](65d3b7f)) * **bb:** Prereq work for polynomial mem optimization ([#7949](#7949)) ([5ca5138](5ca5138)) * **ci:** Print detailed target timings ([#7934](#7934)) ([fb574aa](fb574aa)) * Do not clean up bb files on err ([#7985](#7985)) ([75c6768](75c6768)) * Enable execute command on aws ecs services ([#7975](#7975)) ([4331bc6](4331bc6)) * Ensure bootstrapped networks have no pending blocks when proving starts ([#7986](#7986)) ([fb471b3](fb471b3)) * Fork logs and prover job catch ([#7982](#7982)) ([69bde53](69bde53)) * Move siloing to reset ([#7871](#7871)) ([014b5f0](014b5f0)) * Pin yarn versions in noir-projects and bb/ts ([#7988](#7988)) ([83f33a1](83f33a1)) * Release Noir(0.33.0) (noir-lang/noir#5550) ([b1c7374](b1c7374)) * Replace relative paths to noir-protocol-circuits ([cd5f138](cd5f138)) * Replace relative paths to noir-protocol-circuits ([6f3cef9](6f3cef9)) * Replace relative paths to noir-protocol-circuits ([54c4441](54c4441)) * Replace VERSION with IMAGE on provernet template ([d5e48aa](d5e48aa)) * Sequencer no longer proves ([#7860](#7860)) ([7168290](7168290)) * Simplify registry ([#7939](#7939)) ([8e0418f](8e0418f)) * Terraform template for prover-node ([#7846](#7846)) ([546f946](546f946)) * Update provernet docker compose template ([#7929](#7929)) ([33d47d2](33d47d2)) * Updating token with refunds ([#7969](#7969)) ([504deba](504deba)) </details> <details><summary>barretenberg: 0.49.0</summary> ## [0.49.0](barretenberg-v0.48.0...barretenberg-v0.49.0) (2024-08-15) ### Features * **avm:** More no fake rows + virtual dyn gas (part 1) ([#7942](#7942)) ([9e8ba96](9e8ba96)) * IVC integration tests using new accumulate model ([#7946](#7946)) ([c527ae9](c527ae9)) * Update honk ultra_recursive_verifier to do aggregation ([#7582](#7582)) ([a96a5ad](a96a5ad)) ### Miscellaneous * **avm:** Fewer errors unless testing ([#7943](#7943)) ([33b65a9](33b65a9)) * **bb:** Constexpr simplifications ([#7906](#7906)) ([65d3b7f](65d3b7f)) * **bb:** Prereq work for polynomial mem optimization ([#7949](#7949)) ([5ca5138](5ca5138)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.49.0</summary> ## [0.49.0](AztecProtocol/aztec-packages@aztec-package-v0.48.0...aztec-package-v0.49.0) (2024-08-15) ### ⚠ BREAKING CHANGES * Sequencer no longer proves ([#7860](AztecProtocol/aztec-packages#7860)) ### Miscellaneous * Enable execute command on aws ecs services ([#7975](AztecProtocol/aztec-packages#7975)) ([4331bc6](AztecProtocol/aztec-packages@4331bc6)) * Sequencer no longer proves ([#7860](AztecProtocol/aztec-packages#7860)) ([7168290](AztecProtocol/aztec-packages@7168290)) * Terraform template for prover-node ([#7846](AztecProtocol/aztec-packages#7846)) ([546f946](AztecProtocol/aztec-packages@546f946)) </details> <details><summary>barretenberg.js: 0.49.0</summary> ## [0.49.0](AztecProtocol/aztec-packages@barretenberg.js-v0.48.0...barretenberg.js-v0.49.0) (2024-08-15) ### Miscellaneous * Pin yarn versions in noir-projects and bb/ts ([#7988](AztecProtocol/aztec-packages#7988)) ([83f33a1](AztecProtocol/aztec-packages@83f33a1)) </details> <details><summary>aztec-packages: 0.49.0</summary> ## [0.49.0](AztecProtocol/aztec-packages@aztec-packages-v0.48.0...aztec-packages-v0.49.0) (2024-08-15) ### ⚠ BREAKING CHANGES * alternative key registry contract ([#7523](AztecProtocol/aztec-packages#7523)) * Sequencer no longer proves ([#7860](AztecProtocol/aztec-packages#7860)) ### Features * Add `FunctionDefinition::parameters`, `FunctionDefinition::return_type` and `impl Eq for Quoted` (noir-lang/noir#5681) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add `Quoted::as_expr` and `Expr::as_function_call` (noir-lang/noir#5708) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * Add `Type::as_struct` (noir-lang/noir#5680) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add `Type::get_trait_impl` (noir-lang/noir#5716) ([ccbef55](AztecProtocol/aztec-packages@ccbef55)) * Add `Type::implements` (noir-lang/noir#5701) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * Add `Type::is_field` and `Type::as_integer` (noir-lang/noir#5670) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add `Type` methods: `as_tuple`, `as_slice`, `as_array`, `as_constant`, `is_bool` (noir-lang/noir#5678) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add a limited form of arithmetic on generics (noir-lang/noir#5625) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add array_to_str_lossy (noir-lang/noir#5613) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add generate-secret-and-hash to cli ([#7977](AztecProtocol/aztec-packages#7977)) ([cdf62a0](AztecProtocol/aztec-packages@cdf62a0)) * Add mutating FunctionDefinition functions (noir-lang/noir#5685) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add proven flag to sent tx wait opts ([#7950](AztecProtocol/aztec-packages#7950)) ([e80e7d2](AztecProtocol/aztec-packages@e80e7d2)) * Add some `Module` comptime functions (noir-lang/noir#5684) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Alternative key registry contract ([#7523](AztecProtocol/aztec-packages#7523)) ([3e6a20f](AztecProtocol/aztec-packages@3e6a20f)) * **avm:** More no fake rows + virtual dyn gas (part 1) ([#7942](AztecProtocol/aztec-packages#7942)) ([9e8ba96](AztecProtocol/aztec-packages@9e8ba96)) * Derive `Ord` and `Hash` in the stdlib; add `std::meta::make_impl` helper (noir-lang/noir#5683) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Destroy_note_unsafe ([#7891](AztecProtocol/aztec-packages#7891)) ([5cda7ba](AztecProtocol/aztec-packages@5cda7ba)) * **docs:** Nits ([#7838](AztecProtocol/aztec-packages#7838)) ([a76c999](AztecProtocol/aztec-packages@a76c999)) * Enable UltraHonk verifier ([#7923](AztecProtocol/aztec-packages#7923)) ([5e8b4a8](AztecProtocol/aztec-packages@5e8b4a8)), closes [#7373](AztecProtocol/aztec-packages#7373) * Implement closures in the comptime interpreter (noir-lang/noir#5682) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * IVC integration tests using new accumulate model ([#7946](AztecProtocol/aztec-packages#7946)) ([c527ae9](AztecProtocol/aztec-packages@c527ae9)) * LSP autocompletion for use statement (noir-lang/noir#5704) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * LSP closing brace hints (noir-lang/noir#5686) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * LSP fields, functions and methods completion after "." and "::" (noir-lang/noir#5714) ([ccbef55](AztecProtocol/aztec-packages@ccbef55)) * LSP hover now includes "Go to" links (noir-lang/noir#5677) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * LSP path completion (noir-lang/noir#5712) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * **noir_js:** Expose UltraHonk and integration tests (noir-lang/noir#5656) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Optimizing PrivateFPC ([#7980](AztecProtocol/aztec-packages#7980)) ([d018335](AztecProtocol/aztec-packages@d018335)) * Private refunds optimizations ([#7968](AztecProtocol/aztec-packages#7968)) ([cea8295](AztecProtocol/aztec-packages@cea8295)) * Resolve arguments to attributes (noir-lang/noir#5649) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * **ssa:** Simple serialization of unoptimized SSA to file (noir-lang/noir#5679) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Sync from aztec-packages (noir-lang/noir#5718) ([ccbef55](AztecProtocol/aztec-packages@ccbef55)) * Update honk ultra_recursive_verifier to do aggregation ([#7582](AztecProtocol/aztec-packages#7582)) ([a96a5ad](AztecProtocol/aztec-packages@a96a5ad)) ### Bug Fixes * Add locations to most SSA instructions (noir-lang/noir#5697) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Allow txs on block zero ([#7928](AztecProtocol/aztec-packages#7928)) ([5e25cd6](AztecProtocol/aztec-packages@5e25cd6)) * Build error in e2e_block_building ([0d0646d](AztecProtocol/aztec-packages@0d0646d)) * **debugger:** Update the debugger to handle the new Brillig debug metadata format (noir-lang/noir#5706) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * Delete forks after proving job has finished ([#7972](AztecProtocol/aztec-packages#7972)) ([2b4a842](AztecProtocol/aztec-packages@2b4a842)) * Deploy verifier cmd ([#7983](AztecProtocol/aztec-packages#7983)) ([f4fa797](AztecProtocol/aztec-packages@f4fa797)) * Derive generic types (noir-lang/noir#5674) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Do not duplicate redundant Brillig debug metadata (noir-lang/noir#5696) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Do not mount ssh agent on OSX ([#7991](AztecProtocol/aztec-packages#7991)) ([950db8e](AztecProtocol/aztec-packages@950db8e)) * **docs:** Add redirects for website links ([#7979](AztecProtocol/aztec-packages#7979)) ([e890814](AztecProtocol/aztec-packages@e890814)) * Elaborate struct & trait annotations in the correct module (noir-lang/noir#5643) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Fix where clause issue in items generated from attributes (noir-lang/noir#5673) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Lay plumbing for having simulations throw an error if they cannot be added in a block ([#7839](AztecProtocol/aztec-packages#7839)) ([eedbc11](AztecProtocol/aztec-packages@eedbc11)) * Let a trait impl that relies on another trait work (noir-lang/noir#5646) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Only record bytecode if >0 ([#7932](AztecProtocol/aztec-packages#7932)) ([3f145b3](AztecProtocol/aztec-packages@3f145b3)) * Remove missing file ([#7941](AztecProtocol/aztec-packages#7941)) ([4d9290f](AztecProtocol/aztec-packages@4d9290f)) * Replace unused ArrayGet/Set with constrain if possibly out of bounds (noir-lang/noir#5691) ([ccbef55](AztecProtocol/aztec-packages@ccbef55)) * Switch verify proof to arrays (noir-lang/noir#5664) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Track L1 block for last L2 block body retrieved ([#7927](AztecProtocol/aztec-packages#7927)) ([cd36be4](AztecProtocol/aztec-packages@cd36be4)), closes [#7918](AztecProtocol/aztec-packages#7918) * Unexpose get note nonces on pxe ([#7889](AztecProtocol/aztec-packages#7889)) ([163c3a6](AztecProtocol/aztec-packages@163c3a6)) * Use data dir for lmdb forks ([#7973](AztecProtocol/aztec-packages#7973)) ([5b53d43](AztecProtocol/aztec-packages@5b53d43)) * Workaround from_slice with nested slices (noir-lang/noir#5648) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) ### Miscellaneous * Add docs tip about filenames between commands (noir-lang/noir#5695) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add env var to disable bb cleanup ([#7936](AztecProtocol/aztec-packages#7936)) ([806a370](AztecProtocol/aztec-packages@806a370)) * Add parser support for `<MyType as Trait>::ident` (noir-lang/noir#5688) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add tests for noir<>ivc integration testing ([#7931](AztecProtocol/aztec-packages#7931)) ([7cc47a6](AztecProtocol/aztec-packages@7cc47a6)) * Allow passing custom executors to fuzzer (noir-lang/noir#5710) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * **avm:** Fewer errors unless testing ([#7943](AztecProtocol/aztec-packages#7943)) ([33b65a9](AztecProtocol/aztec-packages@33b65a9)) * **bb:** Constexpr simplifications ([#7906](AztecProtocol/aztec-packages#7906)) ([65d3b7f](AztecProtocol/aztec-packages@65d3b7f)) * **bb:** Prereq work for polynomial mem optimization ([#7949](AztecProtocol/aztec-packages#7949)) ([5ca5138](AztecProtocol/aztec-packages@5ca5138)) * **ci:** Print detailed target timings ([#7934](AztecProtocol/aztec-packages#7934)) ([fb574aa](AztecProtocol/aztec-packages@fb574aa)) * Do not clean up bb files on err ([#7985](AztecProtocol/aztec-packages#7985)) ([75c6768](AztecProtocol/aztec-packages@75c6768)) * Enable execute command on aws ecs services ([#7975](AztecProtocol/aztec-packages#7975)) ([4331bc6](AztecProtocol/aztec-packages@4331bc6)) * Ensure bootstrapped networks have no pending blocks when proving starts ([#7986](AztecProtocol/aztec-packages#7986)) ([fb471b3](AztecProtocol/aztec-packages@fb471b3)) * Fork logs and prover job catch ([#7982](AztecProtocol/aztec-packages#7982)) ([69bde53](AztecProtocol/aztec-packages@69bde53)) * Move siloing to reset ([#7871](AztecProtocol/aztec-packages#7871)) ([014b5f0](AztecProtocol/aztec-packages@014b5f0)) * Pin yarn versions in noir-projects and bb/ts ([#7988](AztecProtocol/aztec-packages#7988)) ([83f33a1](AztecProtocol/aztec-packages@83f33a1)) * Release Noir(0.33.0) (noir-lang/noir#5550) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Replace relative paths to noir-protocol-circuits ([cd5f138](AztecProtocol/aztec-packages@cd5f138)) * Replace relative paths to noir-protocol-circuits ([6f3cef9](AztecProtocol/aztec-packages@6f3cef9)) * Replace relative paths to noir-protocol-circuits ([54c4441](AztecProtocol/aztec-packages@54c4441)) * Replace VERSION with IMAGE on provernet template ([d5e48aa](AztecProtocol/aztec-packages@d5e48aa)) * Sequencer no longer proves ([#7860](AztecProtocol/aztec-packages#7860)) ([7168290](AztecProtocol/aztec-packages@7168290)) * Simplify registry ([#7939](AztecProtocol/aztec-packages#7939)) ([8e0418f](AztecProtocol/aztec-packages@8e0418f)) * Terraform template for prover-node ([#7846](AztecProtocol/aztec-packages#7846)) ([546f946](AztecProtocol/aztec-packages@546f946)) * Update provernet docker compose template ([#7929](AztecProtocol/aztec-packages#7929)) ([33d47d2](AztecProtocol/aztec-packages@33d47d2)) * Updating token with refunds ([#7969](AztecProtocol/aztec-packages#7969)) ([504deba](AztecProtocol/aztec-packages@504deba)) </details> <details><summary>barretenberg: 0.49.0</summary> ## [0.49.0](AztecProtocol/aztec-packages@barretenberg-v0.48.0...barretenberg-v0.49.0) (2024-08-15) ### Features * **avm:** More no fake rows + virtual dyn gas (part 1) ([#7942](AztecProtocol/aztec-packages#7942)) ([9e8ba96](AztecProtocol/aztec-packages@9e8ba96)) * IVC integration tests using new accumulate model ([#7946](AztecProtocol/aztec-packages#7946)) ([c527ae9](AztecProtocol/aztec-packages@c527ae9)) * Update honk ultra_recursive_verifier to do aggregation ([#7582](AztecProtocol/aztec-packages#7582)) ([a96a5ad](AztecProtocol/aztec-packages@a96a5ad)) ### Miscellaneous * **avm:** Fewer errors unless testing ([#7943](AztecProtocol/aztec-packages#7943)) ([33b65a9](AztecProtocol/aztec-packages@33b65a9)) * **bb:** Constexpr simplifications ([#7906](AztecProtocol/aztec-packages#7906)) ([65d3b7f](AztecProtocol/aztec-packages@65d3b7f)) * **bb:** Prereq work for polynomial mem optimization ([#7949](AztecProtocol/aztec-packages#7949)) ([5ca5138](AztecProtocol/aztec-packages@5ca5138)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

sklppy88 changed the title ~~init~~ fix: unexpose get note nonces on pxe Aug 9, 2024

sklppy88 force-pushed the ek/fix/4956/unexpose-get-note-nonces-on-pxe branch 7 times, most recently from 2b02788 to 0f723fe Compare August 13, 2024 11:22

init

7ec6080

sklppy88 force-pushed the ek/fix/4956/unexpose-get-note-nonces-on-pxe branch from 0f723fe to 7ec6080 Compare August 13, 2024 11:27

sklppy88 marked this pull request as ready for review August 13, 2024 13:01

sklppy88 requested a review from benesjan August 13, 2024 13:35

benesjan approved these changes Aug 13, 2024

View reviewed changes

sklppy88 force-pushed the ek/fix/4956/unexpose-get-note-nonces-on-pxe branch 2 times, most recently from e135729 to 50eb401 Compare August 13, 2024 15:13

addressing Jan's comments

4c33a50

sklppy88 force-pushed the ek/fix/4956/unexpose-get-note-nonces-on-pxe branch from 50eb401 to 4c33a50 Compare August 13, 2024 15:17

Update yarn-project/pxe/src/pxe_service/pxe_service.ts

f72da7d

Co-authored-by: Jan Beneš <[email protected]>

sklppy88 merged commit 163c3a6 into master Aug 13, 2024
95 of 97 checks passed

sklppy88 deleted the ek/fix/4956/unexpose-get-note-nonces-on-pxe branch August 13, 2024 16:09

AztecBot mentioned this pull request Aug 13, 2024

chore(master): Release 0.49.0 #7933

Merged

sklppy88 linked an issue Aug 13, 2024 that may be closed by this pull request

Make pxe.getNotes(...) include note nonces #4956

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: unexpose get note nonces on pxe #7889

fix: unexpose get note nonces on pxe #7889

sklppy88 commented Aug 9, 2024 •

edited

Loading

sklppy88 commented Aug 9, 2024

AztecBot commented Aug 9, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

benesjan left a comment

benesjan Aug 13, 2024

sklppy88 Aug 13, 2024

github-actions bot commented Aug 13, 2024

fix: unexpose get note nonces on pxe #7889

fix: unexpose get note nonces on pxe #7889

Conversation

sklppy88 commented Aug 9, 2024 • edited Loading

sklppy88 commented Aug 9, 2024

AztecBot commented Aug 9, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

benesjan left a comment

Choose a reason for hiding this comment

benesjan Aug 13, 2024

Choose a reason for hiding this comment

sklppy88 Aug 13, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 13, 2024

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

sklppy88 commented Aug 9, 2024 •

edited

Loading

AztecBot commented Aug 9, 2024 •

edited

Loading