Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pxe.getNotes(...) include note nonces #4956

Closed
benesjan opened this issue Mar 5, 2024 · 0 comments · Fixed by #7889
Closed

Make pxe.getNotes(...) include note nonces #4956

benesjan opened this issue Mar 5, 2024 · 0 comments · Fixed by #7889
Assignees

Comments

@benesjan
Copy link
Contributor

benesjan commented Mar 5, 2024

Currently we don't return note nonces from getNotes(...) and this forced us to expose getNoteNonces(...) on PXE when implementing the crowdfunding contract. We needed the nonce there because we used note inclusion proof to claim a reward token and note inclusion proof requires it.

I originally implemented the ExtendedNote type which is returned from getNotes and I didn't include there the nonce because it is also used when adding a note and we didn't need the nonce there at that time.

Note: Look for TODO(#4956) in the codebase.

@github-project-automation github-project-automation bot moved this to Todo in A3 Mar 5, 2024
@sklppy88 sklppy88 self-assigned this Aug 8, 2024
@sklppy88 sklppy88 linked a pull request Aug 13, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants