You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we don't return note nonces from getNotes(...) and this forced us to expose getNoteNonces(...) on PXE when implementing the crowdfunding contract. We needed the nonce there because we used note inclusion proof to claim a reward token and note inclusion proof requires it.
I originally implemented the ExtendedNote type which is returned from getNotes and I didn't include there the nonce because it is also used when adding a note and we didn't need the nonce there at that time.
Currently we don't return note nonces from
getNotes(...)
and this forced us to exposegetNoteNonces(...)
on PXE when implementing the crowdfunding contract. We needed the nonce there because we used note inclusion proof to claim a reward token and note inclusion proof requires it.I originally implemented the
ExtendedNote
type which is returned fromgetNotes
and I didn't include there the nonce because it is also used when adding a note and we didn't need the nonce there at that time.Note: Look for TODO(#4956) in the codebase.
The text was updated successfully, but these errors were encountered: