feat: update honk ultra_recursive_verifier to do aggregation #7582

lucasxia01 · 2024-07-23T18:14:53Z

Resolves AztecProtocol/barretenberg#1059.

This work updates the recursive verifier to now take in an pairing aggregation object and also produce one. This object aggregates with the nested aggregation object (parsed through the public inputs of the inner proof) and the pairing points produced by KZG. This change is inefficient as every circuit will now also produce an aggregation object, regardless of whether the circuit does any recursive aggregation. This adds gates presumably through only the public_input_delta, but this needs to be double checked.
This also means that for circuits that do k recursive aggregations, we will be doing 2*k biggroup mul-adds for aggregation, because every inner proof contains an agg obj. Each mul-add was seemingly costing 130k gates, so this likely needs to be optimized heavily.

Note that the native honk verifier was not updated in this PR. This will be updated in a future PR, and will likely force many tests (any test that has a native verify call) to call builder.add_recursive_proof(default_agg_obj).

----------------------------------------------------------------------------(t----                                                                        G 
Benchmark                      Time             CPU   Iterations UserCounterMPs...                                                                        ac
----------------------------------------------------------------------------me----                                                                        er
ClientIVCBench/Full/6      14201 ms        11382 ms            1 Arithmetic:t::accumulate=925.279k Arithmetic::accumulate(t)=1.7492G Auxiliary::accumulateat=662.109k Auxiliary::accumulate(t)=4.22266G COMMIT::databus=99 COMMIT::databorus(t)=15.0423M COMMIT::databus_inverses=33 COMMIT::databus_inverses(t)=5.823ot72M COMMIT::ecc_op_wires=44 COMMIT::ecc_op_wires(t)=52.5121M COMMIT::lookup_iecounts_tags=11 COMMIT::lookup_counts_tags(t)=96.946M COMMIT::lookup_inversesve=11 COMMIT::lookup_inverses(t)=188.14M COMMIT::wires=22 COMMIT::wires(t)=873ro.361M COMMIT::z_perm=11 COMMIT::z_perm(t)=486.403M DatabusRead::accumulate=1nc.08k DatabusRead::accumulate(t)=2.63112M Decider::construct_proof=1 Decider:=1:construct_proof(t)=490.757M DeltaRange::accumulate=567.476k DeltaRange::acc=1umulate(t)=1.21739G ECCVMProver(CircuitBuilder&)=1 ECCVMProver(CircuitBuildeatr&)(t)=217.977M ECCVMProver::construct_proof=1 ECCVMProver::construct_proof(ont)=2.57046G Elliptic::accumulate=301.299k Elliptic::accumulate(t)=712.829M Goroblin::merge=11 Goblin::merge(t)=173.953M Lookup::accumulate=982.609k Lookuprs::accumulate(t)=1.79158G Permutation::accumulate=2.06909M Permutation::accumrbulate(t)=7.56796G PoseidonExt::accumulate=52.373k PoseidonExt::accumulate(t)at=121.365M PoseidonInt::accumulate=206.097k PoseidonInt::accumulate(t)=348.071M ProtoGalaxyProver_::accumulator_update_round=10 ProtoGalaxyProver_::accumulator_update_round(t)=367.173M ProtoGalaxyProver_::combiner_quotient_round= 10 ProtoGalaxyProver_::combiner_quotient_round(t)=2.29623G ProtoGalaxyProver_::perturbator_round=10 ProtoGalaxyProver_::perturbator_round(t)=743.216M ProtoGalaxyProver_::preparation_round=10 ProtoGalaxyProver_::preparation_round(t)=2.60138G ProtogalaxyProver::fold_instances=10 ProtogalaxyProver::fold_instances(t)=6.00803G ProverInstance(Circuit&)=11 ProverInstance(Circuit&)(t)=1.83432G TranslatorCircuitBuilder::constructor=1 TranslatorCircuitBuilder::constructor(t)=29.7336M TranslatorProver=1 TranslatorProver(t)=56.2759M TranslatorProver::construct_proof=1 TranslatorProver::construct_proof(t)=816.274M batch_mul_with_endomorphism=16 batch_mul_with_endomorphism(t)=405.195M commit=373 commit(t)=2.90803G commit_sparse=176 commit_sparse(t)=73.3347M compute_combiner=10 compute_combiner(t)=2.29416G compute_perturbator=9 compute_perturbator(t)=742.897M compute_univariate=49 compute_univariate(t)=1.73065G construct_circuits=15 construct_circuits(t)=1.92542G
Benchmarking lock deleted.
client_ivc_bench.json                       100% 5418   162.9KB/s   00:00    
function                                  ms     % sum
construct_circuits(t)                   1925    13.72%
ProverInstance(Circuit&)(t)             1834    13.07%
ProtogalaxyProver::fold_instances(t)    6008    42.80%
Decider::construct_proof(t)              491     3.50%
ECCVMProver(CircuitBuilder&)(t)          218     1.55%
ECCVMProver::construct_proof(t)         2570    18.31%
TranslatorProver::construct_proof(t)     816     5.82%
Goblin::merge(t)                         174     1.24%

Total time accounted for: 14037ms/14201ms = 98.84%

Major contributors:
function                                  ms    % sum
commit(t)                               2908   20.72%
compute_combiner(t)                     2294   16.34%
compute_perturbator(t)                   743    5.29%
compute_univariate(t)                   1731   12.33%

Breakdown of ProtogalaxyProver::fold_instances:
ProtoGalaxyProver_::preparation_round(t)           2601    43.30%
ProtoGalaxyProver_::perturbator_round(t)            743    12.37%
ProtoGalaxyProver_::combiner_quotient_round(t)     2296    38.22%
ProtoGalaxyProver_::accumulator_update_round(t)     367     6.11%

Relation contributions (times to be interpreted relatively):
Total time accounted for (ms):    17734
operation                       ms     % sum
Arithmetic::accumulate(t)     1749     9.86%
Permutation::accumulate(t)    7568    42.68%
Lookup::accumulate(t)         1792    10.10%
DeltaRange::accumulate(t)     1217     6.86%
Elliptic::accumulate(t)        713     4.02%
Auxiliary::accumulate(t)      4223    23.81%
EccOp::accumulate(t)             0     0.00%
DatabusRead::accumulate(t)       3     0.01%
PoseidonExt::accumulate(t)     121     0.68%
PoseidonInt::accumulate(t)     348     1.96%

Commitment contributions:
Total time accounted for (ms):     1718
operation                          ms     % sum
COMMIT::wires(t)                  873    50.83%
COMMIT::z_perm(t)                 486    28.31%
COMMIT::databus(t)                 15     0.88%
COMMIT::ecc_op_wires(t)            53     3.06%
COMMIT::lookup_inverses(t)        188    10.95%
COMMIT::databus_inverses(t)         6     0.34%
COMMIT::lookup_counts_tags(t)      97     5.64%

…ztec-packages into lx/reinstate-aggregation

AztecBot

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite	Current: `e9479a5`	Previous: `3178d85`	Ratio
`commit(t)`	`3750651087` ns/iter	`3567748707` ns/iter	`1.05`

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

…state_ct to see their use (pretty much none)

Closes AztecProtocol/barretenberg#1044. Re-enables (most) aggregation code that was disabled in the Honk-rollup work. Adds a hack to the tube circuit that adds a default aggregation object, which will be fixed in a followup PR (probably #7582).

Closes #1044. Re-enables (most) aggregation code that was disabled in the Honk-rollup work. Adds a hack to the tube circuit that adds a default aggregation object, which will be fixed in a followup PR (probably AztecProtocol/aztec-packages#7582).

…obj-handling

AztecBot · 2024-07-29T16:16:00Z

Benchmark results

Metrics with a significant change:

app_circuit_witness_generation_time_in_ms (Token:transfer): 478 (+16%)
protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 2,197 (-18%)
protocol_circuit_witness_generation_time_in_ms (public-kernel-tail): 31,430 (+21%)
protocol_circuit_proving_time_in_ms (root-parity): 52,305 (+93%)
protocol_circuit_proving_time_in_ms (public-kernel-setup): 18,170 (+21%)
protocol_circuit_proving_time_in_ms (base-rollup): 101,258 (+21%)
protocol_circuit_proving_time_in_ms (public-kernel-app-logic): 10,167 (+18%)
protocol_circuit_proving_time_in_ms (public-kernel-teardown): 18,965 (+18%)
protocol_circuit_proving_time_in_ms (root-rollup): 31,601 (+28%)
protocol_circuit_size_in_gates (root-parity): 8,388,608 (+100%)
app_circuit_proving_time_in_ms (Token:transfer_public (avm)): 10,632 (+16%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,756	1,554	695	745 (-1%)	768
proof_construction_time_sha256_30_ms	11,911	3,179	1,413	1,443	1,479
proof_construction_time_sha256_100_ms	44,191	12,451 (+1%)	5,738 (+1%)	5,599 (-1%)	5,548 (+1%)
proof_construction_time_poseidon_hash_ms	78.0 (-1%)	34.0	34.0	59.0	87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,527 (-1%)	417	199 (-1%)	226	270 (-3%)
proof_construction_time_poseidon_hash_100_ms	5,661	1,524 (-1%)	678	728 (-1%)	747 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,708	92,250	177,500
l1_rollup_execution_gas	1,294,371	2,041,881	3,869,170
l2_block_processing_time_in_ms	246 (-5%)	457	826 (+1%)
l2_block_building_time_in_ms	9,630 (-1%)	18,834	37,722
l2_block_rollup_simulation_time_in_ms	9,629 (-1%)	18,834	37,722
l2_block_public_tx_process_time_in_ms	8,005 (-1%)	16,968	35,664

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,018 (+5%)	3,983 (+1%)
node_database_size_in_bytes	12,746,832	16,871,504
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	98.1 (-2%)	393 (-6%)	21,846	44,858	N/A	N/A	N/A	N/A
private-kernel-inner	177 (+5%)	700 (-5%)	72,545	45,005	N/A	N/A	N/A	N/A
private-kernel-tail	671	778	52,710	52,256	N/A	N/A	N/A	N/A
base-parity	6.31 (+2%)	611 (-5%)	160	96.0	1,124 (+4%)	13,188	19.0	65,536
root-parity	111 (+1%)	124 (+10%)	69,084	96.0	⚠️ 52,305 (+93%)	13,188	19.0	⚠️ 8,388,608 (+100%)
base-rollup	2,997	5,423 (-5%)	187,824	664	⚠️ 101,258 (+21%)	14,020	45.0	16,777,216
root-rollup	103 (+6%)	119 (+9%)	54,525	716	⚠️ 31,601 (+28%)	13,988	44.0	4,194,304
public-kernel-setup	90.3 (-3%)	2,836 (+4%)	103,782	71,222	⚠️ 18,170 (+21%)	129,220	3,645	2,097,152
public-kernel-app-logic	106 (-1%)	4,165 (+3%)	103,598	71,222	⚠️ 10,167 (+18%)	129,220	3,645	1,048,576
public-kernel-tail	568 (-1%)	⚠️ 31,430 (+21%)	409,190	16,414	100,927 (+10%)	34,308	679	16,777,216
private-kernel-reset-tiny	194 (+7%)	871 (-1%)	68,621	44,750	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	⚠️ 2,197 (-18%)	1,559 (-2%)	931,564	1,697	N/A	N/A	N/A	N/A
public-kernel-teardown	89.3 (+2%)	4,279 (+3%)	104,005	71,222	⚠️ 18,965 (+18%)	129,220	3,645	2,097,152
merge-rollup	60.1 (-1%)	N/A	35,742	664	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	67,444 (+5%)	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,344	11,731	342 (-1%)	N/A	N/A
ContractInstanceDeployer:deploy	1,408	11,731	18.0 (-1%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	11,731	474 (-1%)	N/A	N/A
FeeJuice:deploy	1,376	11,731	392	N/A	N/A
SchnorrAccount:constructor	1,312	11,731	176 (-1%)	N/A	N/A
SchnorrAccount:entrypoint	2,304	11,731	541 (+1%)	N/A	N/A
Token:privately_mint_private_note	1,280	11,731	227 (+3%)	N/A	N/A
FPC:fee_entrypoint_public	1,344	11,731	28.8 (+22%)	N/A	N/A
Token:transfer	1,312	11,731	⚠️ 478 (+16%)	N/A	N/A
AuthRegistry:set_authorized (avm)	18,491	N/A	N/A	146,400	2,194 (-4%)
FPC:prepare_fee (avm)	22,958	N/A	N/A	146,464	2,524 (-4%)
Token:transfer_public (avm)	61,614	N/A	N/A	146,464	⚠️ 10,632 (+16%)
AuthRegistry:consume (avm)	41,719	N/A	N/A	146,432	5,021 (+3%)
FPC:pay_refund (avm)	26,227	N/A	N/A	146,432	4,964 (+5%)
Benchmarking:create_note	1,344	11,731	170 (+1%)	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	11,731	27.4	N/A	N/A
Token:unshield	1,376	11,731	636	N/A	N/A
FPC:fee_entrypoint_private	1,376	11,731	825	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	102 (+8%)	8,139
FeeJuice:set_portal	9.98 (+1%)	2,362
Token:constructor	132 (+5%)	31,107
FPC:constructor	96.8 (-7%)	22,380
FeeJuice:mint_public	84.1 (+2%)	6,150
Token:mint_public	91.0 (-4%)	11,720
Token:assert_minter_and_mint	109 (+22%)	8,028
AuthRegistry:set_authorized	8.07 (-1%)	4,537
FPC:prepare_fee	285	8,812
Token:transfer_public	29.2 (-7%)	47,374
FPC:pay_refund	58.0 (-5%)	12,114
Benchmarking:increment_balance	1,025	7,450
Token:_increase_public_balance	9.55 (-17%)	8,960
FPC:pay_refund_with_shielded_rebate	142 (+3%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.164 (+4%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.21 (+1%)	3.85 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.114	0.109 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.7 (+3%)	19.1 (+7%)	31.1 (+1%)	60.8 (-1%)	118 (+4%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.112 (+3%)	0.111 (+7%)	0.101 (+1%)	0.104 (-1%)	0.105 (+3%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3 (-2%)	26.0 (+1%)	43.9 (-1%)	84.2 (-1%)	168 (+4%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108 (-2%)	0.105 (+1%)	0.106	0.104 (-1%)	0.107 (+4%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

…put_indices and the agg obj in public inputs

github-actions · 2024-07-30T12:13:29Z

Changes to circuit sizes

Generated at commit: 7a81494bf3d55cecac6220172826e9cc2995845a, compared to commit: 014b5f03f720e8f56199ec0b1c34694bd0e100e1

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_tail	+9,756 ❌	+198.70%	+33,890 ❌	+276.59%
private_kernel_tail_to_public	+35,857 ❌	+95.46%	+62,520 ❌	+109.45%
parity_root	0 ➖	0.00%	+1,046,472 ❌	+25.04%
rollup_merge	0 ➖	0.00%	+523,237 ❌	+24.98%
rollup_root	0 ➖	0.00%	+784,853 ❌	+24.68%
public_kernel_setup	0 ➖	0.00%	+261,618 ❌	+16.59%
public_kernel_teardown	0 ➖	0.00%	+261,619 ❌	+15.79%
rollup_base	0 ➖	0.00%	+261,618 ❌	+2.97%
public_kernel_tail	0 ➖	0.00%	+261,618 ❌	+2.87%
private_kernel_reset	-8,112 ✅	-6.93%	-31,234 ✅	-6.00%
private_kernel_reset_big	-5,941 ✅	-6.78%	-18,990 ✅	-6.34%
private_kernel_reset_medium	-4,669 ✅	-6.43%	-12,349 ✅	-6.55%
private_kernel_reset_small	-4,031 ✅	-6.18%	-9,027 ✅	-6.78%
private_kernel_reset_tiny	-3,712 ✅	-6.04%	-7,366 ✅	-6.98%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
private_kernel_tail	14,666 (+9,756)	+198.70%	46,143 (+33,890)	+276.59%
private_kernel_tail_to_public	73,419 (+35,857)	+95.46%	119,640 (+62,520)	+109.45%
parity_root	5,030 (0)	0.00%	5,225,638 (+1,046,472)	+25.04%
rollup_merge	2,852 (0)	0.00%	2,618,272 (+523,237)	+24.98%
rollup_root	4,337 (0)	0.00%	3,964,595 (+784,853)	+24.68%
public_kernel_setup	217,039 (0)	0.00%	1,838,210 (+261,618)	+16.59%
public_kernel_teardown	296,142 (0)	0.00%	1,918,954 (+261,619)	+15.79%
rollup_base	349,423 (0)	0.00%	9,080,912 (+261,618)	+2.97%
public_kernel_tail	1,006,333 (0)	0.00%	9,389,601 (+261,618)	+2.87%
private_kernel_reset	108,942 (-8,112)	-6.93%	489,428 (-31,234)	-6.00%
private_kernel_reset_big	81,638 (-5,941)	-6.78%	280,636 (-18,990)	-6.34%
private_kernel_reset_medium	67,985 (-4,669)	-6.43%	176,239 (-12,349)	-6.55%
private_kernel_reset_small	61,158 (-4,031)	-6.18%	124,144 (-9,027)	-6.78%
private_kernel_reset_tiny	57,746 (-3,712)	-6.04%	98,186 (-7,366)	-6.98%

lucasxia01 · 2024-08-02T12:25:05Z

barretenberg/cpp/src/barretenberg/stdlib/honk_recursion/verifier/ultra_recursive_verifier.cpp

+        }
+        nested_agg_obj =
+            convert_witness_indices_to_agg_obj<Builder, typename Flavor::Curve>(*builder, nested_agg_obj_indices);
+    } else { // Simulator cannot deal with witness indices


really ugly stuff here

yeah not bullish on the simulator

ledwards2225 · 2024-08-05T20:04:12Z

...etenberg/cpp/src/barretenberg/stdlib/plonk_recursion/aggregation_state/aggregation_state.hpp

+    constexpr uint32_t TOTAL_BITS = 254;
+
+    // TODO(https://github.com/AztecProtocol/barretenberg/issues/911): These are pairing points extracted from a valid
+    // proof. This is a workaround because we can't represent the point at infinity in biggroup yet.


Is this still true?

I haven't tried using the pt at infinity (and I'm scared to). Could definitely try though, maybe in a followup pr

yeah was mostly just curious, doesn't need to happen now

barretenberg/cpp/src/barretenberg/dsl/acir_format/honk_recursion_constraint.cpp

ledwards2225

Looks good in general (pending passing tests and appropriate updates in AztecIvc of course). A lot of this agg stuff seems kind of brittle and manual, which I know is largely coming from a model that's existed for a long time. Would like to continue to try to make this more robust and intuitive

ledwards2225 · 2024-08-05T20:21:46Z

barretenberg/cpp/src/barretenberg/dsl/acir_format/honk_recursion_constraint.cpp

@@ -139,11 +98,13 @@ AggregationObjectIndices create_honk_recursion_constraints(Builder& builder,
        builder.assert_equal(builder.add_variable(1 << log_circuit_size), key_fields[0].witness_index);
        builder.assert_equal(builder.add_variable(input.public_inputs.size()), key_fields[1].witness_index);
        builder.assert_equal(builder.add_variable(UltraFlavor::has_zero_row ? 1 : 0), key_fields[2].witness_index);
-        builder.assert_equal(builder.add_variable(0), key_fields[4].witness_index);
+        builder.assert_equal(builder.add_variable(1), key_fields[4].witness_index);


What is this magic 1 here?

this section needs more comments in general oops. This 1 is the "has_recursive_proof" bool which is pretty useless since all circuits have an aggregation object now.

ledwards2225 · 2024-08-05T20:29:29Z

barretenberg/cpp/src/barretenberg/dsl/acir_format/honk_recursion_constraint.cpp

-        // TODO(https://github.com/AztecProtocol/barretenberg/issues/1059): Properly set this to a default agg obj.
+        size_t num_inner_public_inputs = input.public_inputs.size() - bb::AGGREGATION_OBJECT_SIZE;
+
+        // We are making the assumption that the aggregation object are behind all the inner public inputs


Seems like there's some brittleness in how things are arranged. I wonder if we can't find a way to make the ordering of things a little less manual and potentially brittle

barretenberg/cpp/src/barretenberg/dsl/acir_format/honk_recursion_constraint.cpp

ledwards2225 · 2024-08-05T20:48:38Z

barretenberg/cpp/src/barretenberg/stdlib/honk_recursion/verifier/ultra_recursive_verifier.cpp

+        }
+        nested_agg_obj =
+            convert_witness_indices_to_agg_obj<Builder, typename Flavor::Curve>(*builder, nested_agg_obj_indices);
+    } else { // Simulator cannot deal with witness indices


yeah not bullish on the simulator

ledwards2225 · 2024-08-05T20:55:58Z

...etenberg/cpp/src/barretenberg/stdlib/plonk_recursion/aggregation_state/aggregation_state.hpp


        auto* context = P0.get_context();

        CircuitChecker::check(*context);
-        info("checked circuit before add_recursive_proof");
        context->add_recursive_proof(proof_witness_indices);


What's up with the use of the word 'proof' here in proof_witness_indices and add_recursive_proof? Seems misleading to refer to the aggregation object as a proof

yeah, it's a relic of the past. I agree its poor naming

...etenberg/cpp/src/barretenberg/stdlib/plonk_recursion/aggregation_state/aggregation_state.hpp

ledwards2225 · 2024-08-05T21:13:49Z

barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_goblin.hpp

@@ -39,7 +39,8 @@ element<C, Fq, Fr, G> element<C, Fq, Fr, G>::goblin_batch_mul(const std::vector<
    // Loop over all points and scalars
    size_t num_points = points.size();
    for (size_t i = 0; i < num_points; ++i) {
-        auto& point = points[i];
+        auto tmp_point = points[i].normalize();


Seems possible it has something to do with this

ledwards2225 · 2024-08-05T21:14:51Z

...etenberg/cpp/src/barretenberg/stdlib/plonk_recursion/aggregation_state/aggregation_state.hpp

+    constexpr uint32_t TOTAL_BITS = 254;
+
+    // TODO(https://github.com/AztecProtocol/barretenberg/issues/911): These are pairing points extracted from a valid
+    // proof. This is a workaround because we can't represent the point at infinity in biggroup yet.


yeah was mostly just curious, doesn't need to happen now

…obj-handling

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.49.0</summary> ## [0.49.0](aztec-package-v0.48.0...aztec-package-v0.49.0) (2024-08-15) ### ⚠ BREAKING CHANGES * Sequencer no longer proves ([#7860](#7860)) ### Miscellaneous * Enable execute command on aws ecs services ([#7975](#7975)) ([4331bc6](4331bc6)) * Sequencer no longer proves ([#7860](#7860)) ([7168290](7168290)) * Terraform template for prover-node ([#7846](#7846)) ([546f946](546f946)) </details> <details><summary>barretenberg.js: 0.49.0</summary> ## [0.49.0](barretenberg.js-v0.48.0...barretenberg.js-v0.49.0) (2024-08-15) ### Miscellaneous * Pin yarn versions in noir-projects and bb/ts ([#7988](#7988)) ([83f33a1](83f33a1)) </details> <details><summary>aztec-packages: 0.49.0</summary> ## [0.49.0](aztec-packages-v0.48.0...aztec-packages-v0.49.0) (2024-08-15) ### ⚠ BREAKING CHANGES * alternative key registry contract ([#7523](#7523)) * Sequencer no longer proves ([#7860](#7860)) ### Features * Add `FunctionDefinition::parameters`, `FunctionDefinition::return_type` and `impl Eq for Quoted` (noir-lang/noir#5681) ([b1c7374](b1c7374)) * Add `Quoted::as_expr` and `Expr::as_function_call` (noir-lang/noir#5708) ([91042c7](91042c7)) * Add `Type::as_struct` (noir-lang/noir#5680) ([b1c7374](b1c7374)) * Add `Type::get_trait_impl` (noir-lang/noir#5716) ([ccbef55](ccbef55)) * Add `Type::implements` (noir-lang/noir#5701) ([91042c7](91042c7)) * Add `Type::is_field` and `Type::as_integer` (noir-lang/noir#5670) ([b1c7374](b1c7374)) * Add `Type` methods: `as_tuple`, `as_slice`, `as_array`, `as_constant`, `is_bool` (noir-lang/noir#5678) ([b1c7374](b1c7374)) * Add a limited form of arithmetic on generics (noir-lang/noir#5625) ([b1c7374](b1c7374)) * Add array_to_str_lossy (noir-lang/noir#5613) ([b1c7374](b1c7374)) * Add generate-secret-and-hash to cli ([#7977](#7977)) ([cdf62a0](cdf62a0)) * Add mutating FunctionDefinition functions (noir-lang/noir#5685) ([b1c7374](b1c7374)) * Add proven flag to sent tx wait opts ([#7950](#7950)) ([e80e7d2](e80e7d2)) * Add some `Module` comptime functions (noir-lang/noir#5684) ([b1c7374](b1c7374)) * Alternative key registry contract ([#7523](#7523)) ([3e6a20f](3e6a20f)) * **avm:** More no fake rows + virtual dyn gas (part 1) ([#7942](#7942)) ([9e8ba96](9e8ba96)) * Derive `Ord` and `Hash` in the stdlib; add `std::meta::make_impl` helper (noir-lang/noir#5683) ([b1c7374](b1c7374)) * Destroy_note_unsafe ([#7891](#7891)) ([5cda7ba](5cda7ba)) * **docs:** Nits ([#7838](#7838)) ([a76c999](a76c999)) * Enable UltraHonk verifier ([#7923](#7923)) ([5e8b4a8](5e8b4a8)), closes [#7373](#7373) * Implement closures in the comptime interpreter (noir-lang/noir#5682) ([b1c7374](b1c7374)) * IVC integration tests using new accumulate model ([#7946](#7946)) ([c527ae9](c527ae9)) * LSP autocompletion for use statement (noir-lang/noir#5704) ([91042c7](91042c7)) * LSP closing brace hints (noir-lang/noir#5686) ([b1c7374](b1c7374)) * LSP fields, functions and methods completion after "." and "::" (noir-lang/noir#5714) ([ccbef55](ccbef55)) * LSP hover now includes "Go to" links (noir-lang/noir#5677) ([b1c7374](b1c7374)) * LSP path completion (noir-lang/noir#5712) ([91042c7](91042c7)) * **noir_js:** Expose UltraHonk and integration tests (noir-lang/noir#5656) ([b1c7374](b1c7374)) * Optimizing PrivateFPC ([#7980](#7980)) ([d018335](d018335)) * Private refunds optimizations ([#7968](#7968)) ([cea8295](cea8295)) * Resolve arguments to attributes (noir-lang/noir#5649) ([b1c7374](b1c7374)) * **ssa:** Simple serialization of unoptimized SSA to file (noir-lang/noir#5679) ([b1c7374](b1c7374)) * Sync from aztec-packages (noir-lang/noir#5718) ([ccbef55](ccbef55)) * Update honk ultra_recursive_verifier to do aggregation ([#7582](#7582)) ([a96a5ad](a96a5ad)) ### Bug Fixes * Add locations to most SSA instructions (noir-lang/noir#5697) ([b1c7374](b1c7374)) * Allow txs on block zero ([#7928](#7928)) ([5e25cd6](5e25cd6)) * Build error in e2e_block_building ([0d0646d](0d0646d)) * **debugger:** Update the debugger to handle the new Brillig debug metadata format (noir-lang/noir#5706) ([91042c7](91042c7)) * Delete forks after proving job has finished ([#7972](#7972)) ([2b4a842](2b4a842)) * Deploy verifier cmd ([#7983](#7983)) ([f4fa797](f4fa797)) * Derive generic types (noir-lang/noir#5674) ([b1c7374](b1c7374)) * Do not duplicate redundant Brillig debug metadata (noir-lang/noir#5696) ([b1c7374](b1c7374)) * Do not mount ssh agent on OSX ([#7991](#7991)) ([950db8e](950db8e)) * **docs:** Add redirects for website links ([#7979](#7979)) ([e890814](e890814)) * Elaborate struct & trait annotations in the correct module (noir-lang/noir#5643) ([b1c7374](b1c7374)) * Fix where clause issue in items generated from attributes (noir-lang/noir#5673) ([b1c7374](b1c7374)) * Lay plumbing for having simulations throw an error if they cannot be added in a block ([#7839](#7839)) ([eedbc11](eedbc11)) * Let a trait impl that relies on another trait work (noir-lang/noir#5646) ([b1c7374](b1c7374)) * Only record bytecode if >0 ([#7932](#7932)) ([3f145b3](3f145b3)) * Remove missing file ([#7941](#7941)) ([4d9290f](4d9290f)) * Replace unused ArrayGet/Set with constrain if possibly out of bounds (noir-lang/noir#5691) ([ccbef55](ccbef55)) * Switch verify proof to arrays (noir-lang/noir#5664) ([b1c7374](b1c7374)) * Track L1 block for last L2 block body retrieved ([#7927](#7927)) ([cd36be4](cd36be4)), closes [#7918](#7918) * Unexpose get note nonces on pxe ([#7889](#7889)) ([163c3a6](163c3a6)) * Use data dir for lmdb forks ([#7973](#7973)) ([5b53d43](5b53d43)) * Workaround from_slice with nested slices (noir-lang/noir#5648) ([b1c7374](b1c7374)) ### Miscellaneous * Add docs tip about filenames between commands (noir-lang/noir#5695) ([b1c7374](b1c7374)) * Add env var to disable bb cleanup ([#7936](#7936)) ([806a370](806a370)) * Add parser support for `<MyType as Trait>::ident` (noir-lang/noir#5688) ([b1c7374](b1c7374)) * Add tests for noir<>ivc integration testing ([#7931](#7931)) ([7cc47a6](7cc47a6)) * Allow passing custom executors to fuzzer (noir-lang/noir#5710) ([91042c7](91042c7)) * **avm:** Fewer errors unless testing ([#7943](#7943)) ([33b65a9](33b65a9)) * **bb:** Constexpr simplifications ([#7906](#7906)) ([65d3b7f](65d3b7f)) * **bb:** Prereq work for polynomial mem optimization ([#7949](#7949)) ([5ca5138](5ca5138)) * **ci:** Print detailed target timings ([#7934](#7934)) ([fb574aa](fb574aa)) * Do not clean up bb files on err ([#7985](#7985)) ([75c6768](75c6768)) * Enable execute command on aws ecs services ([#7975](#7975)) ([4331bc6](4331bc6)) * Ensure bootstrapped networks have no pending blocks when proving starts ([#7986](#7986)) ([fb471b3](fb471b3)) * Fork logs and prover job catch ([#7982](#7982)) ([69bde53](69bde53)) * Move siloing to reset ([#7871](#7871)) ([014b5f0](014b5f0)) * Pin yarn versions in noir-projects and bb/ts ([#7988](#7988)) ([83f33a1](83f33a1)) * Release Noir(0.33.0) (noir-lang/noir#5550) ([b1c7374](b1c7374)) * Replace relative paths to noir-protocol-circuits ([cd5f138](cd5f138)) * Replace relative paths to noir-protocol-circuits ([6f3cef9](6f3cef9)) * Replace relative paths to noir-protocol-circuits ([54c4441](54c4441)) * Replace VERSION with IMAGE on provernet template ([d5e48aa](d5e48aa)) * Sequencer no longer proves ([#7860](#7860)) ([7168290](7168290)) * Simplify registry ([#7939](#7939)) ([8e0418f](8e0418f)) * Terraform template for prover-node ([#7846](#7846)) ([546f946](546f946)) * Update provernet docker compose template ([#7929](#7929)) ([33d47d2](33d47d2)) * Updating token with refunds ([#7969](#7969)) ([504deba](504deba)) </details> <details><summary>barretenberg: 0.49.0</summary> ## [0.49.0](barretenberg-v0.48.0...barretenberg-v0.49.0) (2024-08-15) ### Features * **avm:** More no fake rows + virtual dyn gas (part 1) ([#7942](#7942)) ([9e8ba96](9e8ba96)) * IVC integration tests using new accumulate model ([#7946](#7946)) ([c527ae9](c527ae9)) * Update honk ultra_recursive_verifier to do aggregation ([#7582](#7582)) ([a96a5ad](a96a5ad)) ### Miscellaneous * **avm:** Fewer errors unless testing ([#7943](#7943)) ([33b65a9](33b65a9)) * **bb:** Constexpr simplifications ([#7906](#7906)) ([65d3b7f](65d3b7f)) * **bb:** Prereq work for polynomial mem optimization ([#7949](#7949)) ([5ca5138](5ca5138)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.49.0</summary> ## [0.49.0](AztecProtocol/aztec-packages@aztec-package-v0.48.0...aztec-package-v0.49.0) (2024-08-15) ### ⚠ BREAKING CHANGES * Sequencer no longer proves ([#7860](AztecProtocol/aztec-packages#7860)) ### Miscellaneous * Enable execute command on aws ecs services ([#7975](AztecProtocol/aztec-packages#7975)) ([4331bc6](AztecProtocol/aztec-packages@4331bc6)) * Sequencer no longer proves ([#7860](AztecProtocol/aztec-packages#7860)) ([7168290](AztecProtocol/aztec-packages@7168290)) * Terraform template for prover-node ([#7846](AztecProtocol/aztec-packages#7846)) ([546f946](AztecProtocol/aztec-packages@546f946)) </details> <details><summary>barretenberg.js: 0.49.0</summary> ## [0.49.0](AztecProtocol/aztec-packages@barretenberg.js-v0.48.0...barretenberg.js-v0.49.0) (2024-08-15) ### Miscellaneous * Pin yarn versions in noir-projects and bb/ts ([#7988](AztecProtocol/aztec-packages#7988)) ([83f33a1](AztecProtocol/aztec-packages@83f33a1)) </details> <details><summary>aztec-packages: 0.49.0</summary> ## [0.49.0](AztecProtocol/aztec-packages@aztec-packages-v0.48.0...aztec-packages-v0.49.0) (2024-08-15) ### ⚠ BREAKING CHANGES * alternative key registry contract ([#7523](AztecProtocol/aztec-packages#7523)) * Sequencer no longer proves ([#7860](AztecProtocol/aztec-packages#7860)) ### Features * Add `FunctionDefinition::parameters`, `FunctionDefinition::return_type` and `impl Eq for Quoted` (noir-lang/noir#5681) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add `Quoted::as_expr` and `Expr::as_function_call` (noir-lang/noir#5708) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * Add `Type::as_struct` (noir-lang/noir#5680) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add `Type::get_trait_impl` (noir-lang/noir#5716) ([ccbef55](AztecProtocol/aztec-packages@ccbef55)) * Add `Type::implements` (noir-lang/noir#5701) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * Add `Type::is_field` and `Type::as_integer` (noir-lang/noir#5670) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add `Type` methods: `as_tuple`, `as_slice`, `as_array`, `as_constant`, `is_bool` (noir-lang/noir#5678) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add a limited form of arithmetic on generics (noir-lang/noir#5625) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add array_to_str_lossy (noir-lang/noir#5613) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add generate-secret-and-hash to cli ([#7977](AztecProtocol/aztec-packages#7977)) ([cdf62a0](AztecProtocol/aztec-packages@cdf62a0)) * Add mutating FunctionDefinition functions (noir-lang/noir#5685) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add proven flag to sent tx wait opts ([#7950](AztecProtocol/aztec-packages#7950)) ([e80e7d2](AztecProtocol/aztec-packages@e80e7d2)) * Add some `Module` comptime functions (noir-lang/noir#5684) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Alternative key registry contract ([#7523](AztecProtocol/aztec-packages#7523)) ([3e6a20f](AztecProtocol/aztec-packages@3e6a20f)) * **avm:** More no fake rows + virtual dyn gas (part 1) ([#7942](AztecProtocol/aztec-packages#7942)) ([9e8ba96](AztecProtocol/aztec-packages@9e8ba96)) * Derive `Ord` and `Hash` in the stdlib; add `std::meta::make_impl` helper (noir-lang/noir#5683) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Destroy_note_unsafe ([#7891](AztecProtocol/aztec-packages#7891)) ([5cda7ba](AztecProtocol/aztec-packages@5cda7ba)) * **docs:** Nits ([#7838](AztecProtocol/aztec-packages#7838)) ([a76c999](AztecProtocol/aztec-packages@a76c999)) * Enable UltraHonk verifier ([#7923](AztecProtocol/aztec-packages#7923)) ([5e8b4a8](AztecProtocol/aztec-packages@5e8b4a8)), closes [#7373](AztecProtocol/aztec-packages#7373) * Implement closures in the comptime interpreter (noir-lang/noir#5682) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * IVC integration tests using new accumulate model ([#7946](AztecProtocol/aztec-packages#7946)) ([c527ae9](AztecProtocol/aztec-packages@c527ae9)) * LSP autocompletion for use statement (noir-lang/noir#5704) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * LSP closing brace hints (noir-lang/noir#5686) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * LSP fields, functions and methods completion after "." and "::" (noir-lang/noir#5714) ([ccbef55](AztecProtocol/aztec-packages@ccbef55)) * LSP hover now includes "Go to" links (noir-lang/noir#5677) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * LSP path completion (noir-lang/noir#5712) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * **noir_js:** Expose UltraHonk and integration tests (noir-lang/noir#5656) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Optimizing PrivateFPC ([#7980](AztecProtocol/aztec-packages#7980)) ([d018335](AztecProtocol/aztec-packages@d018335)) * Private refunds optimizations ([#7968](AztecProtocol/aztec-packages#7968)) ([cea8295](AztecProtocol/aztec-packages@cea8295)) * Resolve arguments to attributes (noir-lang/noir#5649) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * **ssa:** Simple serialization of unoptimized SSA to file (noir-lang/noir#5679) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Sync from aztec-packages (noir-lang/noir#5718) ([ccbef55](AztecProtocol/aztec-packages@ccbef55)) * Update honk ultra_recursive_verifier to do aggregation ([#7582](AztecProtocol/aztec-packages#7582)) ([a96a5ad](AztecProtocol/aztec-packages@a96a5ad)) ### Bug Fixes * Add locations to most SSA instructions (noir-lang/noir#5697) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Allow txs on block zero ([#7928](AztecProtocol/aztec-packages#7928)) ([5e25cd6](AztecProtocol/aztec-packages@5e25cd6)) * Build error in e2e_block_building ([0d0646d](AztecProtocol/aztec-packages@0d0646d)) * **debugger:** Update the debugger to handle the new Brillig debug metadata format (noir-lang/noir#5706) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * Delete forks after proving job has finished ([#7972](AztecProtocol/aztec-packages#7972)) ([2b4a842](AztecProtocol/aztec-packages@2b4a842)) * Deploy verifier cmd ([#7983](AztecProtocol/aztec-packages#7983)) ([f4fa797](AztecProtocol/aztec-packages@f4fa797)) * Derive generic types (noir-lang/noir#5674) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Do not duplicate redundant Brillig debug metadata (noir-lang/noir#5696) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Do not mount ssh agent on OSX ([#7991](AztecProtocol/aztec-packages#7991)) ([950db8e](AztecProtocol/aztec-packages@950db8e)) * **docs:** Add redirects for website links ([#7979](AztecProtocol/aztec-packages#7979)) ([e890814](AztecProtocol/aztec-packages@e890814)) * Elaborate struct & trait annotations in the correct module (noir-lang/noir#5643) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Fix where clause issue in items generated from attributes (noir-lang/noir#5673) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Lay plumbing for having simulations throw an error if they cannot be added in a block ([#7839](AztecProtocol/aztec-packages#7839)) ([eedbc11](AztecProtocol/aztec-packages@eedbc11)) * Let a trait impl that relies on another trait work (noir-lang/noir#5646) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Only record bytecode if >0 ([#7932](AztecProtocol/aztec-packages#7932)) ([3f145b3](AztecProtocol/aztec-packages@3f145b3)) * Remove missing file ([#7941](AztecProtocol/aztec-packages#7941)) ([4d9290f](AztecProtocol/aztec-packages@4d9290f)) * Replace unused ArrayGet/Set with constrain if possibly out of bounds (noir-lang/noir#5691) ([ccbef55](AztecProtocol/aztec-packages@ccbef55)) * Switch verify proof to arrays (noir-lang/noir#5664) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Track L1 block for last L2 block body retrieved ([#7927](AztecProtocol/aztec-packages#7927)) ([cd36be4](AztecProtocol/aztec-packages@cd36be4)), closes [#7918](AztecProtocol/aztec-packages#7918) * Unexpose get note nonces on pxe ([#7889](AztecProtocol/aztec-packages#7889)) ([163c3a6](AztecProtocol/aztec-packages@163c3a6)) * Use data dir for lmdb forks ([#7973](AztecProtocol/aztec-packages#7973)) ([5b53d43](AztecProtocol/aztec-packages@5b53d43)) * Workaround from_slice with nested slices (noir-lang/noir#5648) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) ### Miscellaneous * Add docs tip about filenames between commands (noir-lang/noir#5695) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add env var to disable bb cleanup ([#7936](AztecProtocol/aztec-packages#7936)) ([806a370](AztecProtocol/aztec-packages@806a370)) * Add parser support for `<MyType as Trait>::ident` (noir-lang/noir#5688) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Add tests for noir<>ivc integration testing ([#7931](AztecProtocol/aztec-packages#7931)) ([7cc47a6](AztecProtocol/aztec-packages@7cc47a6)) * Allow passing custom executors to fuzzer (noir-lang/noir#5710) ([91042c7](AztecProtocol/aztec-packages@91042c7)) * **avm:** Fewer errors unless testing ([#7943](AztecProtocol/aztec-packages#7943)) ([33b65a9](AztecProtocol/aztec-packages@33b65a9)) * **bb:** Constexpr simplifications ([#7906](AztecProtocol/aztec-packages#7906)) ([65d3b7f](AztecProtocol/aztec-packages@65d3b7f)) * **bb:** Prereq work for polynomial mem optimization ([#7949](AztecProtocol/aztec-packages#7949)) ([5ca5138](AztecProtocol/aztec-packages@5ca5138)) * **ci:** Print detailed target timings ([#7934](AztecProtocol/aztec-packages#7934)) ([fb574aa](AztecProtocol/aztec-packages@fb574aa)) * Do not clean up bb files on err ([#7985](AztecProtocol/aztec-packages#7985)) ([75c6768](AztecProtocol/aztec-packages@75c6768)) * Enable execute command on aws ecs services ([#7975](AztecProtocol/aztec-packages#7975)) ([4331bc6](AztecProtocol/aztec-packages@4331bc6)) * Ensure bootstrapped networks have no pending blocks when proving starts ([#7986](AztecProtocol/aztec-packages#7986)) ([fb471b3](AztecProtocol/aztec-packages@fb471b3)) * Fork logs and prover job catch ([#7982](AztecProtocol/aztec-packages#7982)) ([69bde53](AztecProtocol/aztec-packages@69bde53)) * Move siloing to reset ([#7871](AztecProtocol/aztec-packages#7871)) ([014b5f0](AztecProtocol/aztec-packages@014b5f0)) * Pin yarn versions in noir-projects and bb/ts ([#7988](AztecProtocol/aztec-packages#7988)) ([83f33a1](AztecProtocol/aztec-packages@83f33a1)) * Release Noir(0.33.0) (noir-lang/noir#5550) ([b1c7374](AztecProtocol/aztec-packages@b1c7374)) * Replace relative paths to noir-protocol-circuits ([cd5f138](AztecProtocol/aztec-packages@cd5f138)) * Replace relative paths to noir-protocol-circuits ([6f3cef9](AztecProtocol/aztec-packages@6f3cef9)) * Replace relative paths to noir-protocol-circuits ([54c4441](AztecProtocol/aztec-packages@54c4441)) * Replace VERSION with IMAGE on provernet template ([d5e48aa](AztecProtocol/aztec-packages@d5e48aa)) * Sequencer no longer proves ([#7860](AztecProtocol/aztec-packages#7860)) ([7168290](AztecProtocol/aztec-packages@7168290)) * Simplify registry ([#7939](AztecProtocol/aztec-packages#7939)) ([8e0418f](AztecProtocol/aztec-packages@8e0418f)) * Terraform template for prover-node ([#7846](AztecProtocol/aztec-packages#7846)) ([546f946](AztecProtocol/aztec-packages@546f946)) * Update provernet docker compose template ([#7929](AztecProtocol/aztec-packages#7929)) ([33d47d2](AztecProtocol/aztec-packages@33d47d2)) * Updating token with refunds ([#7969](AztecProtocol/aztec-packages#7969)) ([504deba](AztecProtocol/aztec-packages@504deba)) </details> <details><summary>barretenberg: 0.49.0</summary> ## [0.49.0](AztecProtocol/aztec-packages@barretenberg-v0.48.0...barretenberg-v0.49.0) (2024-08-15) ### Features * **avm:** More no fake rows + virtual dyn gas (part 1) ([#7942](AztecProtocol/aztec-packages#7942)) ([9e8ba96](AztecProtocol/aztec-packages@9e8ba96)) * IVC integration tests using new accumulate model ([#7946](AztecProtocol/aztec-packages#7946)) ([c527ae9](AztecProtocol/aztec-packages@c527ae9)) * Update honk ultra_recursive_verifier to do aggregation ([#7582](AztecProtocol/aztec-packages#7582)) ([a96a5ad](AztecProtocol/aztec-packages@a96a5ad)) ### Miscellaneous * **avm:** Fewer errors unless testing ([#7943](AztecProtocol/aztec-packages#7943)) ([33b65a9](AztecProtocol/aztec-packages@33b65a9)) * **bb:** Constexpr simplifications ([#7906](AztecProtocol/aztec-packages#7906)) ([65d3b7f](AztecProtocol/aztec-packages@65d3b7f)) * **bb:** Prereq work for polynomial mem optimization ([#7949](AztecProtocol/aztec-packages#7949)) ([5ca5138](AztecProtocol/aztec-packages@5ca5138)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

lucasxia01 added 10 commits July 12, 2024 21:20

honk recursion constraint tests in dsl_tests pass

d024c54

fix verify_honk_proof inputs to take in agg obj

8a2a33e

Merge branch 'master' into lx/reinstate-aggregation

47d2806

change to 409 in rollup, renable agg obj in a couple ts files

83cfed3

Merge branch 'lx/reinstate-aggregation' of github.com:AztecProtocol/a…

dd7daea

…ztec-packages into lx/reinstate-aggregation

forgot to fix the tube function

ae4ccd7

bb prover fix

2153d8b

added fake agg obj to tube circuit to pass full test

f67f529

initialize interface change

ab0b2bb

updated function interfaces, bb compilies

c3be434

lucasxia01 self-assigned this Jul 23, 2024

lucasxia01 changed the base branch from master to lx/reinstate-aggregation July 23, 2024 18:15

AztecBot reviewed Jul 23, 2024

View reviewed changes

remove public_inputs and proof_witness_indices fields of aggregation_…

010062b

…state_ct to see their use (pretty much none)

Base automatically changed from lx/reinstate-aggregation to master July 25, 2024 10:36

lucasxia01 mentioned this pull request Jul 25, 2024

feat: adding aggregation to honk and rollup #7466

Merged

lucasxia01 added 5 commits July 29, 2024 08:09

Merge remote-tracking branch 'origin/master' into lx/update-honk-agg-…

25df38f

…obj-handling

Merge remote-tracking branch 'origin/master' into lx/update-honk-agg-…

e1116ce

…obj-handling

fix weird merge changes

ea47e7a

redo something merge erased

2c07750

fix write_vk flow to have default agg obj for dummy key

ff25f3c

lucasxia01 added 3 commits July 30, 2024 08:25

do aggregation in ultra_recursive_verifier

70c414d

enabling/refactoring honk_recursion_constraint to use agg objs

f074801

fixed write_vk flow to correctly set the vk recursive_proof_public_in…

603ecd1

…put_indices and the agg obj in public inputs

lucasxia01 added 2 commits July 30, 2024 13:41

refactor to use shared functionality in aggregation_state.hpp

11231d3

update tests to pass in a default or handle an agg obj

20f254f

clean up PR

9c4e62b

lucasxia01 marked this pull request as ready for review August 2, 2024 10:57

lucasxia01 commented Aug 2, 2024

View reviewed changes

ledwards2225 reviewed Aug 5, 2024

View reviewed changes

barretenberg/cpp/src/barretenberg/dsl/acir_format/honk_recursion_constraint.cpp Outdated Show resolved Hide resolved

ledwards2225 approved these changes Aug 5, 2024

View reviewed changes

lucasxia01 added 3 commits August 7, 2024 20:09

fix tests

553fb2d

fixed problems?

aed087e

try reverting change to ultra rec verifier

5b9920f

lucasxia01 force-pushed the lx/update-honk-agg-obj-handling branch from 736d6a3 to 5b9920f Compare August 7, 2024 20:10

lucasxia01 added 13 commits August 8, 2024 15:07

undo moving add_recursive_proof change

02e17ac

oops, fix to previous commit

3305c90

try running CI with debug statements

32a11ac

try a fix for prove_tube (there's two agg objs)

3ff3fb2

Merge remote-tracking branch 'origin/master' into lx/update-honk-agg-…

e9479a5

…obj-handling

add agg obj to aztec ivc

fe46e5f

remove extra agg object in client ivc test

cea4738

just throw an error when you try to add multiple agg objs

156aba5

refactor honk recursion constraint (moved dummy stuff to a function)

4c50c74

added assert_is_in_field to agg_obj function to properly constrain it

45f0329

undo full test change

37c8392

removing some print statements DISABLE_CI

9245975

Merge remote-tracking branch 'origin/master' into lx/update-honk-agg-…

e9035dd

…obj-handling

lucasxia01 enabled auto-merge (squash) August 12, 2024 21:25

remove throw error and replace with assert

eeda4a1

lucasxia01 merged commit a96a5ad into master Aug 13, 2024
96 checks passed

lucasxia01 deleted the lx/update-honk-agg-obj-handling branch August 13, 2024 14:33

AztecBot mentioned this pull request Aug 13, 2024

chore(master): Release 0.49.0 #7933

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update honk ultra_recursive_verifier to do aggregation #7582

feat: update honk ultra_recursive_verifier to do aggregation #7582

lucasxia01 commented Jul 23, 2024 •

edited

Loading

AztecBot left a comment •

edited

Loading

AztecBot commented Jul 29, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

github-actions bot commented Jul 30, 2024 •

edited

Loading

lucasxia01 Aug 2, 2024

ledwards2225 Aug 5, 2024

ledwards2225 Aug 5, 2024

lucasxia01 Aug 5, 2024 •

edited

Loading

ledwards2225 Aug 5, 2024

ledwards2225 left a comment •

edited

Loading

ledwards2225 Aug 5, 2024

lucasxia01 Aug 5, 2024

ledwards2225 Aug 5, 2024

ledwards2225 Aug 5, 2024

ledwards2225 Aug 5, 2024

lucasxia01 Aug 5, 2024

ledwards2225 Aug 5, 2024

ledwards2225 Aug 5, 2024

feat: update honk ultra_recursive_verifier to do aggregation #7582

feat: update honk ultra_recursive_verifier to do aggregation #7582

Conversation

lucasxia01 commented Jul 23, 2024 • edited Loading

AztecBot left a comment • edited Loading

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

AztecBot commented Jul 29, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

github-actions bot commented Jul 30, 2024 • edited Loading

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasxia01 Aug 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ledwards2225 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasxia01 commented Jul 23, 2024 •

edited

Loading

AztecBot left a comment •

edited

Loading

AztecBot commented Jul 29, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024 •

edited

Loading

lucasxia01 Aug 5, 2024 •

edited

Loading

ledwards2225 left a comment •

edited

Loading