Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LinuxFramebuffer): Allow set DRM output Connector #14878

Conversation

workgroupengineering
Copy link
Contributor

What does the pull request do?

Allow set DRM output Connector

What is the current behavior?

Always use the predefined output connector.

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0045918-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@kekekeks kekekeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but rather noisy on the whitespace changes

@workgroupengineering
Copy link
Contributor Author

If you want I delete the commit of the code formatting 444af27


internal static class EnumerableExtesions
{
public static IEnumerable<TSource> Where<TSource, TArg>(this IEnumerable<TSource> source, Func<TSource, TArg, bool> predicate, TArg arg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this extension here? Simple one pass foreach can work there just fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I would like to avoid closure allocation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this code executed once? Either way, with foreach the same closure can be avoided as well.

Copy link
Member

@maxkatz6 maxkatz6 Mar 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, in Linq Where operator has number of optimizations depending on the input collection type. Custom method implementation probably doesn't help as much. https://github.com/dotnet/runtime/blob/main/src/libraries/System.Linq/src/System/Linq/Where.cs#L36C28-L36C46

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0045988-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@jmacato jmacato requested a review from kekekeks March 11, 2024 09:54
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0046042-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 merged commit fc709df into AvaloniaUI:master Mar 11, 2024
4 of 6 checks passed
@workgroupengineering workgroupengineering deleted the features/Platforms/Linux/FrameBuffer/DRM_Connector branch March 11, 2024 19:53
@maxkatz6 maxkatz6 added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Apr 20, 2024
maxkatz6 pushed a commit that referenced this pull request Apr 20, 2024
* feat(LinuxFramebuffer):  Allow set DRM output Connector

* fix: Code formatting

* fix: Address review

* fix: Address review
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants