-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LinuxFramebuffer): Allow set DRM output Connector #14878
feat(LinuxFramebuffer): Allow set DRM output Connector #14878
Conversation
You can test this PR using the following package version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, but rather noisy on the whitespace changes
If you want I delete the commit of the code formatting 444af27 |
|
||
internal static class EnumerableExtesions | ||
{ | ||
public static IEnumerable<TSource> Where<TSource, TArg>(this IEnumerable<TSource> source, Func<TSource, TArg, bool> predicate, TArg arg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this extension here? Simple one pass foreach can work there just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I would like to avoid closure allocation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this code executed once? Either way, with foreach the same closure can be avoided as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, in Linq Where operator has number of optimizations depending on the input collection type. Custom method implementation probably doesn't help as much. https://github.com/dotnet/runtime/blob/main/src/libraries/System.Linq/src/System/Linq/Where.cs#L36C28-L36C46
You can test this PR using the following package version. |
You can test this PR using the following package version. |
* feat(LinuxFramebuffer): Allow set DRM output Connector * fix: Code formatting * fix: Address review * fix: Address review
What does the pull request do?
Allow set DRM output Connector
What is the current behavior?
Always use the predefined output connector.
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues