-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LinuxFramebuffer): Allow set DRM output Connector #14878
Merged
maxkatz6
merged 4 commits into
AvaloniaUI:master
from
workgroupengineering:features/Platforms/Linux/FrameBuffer/DRM_Connector
Mar 11, 2024
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
namespace Avalonia.LinuxFramebuffer; | ||
|
||
/// <summary> | ||
/// specific the type of connector is HDMI-A, DVI, DisplayPort, etc. | ||
/// </summary> | ||
public enum DrmConnectorType : uint | ||
{ | ||
None, | ||
VGA, | ||
DVI_I, | ||
DVI_D, | ||
DVI_A, | ||
Composite, | ||
S_Video, | ||
LVDS, | ||
Component, | ||
DIN, | ||
DisplayPort, | ||
HDMI_A, | ||
HDMI_B, | ||
TV, | ||
eDP, | ||
Virtual, | ||
DSI, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
src/Linux/Avalonia.LinuxFramebuffer/EnumerableExtesions.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
|
||
namespace Avalonia.LinuxFramebuffer; | ||
|
||
internal static class EnumerableExtesions | ||
{ | ||
public static IEnumerable<TSource> Where<TSource, TArg>(this IEnumerable<TSource> source, Func<TSource, TArg, bool> predicate, TArg arg) | ||
{ | ||
var enumerator = source.GetEnumerator(); | ||
while (enumerator.MoveNext()) | ||
{ | ||
var current = enumerator.Current; | ||
if (predicate(current, arg)) | ||
{ | ||
yield return current; | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this extension here? Simple one pass foreach can work there just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I would like to avoid closure allocation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this code executed once? Either way, with foreach the same closure can be avoided as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, in Linq Where operator has number of optimizations depending on the input collection type. Custom method implementation probably doesn't help as much. https://github.com/dotnet/runtime/blob/main/src/libraries/System.Linq/src/System/Linq/Where.cs#L36C28-L36C46